From patchwork Wed Dec 18 16:57:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Riku Viitanen X-Patchwork-Id: 16557 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 4F1711793F; Wed, 18 Dec 2019 17:28:24 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id F342D1793E for ; Wed, 18 Dec 2019 17:28:22 +0000 (GMT) Received: from localhost ([::1]:58254 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihd7W-0000KJ-5O for patchwork@mira.cbaines.net; Wed, 18 Dec 2019 12:28:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47512) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihd2P-00022X-HZ for guix-patches@gnu.org; Wed, 18 Dec 2019 12:23:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihd2N-0006SE-N5 for guix-patches@gnu.org; Wed, 18 Dec 2019 12:23:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37903) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ihd2M-0006QC-7V for guix-patches@gnu.org; Wed, 18 Dec 2019 12:23:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ihd2M-0007IA-3R for guix-patches@gnu.org; Wed, 18 Dec 2019 12:23:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#38625] Fwd: [bug#38625] [PATCH] music.scm: Add glyr Resent-From: Riku Viitanen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 18 Dec 2019 17:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38625 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 38625@debbugs.gnu.org Received: via spool by 38625-submit@debbugs.gnu.org id=B38625.157668976627983 (code B ref 38625); Wed, 18 Dec 2019 17:23:02 +0000 Received: (at 38625) by debbugs.gnu.org; 18 Dec 2019 17:22:46 +0000 Received: from localhost ([127.0.0.1]:43876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihd24-0007HD-85 for submit@debbugs.gnu.org; Wed, 18 Dec 2019 12:22:46 -0500 Received: from mail-oi1-f169.google.com ([209.85.167.169]:45845) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihceE-0006ct-C5 for 38625@debbugs.gnu.org; Wed, 18 Dec 2019 11:58:06 -0500 Received: by mail-oi1-f169.google.com with SMTP id v10so1355501oiv.12 for <38625@debbugs.gnu.org>; Wed, 18 Dec 2019 08:58:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=UkhAU0JSKqglDEsPeRRNYbx1FYXO6pQco/vlHvJ6E9A=; b=XPdhSo3uT/dV2naFSKpkdNI9OrErD/ctAryzozgK69bdjXprntk0/+vOsHHEWC8gnG kmzUgzIpM3g42DUHP4URuSLSH7U7zEbfQ0VhH//KSmFxdUoVfRPWRYl5Fu+Ip6ZXz+sc P79ZKdn5ifUT4NrXxAusj+5TU2HMza7KZr2rQ7R/IUfaalc+id/HNTa43otDFAxgm5Dx oXhiZAud5FKPdN+Ht2kbTJZ1tvBG99NkCfL1Nkj/ycalCzOmzGv7Hex1CVxSS9WCQ3H7 /MxwVgv7/NXRzoIesECrN6fiXC6n+Rl993vEtVEiIjtyUEdQJCw8W7oxRNVKaAq6/+DU CaoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=UkhAU0JSKqglDEsPeRRNYbx1FYXO6pQco/vlHvJ6E9A=; b=jrk8SlMC/vPGosgV5scbP03ukGf5Ed3jtPENpJS3A4VFmgJ7Qvst750fkVgii4iwcS MSZHktNcMYxA4RbXI8wFNSpIFx7lzFHKYLjgivHxm0rNToLPGkzuGxtbX3r3BsHTtSM4 wlep1g79Xnm17uDKDA3/efvlwswg5Or5NckErk0bctchcJSWcQ0WalhNu24jtYiT4qcE wm0/Gc3POrUXNilO0fNYzqCd24aZzxgsdQfx8Q1o7GsiBInb6Z6AEejkPJanUMALl0og xS3nTl5VDCMZIoQ648FHolnDv0xfaFtOsZZEMyu/xUCKChSNqxqWxosgLMIS5Eoe6TwP skoQ== X-Gm-Message-State: APjAAAWGgwalJMSwhmVZJIvIGit/nncE20SWG3wtafKSMGXb7C3D9i2r 4TUUPzphl3NpliowvgMd3mzZt/Avqn1byMqQk93mgQ== X-Google-Smtp-Source: APXvYqyGOD167lUqE8fl1CqBPqFIKkzVMyYithjB6IS1KK+T4pdf86IhjgQ+BdKkAXy0XUPQxRfQQKKd1xTX92yauqs= X-Received: by 2002:aca:c551:: with SMTP id v78mr967851oif.161.1576688280414; Wed, 18 Dec 2019 08:58:00 -0800 (PST) MIME-Version: 1.0 References: <874ky1cjac.fsf@elephly.net> In-Reply-To: From: Riku Viitanen Date: Wed, 18 Dec 2019 18:57:48 +0200 Message-ID: X-Mailman-Approved-At: Wed, 18 Dec 2019 12:22:43 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi Ricardo, and thanks for the feedback! I think all the mentioned issues should now be fixed. I checked some of the source files, and it turns out they say permit any later version of the license, so I changed the license to lgpl3+. Only the README file mentions "just" LGPLv3 without saying anything about later versions, so I thought it meant the same as "only". Here's the new patch in git format: From 97d4d5d7d16eb87896d81e070510d919118aa622 Mon Sep 17 00:00:00 2001 From: Riku Viitanen Date: Wed, 18 Dec 2019 18:30:14 +0200 Subject: [PATCH] gnu: Add glyr * gnu/packages/music.scm (glyr): New variable --- gnu/packages/music.scm | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) +library for a musicplayer, but has been extended to work as a standalone +program which is able to download cover art, lyrics, photos, biographies, +reviews and more.") + (license license:lgpl3+))) diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index f80fb067e8..0adfa96fbe 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -25,6 +25,7 @@ ;;; Copyright © 2019 raingloom ;;; Copyright © 2019 David Wilson ;;; Copyright © 2019 Alexandros Theodotou +;;; Copyright © 2019 Riku Viitanen ;;; ;;; This file is part of GNU Guix. ;;; @@ -5106,3 +5107,37 @@ MIDI drums and comes as two separate drumkits: Black Pearl and Red Zeppelin.") (description "Helm is a cross-platform polyphonic synthesizer available standalone and as an LV2 plugin.") (license license:gpl3+))) + +(define-public glyr + (package + (name "glyr") + (version "1.0.10") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/sahib/glyr.git") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1miwbqzkhg0v3zysrwh60pj9sv6ci4lzq2vq2hhc6pc6hdyh8xyr")))) + (build-system cmake-build-system) + (arguments + '(#:tests? #f)) + (inputs + `(("glib" ,glib) + ("curl" ,curl) + ("sqlite" ,sqlite))) + (native-inputs + `(("pkg-config" ,pkg-config))) + (home-page "https://github.com/sahib/glyr") + (synopsis "Search engine for music related metadata") + (description + "Glyr comes both in a command-line interface tool (@command{glyrc}) and +as a C library (libglyr), both with an easy to use interface. The sort of +metadata glyr is searching (and downloading) is usually the data you see in +your musicplayer. And indeed, originally it was written to serve as internally