diff mbox series

[bug#52254] Add pqiv.

Message ID AUo9kKBOzkGoIJ09InOPYrKkXp1Zd9Nh_7PtzQVjhmz6xg4F53p9vCtdQx10ecJCAICr_j1b6qZAmd2qns8fxLjYUusMMFI8DeeRsGwi3xI=@protonmail.com
State Accepted
Headers show
Series [bug#52254] Add pqiv. | expand

Checks

Context Check Description
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue

Commit Message

Disseminate Dissent Dec. 3, 2021, 1:16 a.m. UTC
Disseminate
Peace

Comments

Nicolas Goaziou Dec. 5, 2021, 11:30 a.m. UTC | #1
Hello,

Disseminate Dissent via Guix-patches via <guix-patches@gnu.org> writes:

> Subject: [PATCH] Add pqiv.

Thank you.

Your patch actually removes the pqiv package from your local repository.

Anyway, I added the package, re-ordered inputs alphabetically, removed
some buzzwords from the description, fixed indentation, added
a copyright line for you.

Then I completed the commit message and eventually applied the patch.

Please let me know if the name in the copyright line is not appropriate.

Regards,
diff mbox series

Patch

From 7d4e013c36d56fd3f5bb6ff024b61b0b681c01cb Mon Sep 17 00:00:00 2001
From: dissent <disseminatedissent@protonmail.com>
Date: Thu, 2 Dec 2021 20:08:59 -0500
Subject: [PATCH] Add pqiv.

---
 gnu/packages/image-viewers.scm | 46 ----------------------------------
 1 file changed, 46 deletions(-)

diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
index ff03c01ac6..7520d0731a 100644
--- a/gnu/packages/image-viewers.scm
+++ b/gnu/packages/image-viewers.scm
@@ -49,7 +49,6 @@  (define-module (gnu packages image-viewers)
   #:use-module (guix build-system python)
   #:use-module (gnu packages autotools)
   #:use-module (gnu packages algebra)
-  #:use-module (gnu packages backup)
   #:use-module (gnu packages base)
   #:use-module (gnu packages bash)
   #:use-module (gnu packages boost)
@@ -73,7 +72,6 @@  (define-module (gnu packages image-viewers)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages maths)
   #:use-module (gnu packages ncurses)
-  #:use-module (gnu packages pdf)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages perl-check)
   #:use-module (gnu packages photo)
@@ -476,50 +474,6 @@  (define-public nsxiv
 needs.")
     (license license:gpl2+)))
 
-(define-public pqiv
-  (package
-   (name "pqiv")
-   (version "2.12")
-   (source (origin
-            (method git-fetch)
-            (uri (git-reference
-                  (url "https://github.com/phillipberndt/pqiv")
-                  (commit version)))
-            (file-name (git-file-name name version))
-            (sha256
-             (base32
-              "18nvrqmlifh4m8nfs0d19sb9d1l3a95xc89qxqdr881jcxdsgflw"))))
-   (build-system gnu-build-system)
-   (native-inputs
-    `(("pkg-config" ,pkg-config)))
-   (inputs
-    `(("ffmpeg" ,ffmpeg)
-      ("gtk+" ,gtk+)
-      ("imagemagick" ,imagemagick)
-      ("poppler" ,poppler)
-      ("libwebp" ,libwebp)
-      ("libspectre" ,libspectre)
-      ("libarchive" ,libarchive)))
-   (arguments
-    `(#:tests? #f                       ; no tests
-      #:phases
-      (modify-phases %standard-phases
-                     (delete 'configure)) ; no configure script
-      #:make-flags
-      (list
-       (string-append "PREFIX="
-                      (assoc-ref %outputs "out"))
-       (string-append "CC=" ,(cc-for-target))
-       (string-append "PKG_CONFIG=" ,(pkg-config-for-target)))))
-   (synopsis "Powerful image viewer with minimal UI")
-   (description
-    "pqiv is a powerful GTK 3 based command-line image viewer with a minimal UI.
-It is highly customizable, can be fully controlled from scripts, and has support
-for various file formats including PDF, Postscript, video files and archives.
-It is optimized to be quick and responsive.")
-   (home-page "https://www.pberndt.com/Programme/Linux/pqiv")
-   (license license:gpl3+)))
-
 (define-public viewnior
   (package
     (name "viewnior")
-- 
2.34.0