diff mbox series

[bug#73836] gnu: kcolorpicker: Build with -fPIC

Message ID 9ed0e0e450132f629dd220188251ae858cb8d570.1729069965.git.sepeth@fastmail.com
State New
Headers show
Series [bug#73836] gnu: kcolorpicker: Build with -fPIC | expand

Commit Message

Doğan Çeçen Oct. 16, 2024, 9:12 a.m. UTC 
It fixes linking errors when building kimageannotator:

    ...
    ld:
    /gnu/store/...-kcolorpicker-0.3.1/lib/libkColorPicker.a(AbstractPopupMenuButton.cpp.o):
    relocation R_AARCH64_ADR_PREL_PG_HI21 against symbol
    `_ZN15QAbstractButton7clickedEb@@Qt_6' which may bind externally can
    not be used when making a shared object; recompile with -fPIC
    ...

* gnu/packages/kde-frameworks.scm (kcolorpicker)[arguments]: Adjust
  configure-flags to add -fPIC to CMAKE_CXX_FLAGS.

Change-Id: I38c77cc641e48b3e992e8f49fd861d9ada818240
---
 gnu/packages/kde-frameworks.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)


base-commit: 8ffb0c14b8abdbb471788f993a7835add147e3a8

Comments

Z572 Oct. 16, 2024, 11:18 a.m. UTC | #1 
Doğan Çeçen <sepeth@fastmail.com> writes:

> It fixes linking errors when building kimageannotator:
>
>     ...
>     ld:
>     /gnu/store/...-kcolorpicker-0.3.1/lib/libkColorPicker.a(AbstractPopupMenuButton.cpp.o):
>     relocation R_AARCH64_ADR_PREL_PG_HI21 against symbol
>     `_ZN15QAbstractButton7clickedEb@@Qt_6' which may bind externally can
>     not be used when making a shared object; recompile with -fPIC
>     ...
>
> * gnu/packages/kde-frameworks.scm (kcolorpicker)[arguments]: Adjust
>   configure-flags to add -fPIC to CMAKE_CXX_FLAGS.
>
> Change-Id: I38c77cc641e48b3e992e8f49fd861d9ada818240
> ---
>  gnu/packages/kde-frameworks.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index 07b861c672..13d4e24726 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -660,7 +660,8 @@ (define-public kcolorpicker
>      (build-system qt-build-system)
>      (arguments
>       (list #:qtbase qtbase
> -           #:configure-flags #~(list "-DBUILD_TESTS=ON"
> +           #:configure-flags #~(list "-DCMAKE_CXX_FLAGS=-fPIC"
> +                                     "-DBUILD_TESTS=ON"
>                                       "-DBUILD_WITH_QT6=ON")))
>      (home-page "https://github.com/ksnip/kColorPicker")
>      (synopsis "Color Picker with popup menu")
>
> base-commit: 8ffb0c14b8abdbb471788f993a7835add147e3a8
Thanks, push and close.
diff mbox series

Patch

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 07b861c672..13d4e24726 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -660,7 +660,8 @@  (define-public kcolorpicker
     (build-system qt-build-system)
     (arguments
      (list #:qtbase qtbase
-           #:configure-flags #~(list "-DBUILD_TESTS=ON"
+           #:configure-flags #~(list "-DCMAKE_CXX_FLAGS=-fPIC"
+                                     "-DBUILD_TESTS=ON"
                                      "-DBUILD_WITH_QT6=ON")))
     (home-page "https://github.com/ksnip/kColorPicker")
     (synopsis "Color Picker with popup menu")