[bug#73878] gnu: services: Fix readymedia service.

Message ID 9c20a761e4a4812bd04e1112ab0cdfe8f2372f65.1729339847.git.me@fabionatali.com
State New
Headers
Series [bug#73878] gnu: services: Fix readymedia service. |

Commit Message

Fabio Natali Oct. 19, 2024, 12:11 p.m. UTC
  * gnu/services/upnp.scm: Add missing '/n' end-of-line character.

Change-Id: Ib2e584f22526f1969098b843c4be6ee386ed809c
---
Hi,

This is to fix 'readymedia-configuration->config-file'.

In its current version, the procedure may generate a corrupt configuration file.
This patch fixes things by adding a new line character at the end of every
'media_dir=' line.

I hope this looks ok.

Thanks, best wishes, Fabio.

 gnu/services/upnp.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: 48097f511929053468ce6f09e0a24644c90fe670
  

Comments

Arun Isaac Oct. 20, 2024, 12:53 a.m. UTC | #1
Hi Fabio,

Thanks for the patch. I'll push this shortly. My laptop is just busy
building something else at the moment.

Regards,
Arun
  
Arun Isaac Oct. 20, 2024, 11:28 a.m. UTC | #2
Pushed, thanks! I also fixed a couple of minor errors in cf33081e18 and
9b835aae10
  

Patch

diff --git a/gnu/services/upnp.scm b/gnu/services/upnp.scm
index 09121326fe..e5d05add28 100644
--- a/gnu/services/upnp.scm
+++ b/gnu/services/upnp.scm
@@ -115,7 +115,7 @@  (define (readymedia-configuration->config-file config)
                                          (match types
                                            (() (list))
                                            (_ (list ",")))
-                                         (list path))))
+                                         (list path "\n"))))
                         media-directories)
                    (map (match-lambda
                           ((key . value)