diff mbox series

[bug#54589] gnu: emacs-geiser: Update to 0.23.1.

Message ID 9a60062f0fe04694a063d7d872a1963e9069598a.1648336239.git.olivier.dion@polymtl.ca
State Accepted
Headers show
Series [bug#54589] gnu: emacs-geiser: Update to 0.23.1. | expand

Commit Message

Olivier Dion March 26, 2022, 11:11 p.m. UTC 
* gnu/packages/emacs-xyz.scm (emacs-geiser): Update to 0.23.1.
[propagated-inputs]: Add emacs-project.
---
 gnu/packages/emacs-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ludovic Courtès March 29, 2022, 9:29 a.m. UTC | #1 
Hi,

Olivier Dion <olivier.dion@polymtl.ca> skribis:

> * gnu/packages/emacs-xyz.scm (emacs-geiser): Update to 0.23.1.
> [propagated-inputs]: Add emacs-project.

I suppose the emacs-geiser-* packages should be updated at the same
time, shouldn’t they?

Could you send an updated patch that does that too?

Thanks,
Ludo’.
Olivier Dion April 6, 2022, 1:16 a.m. UTC | #2 
On Tue, 29 Mar 2022, Ludovic Courtès <ludo@gnu.org> wrote:
> Hi,

Sorry for the long delay.

> Olivier Dion <olivier.dion@polymtl.ca> skribis:
>
>> * gnu/packages/emacs-xyz.scm (emacs-geiser): Update to 0.23.1.
>> [propagated-inputs]: Add emacs-project.
>
> I suppose the emacs-geiser-* packages should be updated at the same
> time, shouldn’t they?

I don't think so?  Emacs geiser is already bumped at version 0.23.1, but
the commit that introduced that change forgot to add the new dependency
`emacs-project`.

I think that the commit message is confusing, sorry for that.  It should
probably be `Add missing dependency ` and not `Update to ...`.  Let me
know what you think.
Ludovic Courtès April 8, 2022, 9:09 p.m. UTC | #3 
Hi,

Olivier Dion <olivier.dion@polymtl.ca> skribis:

> I don't think so?  Emacs geiser is already bumped at version 0.23.1, but
> the commit that introduced that change forgot to add the new dependency
> `emacs-project`.
>
> I think that the commit message is confusing, sorry for that.  It should
> probably be `Add missing dependency ` and not `Update to ...`.  Let me
> know what you think.

Indeed, I had overlooked that.  Committed with the commit message
adjusted accordingly.

Thanks,
Ludo’.
diff mbox series

Patch

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 42fc13f4c2..57a2f574c5 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -271,7 +271,7 @@  (define-public emacs-geiser
     (native-inputs
      (list texinfo))
     (propagated-inputs
-     (list emacs-transient))
+     (list emacs-project emacs-transient))
     (home-page "https://nongnu.org/geiser/")
     (synopsis "Collection of Emacs modes for Scheme hacking")
     (description