diff mbox series

[bug#42958,core-updates,05/29] gnu: gobject-introspection: Update package, definition.

Message ID 99547ba6-ba27-7b8f-a6da-ba0b3ccb9965@disroot.org
State Accepted
Headers show
Series None | expand

Checks

Context Check Description
cbaines/applying patch fail View Laminar job

Commit Message

Raghav Gururajan Sept. 24, 2020, 1:14 p.m. UTC 
@Danny

Please find the attached split patches.

Regards,
RG.

Comments

Danny Milosavljevic Sept. 24, 2020, 1:52 p.m. UTC | #1 
Hi,

for Patch 14 in your attachment,

>-;; In practice, GIR users will need libffi when using
>-;; gobject-introspection.

Why was this comment removed?  Is it not true anymore?

>-    ; Some bits are distributed under the LGPL2+, others under the GPL2+

Why was this comment removed?  Is it now under GPL2+ entirely?

For patch 15, was zlib always unnecessary?
Or has upstream removed functionality?
Or do we remove functionality?

Otherwise looks good.

Heads-up to everyone: If this patchset is reviewed, it will go to MASTER, as
was discussed here in this thread.  Btw: It has over 6000 dependents.
Raghav Gururajan Sept. 24, 2020, 2:17 p.m. UTC | #2 
Hi Danny!

>> -;; In practice, GIR users will need libffi when using
>> -;; gobject-introspection.
> 
> Why was this comment removed?  Is it not true anymore?

The libffi is required to use gobject-introspection. I thought separate 
comment is not needed to say that something is a dependency or 
requirement, as it is trivial to presume so. :-)

>> -    ; Some bits are distributed under the LGPL2+, others under the GPL2+
> 
> Why was this comment removed?  Is it now under GPL2+ entirely?

The next patch updates the license field.

> For patch 15, was zlib always unnecessary?
> Or has upstream removed functionality?
> Or do we remove functionality?

Upstream removed zlib as a dependency.

> Otherwise looks good.

Thanks!

Regards,
RG.
diff mbox series

Patch

From 7e1d0b398fe428f5ce3fb62382d8261787c84029 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Thu, 24 Sep 2020 09:11:30 -0400
Subject: [PATCH 16/16] gnu: gobject-introspection: Update synopsis,
 description, home-page and license.

* gnu/packages/glib.scm (gobject-introspection) [synopsis]: Modify.
[description]: Modify.
[home-page]: Modify.
[license]: Modify.
---
 gnu/packages/glib.scm | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/glib.scm b/gnu/packages/glib.scm
index fa43bc06a8..23ef233bd6 100644
--- a/gnu/packages/glib.scm
+++ b/gnu/packages/glib.scm
@@ -363,15 +363,19 @@  threads, dynamic loading, and an object system.")
        (variable "GI_TYPELIB_PATH")
        (files '("lib/girepository-1.0")))))
     (search-paths native-search-paths)
-    (synopsis "Generate interface introspection data for GObject libraries")
-    (description
-     "GObject introspection is a middleware layer between C libraries (using
-GObject) and language bindings.  The C library can be scanned at compile time
-and generate a metadata file, in addition to the actual native C library.  Then
-at runtime, language bindings can read this metadata and automatically provide
-bindings to call into the C library.")
-    (home-page "https://wiki.gnome.org/GObjectIntrospection")
-    (license license:gpl2+)))
+    (synopsis "GObject introspection tools and libraries")
+    (description "GObject introspection is a middleware layer between
+C libraries (using GObject) and language bindings.  The C library can be scanned
+at compile time and generate metadata files, in addition to the actual native
+C library.  Then language bindings can read this metadata and automatically
+provide bindings to call into the C library.")
+    (home-page "https://wiki.gnome.org/Projects/GObjectIntrospection")
+    (license
+     (list
+      ;; For library.
+      license:lgpl2.0+
+      ;; For tools.
+      license:gpl2+))))
 
 (define intltool
   (package
-- 
2.28.0