diff mbox series

[bug#53495] gnu: FreeCAD: Replace QtWebKit with QtWebEngine.

Message ID 992f75d634f695896c1a0695fe53a902cb2a2e2f.1643011560.git.leo@famulari.name
State Accepted
Headers show
Series [bug#53495] gnu: FreeCAD: Replace QtWebKit with QtWebEngine. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job
cbaines/issue success View issue

Commit Message

Leo Famulari Jan. 24, 2022, 8:06 a.m. UTC 
See <https://issues.guix.gnu.org/53289> for more information about this change.

* gnu/packages/engineering.scm (freecad)[inputs]: Remove QTWEBKIT. Add
QTDECLARATIVE, QTWEBCHANNEL, and QTWEBENGINE.
---
 gnu/packages/engineering.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Guillaume Le Vaillant Jan. 25, 2022, 10:40 a.m. UTC | #1 
Leo Famulari <leo@famulari.name> skribis:

> See <https://issues.guix.gnu.org/53289> for more information about this change.
>
> * gnu/packages/engineering.scm (freecad)[inputs]: Remove QTWEBKIT. Add
> QTDECLARATIVE, QTWEBCHANNEL, and QTWEBENGINE.
> ---
>  gnu/packages/engineering.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
> index f4c5d73e00..23133a50eb 100644
> --- a/gnu/packages/engineering.scm
> +++ b/gnu/packages/engineering.scm
> @@ -2483,8 +2483,10 @@ (define-public freecad
>             python-shiboken-2
>             python-wrapper
>             qtbase-5
> +           qtdeclarative
>             qtsvg
> -           qtwebkit
> +           qtwebchannel
> +           qtwebengine
>             qtx11extras
>             qtxmlpatterns
>             sqlite

LGTM
Leo Famulari Jan. 25, 2022, 6:39 p.m. UTC | #2 
On Tue, Jan 25, 2022 at 10:40:34AM +0000, Guillaume Le Vaillant wrote:
> LGTM

Thanks for the review! Pushed as
676de0a34c7fab3c12e36e0d8349db6ee8da65da
diff mbox series

Patch

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index f4c5d73e00..23133a50eb 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -2483,8 +2483,10 @@  (define-public freecad
            python-shiboken-2
            python-wrapper
            qtbase-5
+           qtdeclarative
            qtsvg
-           qtwebkit
+           qtwebchannel
+           qtwebengine
            qtx11extras
            qtxmlpatterns
            sqlite