diff mbox series

[bug#62298,v2,4/8] services: mympd: Require 'syslog service when configured to log to syslog.

Message ID 96e6404d84211c766924d2fcd4f88d33c11cacfe.1679583701.git.mirai@makinata.eu
State New
Headers show
Series [bug#62298,v2,1/8] services: configuration: Add user-defined sanitizer support. | expand

Commit Message

Bruno Victal March 23, 2023, 3:02 p.m. UTC 
* gnu/services/audio.scm (mympd-shepherd-service): Depend on 'syslog when
configured to log to syslog.
---
 gnu/services/audio.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Maxim Cournoyer March 24, 2023, 2:32 p.m. UTC | #1 
Hi,

Bruno Victal <mirai@makinata.eu> writes:

> * gnu/services/audio.scm (mympd-shepherd-service): Depend on 'syslog when
> configured to log to syslog.
> ---
>  gnu/services/audio.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm
> index e9ecccd614..e5b065a479 100644
> --- a/gnu/services/audio.scm
> +++ b/gnu/services/audio.scm
> @@ -749,7 +749,9 @@ (define (mympd-shepherd-service config)
>      (let ((log-level* (format #f "MYMPD_LOGLEVEL=~a" log-level)))
>        (shepherd-service
>         (documentation "Run the myMPD daemon.")
> -       (requirement `(loopback user-processes ,@shepherd-requirement))
> +       (requirement `(loopback user-processes
> +                               ,@(if (eqv? log-to 'syslog) '(syslog) '())

eq? is sufficient to compare symbols.  Otherwise, LGTM.
diff mbox series

Patch

diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm
index e9ecccd614..e5b065a479 100644
--- a/gnu/services/audio.scm
+++ b/gnu/services/audio.scm
@@ -749,7 +749,9 @@  (define (mympd-shepherd-service config)
     (let ((log-level* (format #f "MYMPD_LOGLEVEL=~a" log-level)))
       (shepherd-service
        (documentation "Run the myMPD daemon.")
-       (requirement `(loopback user-processes ,@shepherd-requirement))
+       (requirement `(loopback user-processes
+                               ,@(if (eqv? log-to 'syslog) '(syslog) '())
+                               ,@shepherd-requirement))
        (provision '(mympd))
        (start #~(begin
                   (let* ((pw (getpwnam #$user))