From patchwork Sun Nov 11 14:23:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: guy fleury iteriteka X-Patchwork-Id: 169 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id C8055167F3; Sun, 11 Nov 2018 14:24:17 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) by mira.cbaines.net (Postfix) with ESMTPS id 15B49167F1 for ; Sun, 11 Nov 2018 14:24:14 +0000 (GMT) Received: from localhost ([::1]:42374 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gLqeq-0001y3-SL for patchwork@mira.cbaines.net; Sun, 11 Nov 2018 09:24:12 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57640) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gLqel-0001xw-G3 for guix-patches@gnu.org; Sun, 11 Nov 2018 09:24:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gLqeg-0007V1-Gq for guix-patches@gnu.org; Sun, 11 Nov 2018 09:24:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:41161) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gLqeg-0007Uf-CJ for guix-patches@gnu.org; Sun, 11 Nov 2018 09:24:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gLqeg-0007Y4-5G for guix-patches@gnu.org; Sun, 11 Nov 2018 09:24:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#33334] [PATCH]:gnu:add ne:the nice editor Resent-From: guy fleury Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 11 Nov 2018 14:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33334 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: swedebugia Received: via spool by submit@debbugs.gnu.org id=B.154194623629004 (code B ref -1); Sun, 11 Nov 2018 14:24:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Nov 2018 14:23:56 +0000 Received: from localhost ([127.0.0.1]:45419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLqeZ-0007Xj-Rq for submit@debbugs.gnu.org; Sun, 11 Nov 2018 09:23:56 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47935) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLqeY-0007XV-5H for submit@debbugs.gnu.org; Sun, 11 Nov 2018 09:23:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gLqeS-0007LK-3h for submit@debbugs.gnu.org; Sun, 11 Nov 2018 09:23:49 -0500 Received: from lists.gnu.org ([2001:4830:134:3::11]:53120) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gLqeR-0007LC-N7 for submit@debbugs.gnu.org; Sun, 11 Nov 2018 09:23:48 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gLqeQ-0001vi-LV for Guix-patches@gnu.org; Sun, 11 Nov 2018 09:23:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gLqeL-0007HM-NP for Guix-patches@gnu.org; Sun, 11 Nov 2018 09:23:46 -0500 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:37336) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gLqeJ-0007Dp-Gp for Guix-patches@gnu.org; Sun, 11 Nov 2018 09:23:40 -0500 Received: by mail-wr1-x42f.google.com with SMTP id o15-v6so6554829wrv.4 for ; Sun, 11 Nov 2018 06:23:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version; bh=IPrBzGMRuZbLEgVtx9QmrS/HTt7v7BKRTYqZbbvVnq8=; b=HFeOfc2cIKGxBn39oL8XOjudeB3ILeotVdT8dhzVlt+dqPoS30TldSKGm6ZJPlxcds y6mCOxoTuCdkmRs1+4pX21PWXZ8U9uXrv9QNLskcqj466CqSRDsAFSPPPKiiHkKSBOK1 Vh83aU4QLZ2B4fSGznC4j7HLOv8/nBvFWXaggaL34pblSMAH2mWnB/n/bUpL/dkaTdVZ dCcz9nc5IxnNtae0ENOdio5JgZGXpXkr+povC9McuG0is60SZL4iaidDdJECnLVLHb2q isSLy+aUeXqDedkRqiCskG7XoSWqmO2/Kq00iOBgCiju+JBOpin4hwdzioL3W+cTALf/ Bacw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version; bh=IPrBzGMRuZbLEgVtx9QmrS/HTt7v7BKRTYqZbbvVnq8=; b=MBdmgSAwmj5zTlNkNWWhGo70IbsNYNPAfoJQUv/FbojcMJDO/IycpWPz1VWMIjSNyZ FFONvKpvJ0Fc6J2rcv+R7dzwka67XMSOUiH18In4NQunfpGkTRK0lKWEqVG+JT3lxqf7 NVf6nJGKbLigD2nQpcAtspq+T9TujX+p0jQpqJri7dDCbCp0MeFSE3MRoHYFh+KhlpGS rAC55cKyOvndU/0WcrwrcbA+FAPMR7EMgQ7/X60YSR8nRUyTlxc2IL3m+jf128n3OWBY V4tYqVsWJ8AFcEEXaGe84FD4f4jtfRekqTpDwkWbHV/aKumafCj9o8ySsf02xiqGRRxk KWmA== X-Gm-Message-State: AGRZ1gJ7CpQs7Xb8rWJEr0LkUGOBi2A2SxYC6NyELbu7s9R7884vuzIF 59Vc9g0BO1vdhtrWxxiy2KQ= X-Google-Smtp-Source: AJdET5dA34Au3JMZrgPzYC61+ydrWQqx/StnB5W14ZvfB6Omwo3A7kHFcW20adAPSAdbZCC96nSq6g== X-Received: by 2002:a05:6000:1009:: with SMTP id a9mr14233928wrx.271.1541946215800; Sun, 11 Nov 2018 06:23:35 -0800 (PST) Received: from debian ([154.73.106.233]) by smtp.gmail.com with ESMTPSA id y9-v6sm11912029wru.70.2018.11.11.06.23.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 11 Nov 2018 06:23:35 -0800 (PST) Message-ID: <92c80aefcd1dd8a6ddf25c1db4606b368bc37e17.camel@gmail.com> From: guy fleury Date: Sun, 11 Nov 2018 16:23:23 +0200 In-Reply-To: <3d289608-6488-bd1f-befb-a5ec7fd9cb1e@riseup.net> References: <3d289608-6488-bd1f-befb-a5ec7fd9cb1e@riseup.net> User-Agent: Evolution 3.30.1-1 Mime-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Guix-patches@gnu.org Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Le samedi 10 novembre 2018 à 22:20 +0100, swedebugia a écrit : > Hi :) > Did you run ./pre-inst-env guix lint on the package? > It has trailing whitespaces in two places. ------------------------------------------------------ ./pre-inst-env guix lint ne gnu/packages/nano.scm:85:7: ne@3.1.2: sentences in description should be followed by two spaces; possible infraction at 78 accepted connection from pid 16902, user guy gnu/packages/nano.scm:83:14: ne@3.1.2: synopsis should start with an upper-case letter or digit gnu/packages/nano.scm:83:14: ne@3.1.2: synopsis should not start with the package name guix lint: warning: while retrieving CVE vulnerabilities: TLS certificate error: X.509 certificate of 'nvd.nist.gov' could not be verified: signer-not-found invalid gnu/packages/nano.scm:56:2: ne@3.1.2: trailing white space on line 80 gnu/packages/nano.scm:56:2: ne@3.1.2: trailing white space on line 85 gnu/packages/nano.scm:56:2: ne@3.1.2: trailing white space on line 86 gnu/packages/nano.scm:56:2: ne@3.1.2: trailing white space on line 87 ----------------------------------------------------------------------- i failed to indent well.Perphaps you can do it.it compiles quickly. yes i know,i got soon learn to indent. > On 2018-11-10 10:25, guy fleury wrote: > > hi all, > > > > i have packaged: ne "the nice editor". > > it is my first tempt to contribute to any project,if i do things > > wrong > > tell me with additionnal informations! > > Thank you! Me too. I submitted my first patch ever to Guix a few > days > ago. :) > > > 0001-gnu-add-ne-the-nice-editor.patch > > > > From 1ec45eaa225e7203a98b36cddb7d42db418b773b Mon Sep 17 00:00:00 > > 2001 > > From: guy fleury > > Date: Sat, 10 Nov 2018 10:51:17 +0200 > > Subject: [PATCH] gnu:add ne:the nice editor > > snip > > > + (build-system gnu-build-system) > > + (arguments > > + `(#:tests? #f > > Could you please explain why the tests are disabled? > Search the packages to see examples of explanations. > > > + #:make-flags (list (string-append "PREFIX=" (assoc-ref > > %outputs "out")) > > + "CC=gcc") > > + #:parallel-build? #f > > + #:phases (modify-phases %standard-phases > > + (delete 'configure)))) > > Same here. Please explain. > > Tested the compilation and ran the editor. Seemed nice! > > Maybe this could complement nano if it highlights scheme and has a > macro > to help with e.g. finding missing parens. i did that. it not supports highlights scheme but show missing parens. it supports also highlights in other languages(such c,c++,etc) > Could you send an updated patch? yes,here is my patch updated. From 5cbedbd432a7dc97d6474fc7291f9da5adfe8f47 Mon Sep 17 00:00:00 2001 From: guy fleury Date: Sun, 11 Nov 2018 14:51:11 +0200 Subject: [PATCH] gnu:Add ne:A nice editor --- gnu/packages/nano.scm | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/gnu/packages/nano.scm b/gnu/packages/nano.scm index 8f96b605a..dafdf6537 100644 --- a/gnu/packages/nano.scm +++ b/gnu/packages/nano.scm @@ -51,3 +51,39 @@ basic editing, it supports: undo/redo, syntax highlighting, spell checking, justifying, auto-indentation, bracket matching, interactive search-and-replace (with regular expressions), and the editing of multiple files.") (license gpl3+))) ; some files are under GPLv2+ + +(define-public ne + (package + (name "ne") + (version "3.1.2") + (source (origin + (method url-fetch) + (uri (string-append "http://ne.di.unimi.it/ne-" version + ".tar.gz")) + (sha256 + (base32 + "06qk3cqxyn098i1yn686bigpgh8vrrnj0qpkrgs6zwnq42s1y0d2")) + (modules '((guix build utils))) + (snippet + ;; use lncurses instead of lcurses + '(begin + (substitute* "src/makefile" + (("-lcurses") + "-lncurses")) + #t)))) + (build-system gnu-build-system) + (arguments + `(#:tests? #f ;; no test suite avaliable + #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out")) + "CC=gcc") + ;;we don't need configure + #:phases (modify-phases %standard-phases (delete 'configure)))) + (inputs + `(("ncurses" ,ncurses))) + (synopsis "ne, A nice editor") + (description + "ne is fast,small,powerful and simple text editor that can be fully +configured. It has a simple scripting language where scripts can be easily +generated and played") + (home-page "http://ne.di.unimi.it/ne") + (license gpl3+))) -- 2.19.0