diff mbox series

[bug#55703] Update minetest

Message ID 88c65d08cae0393ec661df673bd0e815a10df7b1.camel@planete-kraus.eu
State Accepted
Headers show
Series [bug#55703] Update minetest | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue

Commit Message

Vivien Kraus May 29, 2022, 12:47 p.m. UTC
Dear guix,

minetest 5.5.1 has been released some time ago. Most notably, it
provides its own fork of irrlicht. Both minetest and irrlichtmt evolve
together, in the sense that upgrading irrlichtmt without upgrading
minetest breaks the latter.

I have also updated a set of mods I use.

Best regards,

Vivien

Comments

Liliana Marie Prikler May 29, 2022, 1:48 p.m. UTC | #1
Hi,

Am Sonntag, dem 29.05.2022 um 14:47 +0200 schrieb Vivien Kraus:
> Subject: [PATCH v1 1/8] gnu: minetest: Update to 5.5.1.
> 
> * gnu/local.mk (dist_patch_DATA): Remove minetest-add-
> MINETEST_MOD_PATH.patch.
> * gnu/packages/patches/minetest-add-MINETEST_MOD_PATH.patch: Delete
> it.
> * gnu/packages/minetest.scm (irrlichtmt): New variable.
> (minetest): Update to 5.5.1.
> [patches]: Remove patch.
> [configure-flags]: find irrlichtmt and zstd.
> [inputs]: Replace irrlicht with irrlichtmt, add zstd.
> (minetest-data): Update hash.
I'd name "irrlichtmt" to "irrlicht-for-minetest" and perhaps split this
patch into two.  Even if they need to be bumped "at once" later, I
don't think this holds for the initial introduction.

> * gnu/packages/minetest.scm (minetest-basic-materials): Update to
> 2022-03-28 (commet 9d55f991…).
> [snippet]: Make sound_api_core a dependency, not a submodule.
Again doing two things at once.  I think it'd be wiser to first do the
updates, then add minetest-sound-core, then add the snippets.  WDYT?

> * gnu/packages/minetest.scm (minetest-homedecor-modpack): Update to
> 2022-05-18 (commit ID from may 17).
LGTM¹

> * gnu/packages/minetest.scm (minetest-mesecons): Update to 2022-04-01
> (use github tag).
LGTM²

> * gnu/packages/minetest.scm (minetest-mineclone): Update to 0.75.0.
LGTM¹

> * gnu/packages/minetest.scm (minetest-technic): Update to 2022-02-06.
LGTM¹

> * gnu/packages/minetest.scm (minetest-advtrains): Update to 2.4.1.
LGTM¹

Cheers

¹ I did not check for hash mismatches or ContenDB version equivalence.
² As pointed out by Maxime elsewhere in the mailing list, Minetest
packages usually have flaky tags in their forges, so someone needs to
look closer at whether this is going to break in the future.

Putting Maxime onto CC to resolve these footnotes :)
M May 29, 2022, 5:49 p.m. UTC | #2
Liliana Marie Prikler schreef op zo 29-05-2022 om 15:48 [+0200]:
> ¹ I did not check for hash mismatches or ContenDB version equivalence.

A linter that for each Minetest package looks at ContentDB for the
commit and verifies the commit on ContentDB and the commit in git-
reference would be nice.  Future work ...

Greetings,
Maxime.
diff mbox series

Patch

From e36f425bda3e6ff62d13f087812e1d5c09281ef1 Mon Sep 17 00:00:00 2001
From: Vivien Kraus <vivien@planete-kraus.eu>
Date: Sun, 29 May 2022 14:43:28 +0200
Subject: [PATCH v1 8/8] gnu: minetest-advtrains: Update to 2.4.1.

* gnu/packages/minetest.scm (minetest-advtrains): Update to 2.4.1.
---
 gnu/packages/minetest.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/minetest.scm b/gnu/packages/minetest.scm
index 655d49c0f7..5545dcc751 100644
--- a/gnu/packages/minetest.scm
+++ b/gnu/packages/minetest.scm
@@ -719,7 +719,7 @@  (define-public minetest-unified-inventory
 (define-public minetest-advtrains
   (package
     (name "minetest-advtrains")
-    (version "2.3.1")
+    (version "2.4.1")
     (source
      (origin
        (method git-fetch)
@@ -727,7 +727,7 @@  (define-public minetest-advtrains
              (url "https://git.bananach.space/advtrains.git")
              (commit (string-append "release-" version))))
        (sha256
-        (base32 "1ijqlchh269jpvmgmdmdvy3nsnk0bszkvvcqk6vaysvxam695ggw"))
+        (base32 "1q2jj8181pjgsakl28xadv0z4sszq1lb5rpgj070wr0px6mp447p"))
        (file-name (git-file-name name version))))
     (build-system minetest-mod-build-system)
     (home-page "http://advtrains.de/")
-- 
2.36.1