From patchwork Mon Dec 9 14:30:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Patchwork-Id: 16449 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 25EA41782A; Mon, 9 Dec 2019 14:31:11 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id CDB19177E5 for ; Mon, 9 Dec 2019 14:31:10 +0000 (GMT) Received: from localhost ([::1]:40784 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ieK46-0008Fp-75 for patchwork@mira.cbaines.net; Mon, 09 Dec 2019 09:31:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39195) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ieK3z-0008FM-GI for guix-patches@gnu.org; Mon, 09 Dec 2019 09:31:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ieK3y-0003wU-7o for guix-patches@gnu.org; Mon, 09 Dec 2019 09:31:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46856) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ieK3x-0003wC-Nv for guix-patches@gnu.org; Mon, 09 Dec 2019 09:31:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ieK3x-0004Ca-K1 for guix-patches@gnu.org; Mon, 09 Dec 2019 09:31:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#38436] [PATCH] gnu: Add gfortran-toolchain Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 09 Dec 2019 14:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Konrad Hinsen Cc: 38436@debbugs.gnu.org Received: via spool by 38436-submit@debbugs.gnu.org id=B38436.157590184916128 (code B ref 38436); Mon, 09 Dec 2019 14:31:01 +0000 Received: (at 38436) by debbugs.gnu.org; 9 Dec 2019 14:30:49 +0000 Received: from localhost ([127.0.0.1]:52829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ieK3k-0004C3-ND for submit@debbugs.gnu.org; Mon, 09 Dec 2019 09:30:49 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58263) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ieK3i-0004Bm-Hw for 38436@debbugs.gnu.org; Mon, 09 Dec 2019 09:30:47 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33787) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ieK3d-0003fG-Bp; Mon, 09 Dec 2019 09:30:41 -0500 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=52312 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ieK3c-0005nw-LU; Mon, 09 Dec 2019 09:30:41 -0500 From: Ludovic =?utf-8?q?Court=C3=A8s?= References: Date: Mon, 09 Dec 2019 15:30:38 +0100 In-Reply-To: (Konrad Hinsen's message of "Mon, 02 Dec 2019 16:01:19 +0100") Message-ID: <87zhg1efld.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi Konrad, Konrad Hinsen skribis: > * gnu/packages/commencement.scm: (gfortran-toolchain): New variable. > * gnu/packages/commencement.scm: (make-gcc-toolchain): Added argument "language" This LGTM, though I’d have a minor request: > - (synopsis "Complete GCC tool chain for C/C++ development") > + (synopsis (format #f > + "Complete GCC tool chain for ~a development" > + language)) > (description > - "This package provides a complete GCC tool chain for C/C++ development to > -be installed in user profiles. This includes GCC, as well as libc (headers > -an d binaries, plus debugging symbols in the @code{debug} output), and Binutils.") > + (format > + #f > + "This package provides a complete GCC tool chain for ~a development to > +be installed in user profiles. This includes GCC, as well as libc (headers > +and binaries, plus debugging symbols in the @code{debug} output), and Binutils." > + language)) There’s this weird requirement that for the sake of i18n, we must not construct synopses/descriptions like this: https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html I’d suggest something as shown below. Could you update the patch along those lines? Thanks, Ludo’. diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm index 68030376fc..00de771bc4 100644 --- a/gnu/packages/commencement.scm +++ b/gnu/packages/commencement.scm @@ -2523,8 +2523,12 @@ COREUTILS-FINAL vs. COREUTILS, etc." ;; (define-public gcc-glibc-2.27-toolchain ;; (make-gcc-toolchain gcc glibc-2.27)) -(define* (make-gcc-toolchain gcc +(define* (make-gcc-toolchain language gcc #:optional + ;; Note: Keep the synopsis literal string here so + ;; that xgettext "sees" it. + (synopsis + "Complete GCC tool chain for C/C++ development") (libc #f)) "Return a complete toolchain for GCC. If LIBC is specified, target that libc." (let ((gcc (if libc (make-gcc-libc gcc libc) gcc)) @@ -2559,7 +2563,7 @@ COREUTILS-FINAL vs. COREUTILS, etc." (search-paths (package-search-paths gcc)) (license (package-license gcc)) - (synopsis "Complete GCC tool chain for C/C++ development") + (synopsis synopsis) (description "This package provides a complete GCC tool chain for C/C++ development to be installed in user profiles. This includes GCC, as well as libc (headers