From patchwork Sat Jan 21 22:20:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sergiu Ivanov X-Patchwork-Id: 46325 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 5046027BBED; Sat, 21 Jan 2023 22:29:21 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 7A79E27BBEB for ; Sat, 21 Jan 2023 22:29:18 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJMMD-0005EE-7x; Sat, 21 Jan 2023 17:29:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJMMB-0005E5-0F for guix-patches@gnu.org; Sat, 21 Jan 2023 17:29:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pJMMA-0008SW-Jv for guix-patches@gnu.org; Sat, 21 Jan 2023 17:29:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pJMM9-0005hO-Vk for guix-patches@gnu.org; Sat, 21 Jan 2023 17:29:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60840] [PATCH 0/3] gnu: volctl: Update to 0.9.3. Resent-From: Sergiu Ivanov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 21 Jan 2023 22:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60840 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 60840@debbugs.gnu.org Received: via spool by 60840-submit@debbugs.gnu.org id=B60840.167434013921896 (code B ref 60840); Sat, 21 Jan 2023 22:29:01 +0000 Received: (at 60840) by debbugs.gnu.org; 21 Jan 2023 22:28:59 +0000 Received: from localhost ([127.0.0.1]:50030 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJMM6-0005h6-Tj for submit@debbugs.gnu.org; Sat, 21 Jan 2023 17:28:59 -0500 Received: from marvid.fr ([163.172.81.107]:42446 helo=courriel.marvid.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJMM4-0005gr-E3 for 60840@debbugs.gnu.org; Sat, 21 Jan 2023 17:28:57 -0500 Received: from localhost (schwifty.marvid.fr [51.159.4.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by sahkopoika (Postfix) with ESMTPSA id F1AC37D0475B; Sat, 21 Jan 2023 23:28:48 +0100 (CET) References: <87k01na0gm.fsf@colimite.fr> <87o7qz8lev.fsf@colimite.fr> <875yd676zw.fsf_-_@gmail.com> User-agent: mu4e 1.8.13; emacs 28.2 From: Sergiu Ivanov Date: Sat, 21 Jan 2023 23:20:31 +0100 In-reply-to: <875yd676zw.fsf_-_@gmail.com> Message-ID: <87zgabfrof.fsf@colimite.fr> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Hi Maxim, Thank you very much for the review! And sorry for the delay: day job :D Maxim Cournoyer [2023-01-16T17:56:51+0100]: > Hi Sergiu, > > Sergiu Ivanov writes: > >>>From e0c69ddefe7367e4b4417db70c86eacbfc6e3eae Mon Sep 17 00:00:00 2001 >> From: Sergiu Ivanov >> Date: Sun, 4 Dec 2022 13:27:13 +0100 >> Subject: [PATCH 1/3] gnu: volctl: Make the synopsis line shorter. >> >> * gnu/packages/gtk.scm (volctl): Make the synopsis line shorter. > > I'd reword this as "Re-indent the synopsis line", or alternatively make > it really shorter, perhaps dropping the last "for graphical > applications" bit, which get repeated the description anyway. I chose the second option and made the synopsis shorter as you suggest. >> gnu/packages/gtk.scm | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm >> index de82b9e55f..c8ae855cfa 100644 >> --- a/gnu/packages/gtk.scm >> +++ b/gnu/packages/gtk.scm >> @@ -33,6 +33,7 @@ >> ;;; Copyright © 2022 Benjamin Slade >> ;;; Copyright © 2022 Denis 'GNUtoo' Carikli >> ;;; Copyright © 2022 Petr Hodina >> +;;; Copyright © 2022 Sergiu Ivanov > > When changes are not substantial (< 10 new additions/changes) they are > not protected by copyright, so you can drop the above hunk. Ah, good know! I dropped the hunk. - Sergiu From 7603972f4514eeac5ebd1dde119d35e8ea2adc4d Mon Sep 17 00:00:00 2001 From: Sergiu Ivanov Date: Mon, 16 Jan 2023 23:41:14 +0100 Subject: [PATCH 1/3] gnu: volctl: Make the synopsis line shorter. * gnu/packages/gtk.scm (volctl): Make the synopsis line shorter. --- gnu/packages/gtk.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm index de82b9e55f..ea22d0e930 100644 --- a/gnu/packages/gtk.scm +++ b/gnu/packages/gtk.scm @@ -2978,7 +2978,7 @@ (define-public volctl (propagated-inputs (list python-click python-pycairo python-pygobject python-pyyaml)) (home-page "https://buzz.github.io/volctl/") - (synopsis "Per-application volume control and on-screen display for graphical desktops") + (synopsis "Per-application volume control and on-screen display") (description "Volctl is a PulseAudio-enabled tray icon volume control and OSD applet for graphical desktops. It's not meant to be an replacement for a full-featured mixer application. If you're looking for that check out the -- 2.38.1