From patchwork Wed Sep 25 05:16:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "pelzflorian (Florian Pelz)" X-Patchwork-Id: 31415 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 6FA3D27BBE2; Wed, 25 Sep 2024 06:18:05 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE,SPF_HELO_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 27AB727BBE9 for ; Wed, 25 Sep 2024 06:18:04 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stKPE-00061S-KD; Wed, 25 Sep 2024 01:17:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stKPC-00061C-6k for guix-patches@gnu.org; Wed, 25 Sep 2024 01:17:38 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1stKPB-0000ZO-So for guix-patches@gnu.org; Wed, 25 Sep 2024 01:17:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=JufbpX1nJqsjfRgpB7hc6O+e8RHqtPHeOQq944m7ZNk=; b=qhNdudr4BU/L5AlPm4jUTJa2cAEeUTzG6NJt5eUsvXqQx2P97g2fGVaUpJ3wgBudOaiXFoV4dy5RMU5jW7kIkfPU9m3aVHkoTjjttnhOugFCRU0Cp1TQLm/x3Sbwn4siB6HX1YRSqaGaOq9pgd0UJXlluLbaWrIboTUzs+IMb8eHUP7Vy92zb2DX8M4/1yikN5lAa19UG3/yRYjhs0yjDF0d3l2bO9gKsqNmTl8zXPLiD5uYMfxuG6iIayq2e+1GuogjoRrpndxLMAble4SGkz+jrQH1dYDMIvG47Vv+15XqjVLXCLW5av5ATjGtjO1sxcWxc/Qp/+iN9OdY0ft0AQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1stKPa-0002LU-LJ for guix-patches@gnu.org; Wed, 25 Sep 2024 01:18:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72867] [PATCH v5] gexp: Make 'local-file' follow symlinks. Resent-From: "pelzflorian (Florian Pelz)" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 25 Sep 2024 05:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72867 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nigko Yerden Cc: Ludovic =?utf-8?q?Court=C3=A8s?= , Tobias Geerinckx-Rice , 72867@debbugs.gnu.org, Attila Lendvai Received: via spool by 72867-submit@debbugs.gnu.org id=B72867.17272414428949 (code B ref 72867); Wed, 25 Sep 2024 05:18:02 +0000 Received: (at 72867) by debbugs.gnu.org; 25 Sep 2024 05:17:22 +0000 Received: from localhost ([127.0.0.1]:42765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stKOv-0002KG-OQ for submit@debbugs.gnu.org; Wed, 25 Sep 2024 01:17:22 -0400 Received: from relay.yourmailgateway.de ([188.68.63.166]:35329) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stKOs-0002K5-2K for 72867@debbugs.gnu.org; Wed, 25 Sep 2024 01:17:19 -0400 Received: from mors-relay-8202.netcup.net (localhost [127.0.0.1]) by mors-relay-8202.netcup.net (Postfix) with ESMTPS id 4XD4Vz6FcFz3tWf; Wed, 25 Sep 2024 07:08:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=pelzflorian.de; s=key2; t=1727240891; bh=6XyflFZlmm4zDOqg1ojI0dqrSSK2/CNi9gl8kuXa+Fg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=SRBnfuR+KNfOSOQz7eVMvSrQZbsDTCWW9JBMmrgM4DeYFWvrEmIXO0J+Of//rSJYH sJhfzIF8EK6JiEJYyLObIfbgGhnLWuP7cg4N99wsZRDt2/tnVFsRLNsU2jQsvYGsBk QWDUue1II19i/FFjB198sYAxxp2ahHX4vdUIc4+kHrezbuw237dioh0FQ8V476VZjR l9DLHBQVQvI9mHpnQBuRoJ2n6PGPZbWl4soQ1oRdf8LJiwVKCeERX8Qp/HMJh9aIhA qTl5aZK0Qfnh1o6+7PLNEeIOWirGKtsEfRpquaUWRx5I+CrVt2fwFtOuUSWhUyMEqA yKGOBXUiEILcQ== Received: from policy01-mors.netcup.net (unknown [46.38.225.35]) by mors-relay-8202.netcup.net (Postfix) with ESMTPS id 4XD4Vz5XLkz3tPM; Wed, 25 Sep 2024 07:08:11 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at policy01-mors.netcup.net Received: from mxe217.netcup.net (unknown [10.243.12.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by policy01-mors.netcup.net (Postfix) with ESMTPS id 4XD4hy2LGMz8t43; Wed, 25 Sep 2024 07:16:49 +0200 (CEST) Received: from florianhp (ipb2186896.dynamic.kabel-deutschland.de [178.24.104.150]) by mxe217.netcup.net (Postfix) with ESMTPSA id 1437D83C3E; Wed, 25 Sep 2024 07:16:41 +0200 (CEST) From: "pelzflorian (Florian Pelz)" In-Reply-To: <87r09vsyp1.fsf@pelzflorian.de> (pelzflorian@pelzflorian.de's message of "Sat, 07 Sep 2024 09:35:54 +0200") References: <6e87ddd086b9188539eecfc83bdd6712aaf53a1a.1725596262.git.nigko.yerden@gmail.com> <87r09vsyp1.fsf@pelzflorian.de> Date: Wed, 25 Sep 2024 07:16:45 +0200 Message-ID: <87zfnws476.fsf@pelzflorian.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Rspamd-Queue-Id: 1437D83C3E X-Rspamd-Server: rspamd-worker-8404 X-NC-CID: WlwxBALa+/YHptFhdod1O9RUObqzJTOGToB4t+rAUbPH9PHuMg8KvpRE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Hello Nigko. They would not have to write code like `current-source-directory'. Also note that such affected users had broken code when running the real file. `local-file' with absolute paths always did `(canonicalize-path (dirname` and does not change. `dirname' being called in a special case of `current-source-directory', `canonicalize-path' as part of `absolute-file-name'. Could we finish this bug report by applying your nice test code, but changing only `absolute-dirname' to do (canonicalize-path (dirname)) in all cases? Then either add no news item, or write the above? Regards, Florian diff --git a/etc/news.scm b/etc/news.scm index a90f92a9ff..5a32eee7f5 100644 --- a/etc/news.scm +++ b/etc/news.scm @@ -33,6 +33,18 @@ (channel-news (version 0) + (entry (commit "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx") + (title + (en "local-file behaves consistently for symlinks")) + (body + (en "Previous behavior differed between whether someone +loaded the symlink or the actual scheme file. One of them had to be +broken, at least when loading a channel module. + +Affected users who expected paths relative to the symlink would need +to append "/../.." or similar or the relative path to the “real” file +the symlink points to to the path."))) + (entry (commit "2fae63df2138b74d30e120364f0f272871595862") (title (en "Core packages updated")