diff mbox series

[bug#36273] Clarify spdlog's license

Message ID 87y31zpo5g.fsf@riseup.net
State Accepted
Headers show
Series [bug#36273] Clarify spdlog's license | expand

Checks

Context Check Description
cbaines/applying patch fail Apply failed

Commit Message

Meiyo Peng June 18, 2019, 3:28 a.m. UTC 
Hi Gábor,

The spdlog package contains a bundled fmt library.  I tried to unbundle
fmt before, but the maintaining work does not worth it.  This patch
clarify it's license.

I notice you pushed several Sway related packages into the master
branch, but none of them has been submitted to the mailing list.  Would
you please send you patches to the mailing list first in the future?

You also pushed mako into master, but there is already a discussion
about mako here:
https://lists.gnu.org/archive/html/guix-patches/2019-03/msg00567.html.
We should build mako from it's git master or wait until the next point
release.


--
Meiyo Peng
https://www.pengmeiyu.com/

Comments

Gábor Boskovits June 19, 2019, 8:05 a.m. UTC | #1 
Hello Meiyo!

Meiyo Peng <meiyo@riseup.net> ezt írta (időpont: 2019. jún. 18., Ke 5:29):

> Hi Gábor,
>
> The spdlog package contains a bundled fmt library.  I tried to unbundle
> fmt before, but the maintaining work does not worth it.  This patch
> clarify it's license.


> I notice you pushed several Sway related packages into the master
> branch, but none of them has been submitted to the mailing list.  Would
> you please send you patches to the mailing list first in the future?
>
Yes, of course. I just read on the hacking file that adding a package can
go directly to master, therefore the confusion.

>
> You also pushed mako into master, but there is already a discussion
> about mako here:
> https://lists.gnu.org/archive/html/guix-patches/2019-03/msg00567.html.
> We should build mako from it's git master or wait until the next point
> release.
>
Sorry about nor being aware. I should have been more careful.



>
> --
> Meiyo Peng
> https://www.pengmeiyu.com/

Best regard,
g_bor

>
>
Gábor Boskovits June 20, 2019, 3:44 a.m. UTC | #2 
Fixed on master in commit 5543d3bb09e65107afe4f839c97285bb2106b70e
<http://git.savannah.gnu.org/cgit/guix.git/commit/?id=5543d3bb09e65107afe4f839c97285bb2106b70e>
.
diff mbox series

Patch

From 8e3714e847e62e8bec86f2f90cf6e12399280391 Mon Sep 17 00:00:00 2001
From: Meiyo Peng <meiyo@riseup.net>
Date: Tue, 18 Jun 2019 11:07:50 +0800
Subject: [PATCH] gnu: spdlog: Clarify license.

* gnu/packages/logging.scm (spdlog): Clarify license of the bundled fmt
  library.
---
 gnu/packages/logging.scm | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/logging.scm b/gnu/packages/logging.scm
index e936733136..24a47567d0 100644
--- a/gnu/packages/logging.scm
+++ b/gnu/packages/logging.scm
@@ -5,6 +5,7 @@ 
 ;;; Copyright © 2017 Eric Bavier <bavier@member.fsf.org>
 ;;; Copyright © 2018 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2019 Gábor Boskovits <boskovits@gmail.com>
+;;; Copyright © 2019 Meiyo Peng <meiyo@riseup.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -205,5 +206,8 @@  windows in a terminal, colorize, filter and merge.")
        (list "-DSPDLOG_BUILD_BENCH=OFF")))
     (home-page "https://github.com/gabime/spdlog")
     (synopsis "Fast C++ logging library")
-    (description "Spdlog is a very fast header-only/compiled C++ logging library.")
-    (license license:expat))) ; MIT license
+    (description "Spdlog is a very fast header-only/compiled C++ logging
+library.")
+    ;; spdlog is under Expat license, but the bundled fmt library in
+    ;; "include/spdlog/fmt/bundled" is under BSD 2 clause license.
+    (license (list license:expat license:bsd-2))))
-- 
2.22.0