From patchwork Wed Mar 10 09:25:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre Langlois X-Patchwork-Id: 27595 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 2C01E27BC51; Wed, 10 Mar 2021 09:26:10 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 9E6EE27BC50 for ; Wed, 10 Mar 2021 09:26:09 +0000 (GMT) Received: from localhost ([::1]:43892 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJv6W-0006x9-QZ for patchwork@mira.cbaines.net; Wed, 10 Mar 2021 04:26:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51924) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJv6Q-0006x3-Vi for guix-patches@gnu.org; Wed, 10 Mar 2021 04:26:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37235) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJv6Q-0004jb-O7 for guix-patches@gnu.org; Wed, 10 Mar 2021 04:26:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lJv6Q-0004lH-L5 for guix-patches@gnu.org; Wed, 10 Mar 2021 04:26:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#47037] [PATCH] gnu: emacs-password-store: 2.1.4-1.918992c [security fix]. Resent-From: Pierre Langlois Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 10 Mar 2021 09:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 47037 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47037@debbugs.gnu.org X-Debbugs-Original-To: Guix-patches Received: via spool by submit@debbugs.gnu.org id=B.161536834618278 (code B ref -1); Wed, 10 Mar 2021 09:26:02 +0000 Received: (at submit) by debbugs.gnu.org; 10 Mar 2021 09:25:46 +0000 Received: from localhost ([127.0.0.1]:48781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJv6A-0004kk-FW for submit@debbugs.gnu.org; Wed, 10 Mar 2021 04:25:46 -0500 Received: from lists.gnu.org ([209.51.188.17]:45492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJv68-0004kc-CD for submit@debbugs.gnu.org; Wed, 10 Mar 2021 04:25:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51888) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJv68-0006ri-2D for guix-patches@gnu.org; Wed, 10 Mar 2021 04:25:44 -0500 Received: from mout.gmx.net ([212.227.15.19]:51963) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJv65-0004RZ-Q6 for guix-patches@gnu.org; Wed, 10 Mar 2021 04:25:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1615368338; bh=ymRK0oaWlxdUjBx9W/FN6YaplolqQnJ1RImibYxhuvQ=; h=X-UI-Sender-Class:From:To:Subject:Date; b=LUJKUCy9PCDE74H0ma1tKc4vU1OUPeL28bnqTNQb96ffD6kBYNTX3KLhdThSiNOAW TJc3OaxkCIq8VIlsKf9jjVhN7n6QEOM9N9tl+VLcobpUfE5Gc9OathTgkqQJ7sIPuq LSUYk3GIn49Q7rmIzpbGt67B5rOYVZmKjqKAah48= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from labiere ([82.69.64.142]) by mail.gmx.net (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MVeMA-1lCKPe04Dk-00RZXu for ; Wed, 10 Mar 2021 10:25:38 +0100 User-agent: mu4e 1.4.15; emacs 27.1 From: Pierre Langlois Date: Wed, 10 Mar 2021 09:25:36 +0000 Message-ID: <87y2ev5pin.fsf@gmx.com> MIME-Version: 1.0 X-Provags-ID: V03:K1:1fUxRs1GOaExIgpBTmTFACraVJQU4TVQVi7RgSgwWFr9zcPs++x 2HIB3tQjPuw+7IEnEq5JlUXAyrhTfynrh6t7uhNEhogiYwpJO1kL/n/jeyt2XzSEP/1wi+c E/mTHlf8KeaCOy/5wdKtKTNC+IB0R3LyB6sbSNkIO23HFLuRMTdwV63wPD/yN2vw/8LhK96 obUyfMeBiQFPfx8GSAKJQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:yf2i7LUUJBU=:B5h6IpcI6k68v0OMR4ogsM PdfkzAsgzCD+tE+D4bZT7ogStxZrFRdjI6N8aXaabFoPgvZPAche5doZ1vzx37fLYO+hNeuf4 3PiAcTGMtJr19XuNbqi0j//YtQKdEZq+17xHrleZAP6qf8z7yN6FYFYRmCjp4zrNA5Obppz+q idMxxAlnE7aGD8N6dyKEP43mjeqnVkoMqCK+aaAm1y/eJ8YmgGmuSAvasu5aeoYQVcfkA9Cfs YlRzD9wYQttpujNGvW+oLxm3osRqcTzoRt3OH1b1VAmL2kLnedzbNRTigJSUkXjH/+vIoNXRQ f95vTSQIdkQxi7EhVFOoOLkwhUB7QMDiffqz8pdfD74dgMnnOsbJ6ARq9tAco+aL5YDHu+Cda wycdJ1peMeQaB1I+0Mesc8tR6AS30otRuBi1v2gZfvjbzFWhVcTTYjNJyFPK6BOPF1Q0QcL0Q kSEvvRpw7v3HZGVUr2bVhcx7pasbT863teiBUkzhOuFyGCpfm8+/HZE03a3BnBKnaPISwwEQl 1UXklAT0Emus67a4/TSLEr5JP1yOkxGv4jL/MN2aRZ0dq/IR507kOCxBR4QooR102De9ZerV6 c2cVlU8K+C9Icc0BrFOS7xPcWlkcxTUXtglbJ5Fy2Ij7ovpiG1GFuOZ31IFbY/VdB00r5FbIL hhLZtXGwnNBpvZgNdm5Lb8RiseWs+MaJWS3kfqVk+CloaQuIk3JOJlPtSnSbxbPzTY2Lmk7M+ dyw0pRezr3pbFRsSq3jbNYJ0p3MawxfTWW6tG7nEDe7mwhWUZ9YQukKbXUoyK+xrWf/DakG4E I9eoawZ4CMukKdWJBytgi9Y+KTOEm+Jc872n/9gdAKfOLmjqEZcvA+O6h0nJdS14kNm362TBM XFQ4aOmD6rzxxTearMRg== Received-SPF: pass client-ip=212.227.15.19; envelope-from=pierre.langlois@gmx.com; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi guix! I noticed the update to the password-store yesterday and so got curious what changes we had and took a look at the git repository. I was really happy to find the emacs package includes a fix [0] for a bug I've been experiencing for a long time, where using pass inside EXWM would deadlock emacs. Taking a closer look as well, the commit also fixes a potentially quite critical security issue with the package, I think we better apply it :-/. Is this OK to commit? I've tested this locally on EXWM via ivy-pass. Thanks, Pierre [0]: https://git.zx2c4.com/password-store/commit/contrib?id=7aa17d099577730d2d65332896b74d5865b22abf From c49967bd6946887e2314a0817c717391f71794ed Mon Sep 17 00:00:00 2001 From: Pierre Langlois Date: Wed, 10 Mar 2021 09:12:02 +0000 Subject: [PATCH] gnu: emacs-password-store: 2.1.4-1.918992c [security fix]. Includes a fix to no longer store clear passwords in a temporary file, see commit 7aa17d099577730d2d65332896b74d5865b22abf for details. * gnu/packages/emacs-xyz.scm (emacs-password-store): Update to 2.1.4-1.918992c. [propagated-inputs]: Remove emacs-f, add emacs-auth-source-pass. --- gnu/packages/emacs-xyz.scm | 67 ++++++++++++++++++++------------------ 1 file changed, 35 insertions(+), 32 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index b5785505a5..59e968c508 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -15041,39 +15041,42 @@ close, copy, cut, paste, undo, redo.") (license license:gpl3+)))) (define-public emacs-password-store - (package - (name "emacs-password-store") - (version "1.7.3") - (source (origin - (method url-fetch) - (uri - (string-append "https://git.zx2c4.com/password-store/snapshot/" - "password-store-" version ".tar.xz")) - (sha256 - (base32 - "1x53k5dn3cdmvy8m4fqdld4hji5n676ksl0ql4armkmsds26av1b")))) - (build-system emacs-build-system) - (arguments - `(#:phases - (modify-phases %standard-phases - (add-after 'unpack 'extract-el-file - (lambda _ - (copy-file "contrib/emacs/password-store.el" "password-store.el") - (delete-file-recursively "contrib") - (delete-file-recursively "man") - (delete-file-recursively "src") - (delete-file-recursively "tests")))))) - (propagated-inputs - `(("emacs-f" ,emacs-f) - ("emacs-s" ,emacs-s) - ("emacs-with-editor" ,emacs-with-editor) - ("password-store" ,password-store))) - (home-page "https://git.zx2c4.com/password-store/tree/contrib/emacs") - (synopsis "Password store (pass) support for Emacs") - (description - "This package provides functions for working with pass (\"the + (let ((commit "918992c19231b33b3d4a3288a7288a620e608cb4") + (revision "1")) + (package + (name "emacs-password-store") + (version (git-version "2.1.4" revision commit)) + (source (origin + (method git-fetch) + (uri (git-reference + (url "git://git.zx2c4.com/password-store") + (commit commit))) + (sha256 + (base32 + "0ni62f4pq96g0i0q66bch1dl9k4zqwhg7xaf746k3gbbqxcdh3vi")) + (file-name (git-file-name name version)))) + (build-system emacs-build-system) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'extract-el-file + (lambda _ + (copy-file "contrib/emacs/password-store.el" "password-store.el") + (delete-file-recursively "contrib") + (delete-file-recursively "man") + (delete-file-recursively "src") + (delete-file-recursively "tests")))))) + (propagated-inputs + `(("emacs-auth-source-pass" ,emacs-auth-source-pass) + ("emacs-s" ,emacs-s) + ("emacs-with-editor" ,emacs-with-editor) + ("password-store" ,password-store))) + (home-page "https://git.zx2c4.com/password-store/tree/contrib/emacs") + (synopsis "Password store (pass) support for Emacs") + (description + "This package provides functions for working with pass (\"the standard Unix password manager\").") - (license license:gpl2+))) + (license license:gpl2+)))) (define-public emacs-auth-source-pass (let ((commit "847a1f54ed48856b4dfaaa184583ef2c84173edf") -- 2.30.1