Message ID | 87y1p2nsh6.fsf@pisemsky.com |
---|---|
State | New |
Headers | show |
Series | [bug#61468] gnu: cat-avatar-generator: Update to 2. | expand |
Hi, On Mon, 13 Feb 2023 at 06:40, Evgeny Pisemsky <evgeny@pisemsky.com> wrote: > (define-public cat-avatar-generator > (package > (name "cat-avatar-generator") > - (version "1") > + (version "2") > (source (origin > (method git-fetch) > (uri (git-reference > - (url "https://framagit.org/Deevad/cat-avatar-generator.git") > - (commit "71c0c662742cafe8afd2d2d50ec84243113e35ad"))) > + (url "https://framagit.org/Deevad/cat-avatar-generator.git") > + (commit "9360ea33f79d1dad3e43494b09878b5e3f6b41fa"))) The common practise when it is not yet released is to use this pattern: --8<---------------cut here---------------start------------->8--- (let ((commit "9360ea33f79d1dad3e43494b09878b5e3f6b41fa") (revision "2")) (package (name "cat-avatar-generator") (version (git-version "1" revision commit)) [...] (commit commit) --8<---------------cut here---------------end--------------->8--- Although it was not used by the initial addition 3bedac50571204643d5e3b204dc720ae7d571a1f. :-) Even, maybe version should 0 and not 1; I do not know. Cheers, simon
Hehe version "1" got through review ;) I agree it would be nice to use git-version instead, but I wouldn't go back to version "0" since guix would detect a package downgrade. Evgeny, I can take care of that don't worry. Le 13 février 2023 12:47:05 GMT+01:00, zimoun <zimon.toutoune@gmail.com> a écrit : >Hi, > >On Mon, 13 Feb 2023 at 06:40, Evgeny Pisemsky <evgeny@pisemsky.com> wrote: > >> (define-public cat-avatar-generator >> (package >> (name "cat-avatar-generator") >> - (version "1") >> + (version "2") >> (source (origin >> (method git-fetch) >> (uri (git-reference >> - (url "https://framagit.org/Deevad/cat-avatar-generator.git") >> - (commit "71c0c662742cafe8afd2d2d50ec84243113e35ad"))) >> + (url "https://framagit.org/Deevad/cat-avatar-generator.git") >> + (commit "9360ea33f79d1dad3e43494b09878b5e3f6b41fa"))) > >The common practise when it is not yet released is to use this pattern: > >--8<---------------cut here---------------start------------->8--- >(let ((commit "9360ea33f79d1dad3e43494b09878b5e3f6b41fa") > (revision "2")) > (package > (name "cat-avatar-generator") > (version (git-version "1" revision commit)) >[...] > (commit commit) >--8<---------------cut here---------------end--------------->8--- > >Although it was not used by the initial addition >3bedac50571204643d5e3b204dc720ae7d571a1f. :-) > >Even, maybe version should 0 and not 1; I do not know. > >Cheers, >simon > > >
From 7b45846379b9ef03ae578d2588a8113923a47c7b Mon Sep 17 00:00:00 2001 From: Evgeny Pisemsky <evgeny@pisemsky.com> Date: Mon, 13 Feb 2023 06:30:15 +0300 Subject: [PATCH] gnu: cat-avatar-generator: Update to 2. * gnu/packages/web.scm (cat-avatar-generator): Update to 2. --- gnu/packages/web.scm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm index a2c4709855..0bf4e6c423 100644 --- a/gnu/packages/web.scm +++ b/gnu/packages/web.scm @@ -7681,16 +7681,16 @@ (define-public geomyidae (define-public cat-avatar-generator (package (name "cat-avatar-generator") - (version "1") + (version "2") (source (origin (method git-fetch) (uri (git-reference - (url "https://framagit.org/Deevad/cat-avatar-generator.git") - (commit "71c0c662742cafe8afd2d2d50ec84243113e35ad"))) + (url "https://framagit.org/Deevad/cat-avatar-generator.git") + (commit "9360ea33f79d1dad3e43494b09878b5e3f6b41fa"))) (file-name (string-append name "-" version)) (sha256 (base32 - "0s7b5whqsmfa57prbgl66ym551kg6ly0z14h5dgrlx4lqm70y2yw")))) + "0js4grqzsm4gvmcbmxv7zw4samfzi6nk4mn977ddcvla9g222rkm")))) (build-system trivial-build-system) (arguments `(#:modules ((guix build utils)) base-commit: 3ab8559436356ef89aa60135d3558681d64443ae -- 2.39.1