From patchwork Sun Jul 21 01:03:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Z572 X-Patchwork-Id: 29468 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id E318127BBE9; Sun, 21 Jul 2024 02:05:15 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 1D3A727BBE2 for ; Sun, 21 Jul 2024 02:05:15 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sVL0b-0003yJ-15; Sat, 20 Jul 2024 21:05:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sVL0X-0003xx-Px for guix-patches@gnu.org; Sat, 20 Jul 2024 21:05:01 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sVL0X-0005jE-Gl for guix-patches@gnu.org; Sat, 20 Jul 2024 21:05:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sVL0Y-0005c2-Dw for guix-patches@gnu.org; Sat, 20 Jul 2024 21:05:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71993] [PATCH core-updates 0/2] Don't use libfaketime for key package tests on 32bit systems Resent-From: Zheng Junjie Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 21 Jul 2024 01:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71993 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 71993@debbugs.gnu.org Received: via spool by 71993-submit@debbugs.gnu.org id=B71993.172152385221504 (code B ref 71993); Sun, 21 Jul 2024 01:05:02 +0000 Received: (at 71993) by debbugs.gnu.org; 21 Jul 2024 01:04:12 +0000 Received: from localhost ([127.0.0.1]:54536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sVKzj-0005al-O6 for submit@debbugs.gnu.org; Sat, 20 Jul 2024 21:04:12 -0400 Received: from smtp84.cstnet.cn ([159.226.251.84]:38038 helo=cstnet.cn) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sVKzf-0005a8-9y for 71993@debbugs.gnu.org; Sat, 20 Jul 2024 21:04:10 -0400 Received: from m (unknown [64.176.166.156]) by APP-05 (Coremail) with SMTP id zQCowABHLThvXpxmisQVAA--.646S2; Sun, 21 Jul 2024 09:03:48 +0800 (CST) From: Zheng Junjie In-Reply-To: <87bk389sop.fsf@cbaines.net> (Christopher Baines's message of "Mon, 08 Jul 2024 10:47:02 +0200") References: <87bk389sop.fsf@cbaines.net> Date: Sun, 21 Jul 2024 09:03:36 +0800 Message-ID: <87wmlf5zfb.fsf@iscas.ac.cn> MIME-Version: 1.0 X-CM-TRANSID: zQCowABHLThvXpxmisQVAA--.646S2 X-Coremail-Antispam: 1UD129KBjvdXoW7GrW7uw4rXw1fKFy8KFyUKFg_yoWkXFg_GF 4xJa93Xws5XFWkuFZrJ3WrCry5GrW7Z3W5Za17Xr97uryfA347t3ZFkryYvFW5uayrG34U GF4IyryFkr9xZjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbskYjsxI4VWkKwAYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I 6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM2 8CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWDJVCq3wA2z4x0Y4vE2Ix0 cI8IcVCY1x0267AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4 A2jsIEc7CjxVAFwI0_GcCE3s1lnx0Ee4C267I2x7xF54xIwI0E7I0Y6sxI4wAS0I0E0xvY zxvE52x082IY62kv0487M2AExVA0xI801c8C04v7Mc02F40EFcxC0VAKzVAqx4xG6I80ew Av7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY 6r1j6r4UM4x0Y48IcVAKI48JMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r 4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF 67AKxVWUXVWUAwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2I x0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2 z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73Uj IFyTuYvjxU6cdbDUUUU X-Originating-IP: [64.176.166.156] X-CM-SenderInfo: x2kh0wxmxqyx3h6l2u1dvotugofq/ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Christopher Baines writes: > As it fails to build and seems broken. > > > Christopher Baines (2): > gnu: nss: Don't use libfaketime on 32bit systems. > gnu: python-pyopenssl: Don't use libfaketime on 32bit systems. > > gnu/packages/nss.scm | 15 +++++++++++++-- > gnu/packages/python-crypto.scm | 10 ++++++++-- > 2 files changed, 21 insertions(+), 4 deletions(-) libfaketime is actually good, it just fails the test because coreutils uses 64bit time_t. gnulib will enable 64bit time_t on 32bit platforms, but we don't currently support this, mixed abi will cause many problems[1], so turning off 64bit time_t on coreutils can fix libfaketime's tests, and nss can also use libfaketime because they use same time_t. And libfaketime is not provided 64-bit time_t support on 32-bit archs, see https://github.com/wolfcw/libfaketime/issues/418 We need to open a new branch to migrate time64 later And see also https://wiki.gentoo.org/wiki/Project:Toolchain/time64_migration https://wiki.debian.org/ReleaseGoals/64bit-time [1] https://bugs.gentoo.org/828001 From 273c1c1189d824b86ae531bd1b5df601f0e7e838 Mon Sep 17 00:00:00 2001 Message-ID: <273c1c1189d824b86ae531bd1b5df601f0e7e838.1721522810.git.zhengjunjie@iscas.ac.cn> In-Reply-To: <5cbb346385201fb6fce1057a13a49c7977e9dd34.1721522810.git.zhengjunjie@iscas.ac.cn> References: <5cbb346385201fb6fce1057a13a49c7977e9dd34.1721522810.git.zhengjunjie@iscas.ac.cn> From: Zheng Junjie Date: Sun, 21 Jul 2024 08:36:28 +0800 Subject: [PATCH 2/2] gnu: coreutils: Disable 64bit time_t on 32bit platform. * gnu/packages/nss.scm (nss)[arguments]<#:configure-flags>: Pass gl_cv_type_time_t_bits_macro=no on 32bit platform. Change-Id: I3ba9e21733727a41f2070a27ccba39c9d5f2d406 --- gnu/packages/base.scm | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/gnu/packages/base.scm b/gnu/packages/base.scm index bc30d73426..47488c1603 100644 --- a/gnu/packages/base.scm +++ b/gnu/packages/base.scm @@ -471,6 +471,13 @@ (define-public coreutils " test-renameatu" " test-utimensat"))) '()) + ,@(if (target-64bit?) + '() + ;; We currently do not support 64-bit time_t on 32-bit platforms, + ;; mixing different bits of time_t will cause a lot of problems + ;; so forcibly disable it. + ;; see https://wiki.gentoo.org/wiki/Project:Toolchain/time64_migration + '(#:configure-flags (list "gl_cv_type_time_t_bits_macro=no"))) #:phases (modify-phases %standard-phases (add-before 'build 'patch-shell-references (lambda _ -- 2.45.2