From patchwork Mon Sep 2 17:23:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rutherther X-Patchwork-Id: 67541 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id ED3AA27BBEA; Mon, 2 Sep 2024 22:55:36 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 5D3CA27BBE2 for ; Mon, 2 Sep 2024 22:55:36 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1slF0v-00031x-Fn; Mon, 02 Sep 2024 17:55:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1slF0n-00030y-J7 for guix-patches@gnu.org; Mon, 02 Sep 2024 17:55:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1slF0n-00019u-96 for guix-patches@gnu.org; Mon, 02 Sep 2024 17:55:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:From:Date:To:In-Reply-To:References:Subject; bh=FNjtBXTrWTaK/GSBkZgPOVQZf+r7v4vAelw64edbQfY=; b=K5sW5MfgTqGUpv5bYHtldCTRjpZuJ2pr8sFSm0UNx+IWIEjutEU+yTAgpGwEPobxPImIh3sDjDLY/AhL3IssC8BVCplLPJakSLJQ/BR8hxQjgwzsYoc9namV5eE2OxsCQGrkzVt0fF2BFuQmXasX5Q8AmbpscbWBoeOofbpHqu3xnQJbeDjcP7UDDiTtBEEPvIJ8/2vaQvoo1N252LYJVbpdpWAU08+rR4028b0tpqT7fWpejNRuo/yBKgG2crqlBpS1bjtrjOd7ElhO/oFypKSSFc5Sr57nQP31/kUpAA36ecv91nOZsFDmLa5LeoNBdHhKvZsbGNGMOM23Z0DTjg==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1slF1m-0007qX-ET for guix-patches@gnu.org; Mon, 02 Sep 2024 17:56:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72943] [PATCH] gnu: gd: Requires.private to propagated inputs References: <20240901191119.29870-1-rutherther@protonmail.com> In-Reply-To: <20240901191119.29870-1-rutherther@protonmail.com> Resent-From: Rutherther Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 02 Sep 2024 21:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72943 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 72943@debbugs.gnu.org Cc: Rutherther , Carlo Zancanaro , Tobias Geerinckx-Rice Received: via spool by 72943-submit@debbugs.gnu.org id=B72943.172531413730101 (code B ref 72943); Mon, 02 Sep 2024 21:56:02 +0000 Received: (at 72943) by debbugs.gnu.org; 2 Sep 2024 21:55:37 +0000 Received: from localhost ([127.0.0.1]:52808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slF1M-0007pJ-Tw for submit@debbugs.gnu.org; Mon, 02 Sep 2024 17:55:37 -0400 Received: from mail-4322.protonmail.ch ([185.70.43.22]:48409) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slAn7-0006Mg-Io for 72943@debbugs.gnu.org; Mon, 02 Sep 2024 13:24:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1725297809; x=1725557009; bh=FNjtBXTrWTaK/GSBkZgPOVQZf+r7v4vAelw64edbQfY=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=TjabWuNZGGo4aVpfAe15mjH4uU/yGJGiM5f9kgnDVzEVr2Wgv7GErJlw5x8FUudf1 /x1Cg0zBCTfcd9jXJrbrl51DIHEIizVZdqaxr0AfB2uXUSdzgNK/+FCb/DL6lRWqlH Mvs/ONVlHaaucITuY9Blq+rt19lCsFxlZfaqreI+6brOeST6F207vo3OaxNoVIMq4g lILY1bi8Od9T3XX7oYYWGdyN6+dryqH0MwEodXeDN9Fp/A2wzsfVe4lePG51vTDC7i xAgizlgjBh9BINncV6ZhepR+OIut8pbXAQCS2tyYa4MQnlgIosna7YUGwtJ/LULglW aIEYWSblN36CQ== Date: Mon, 02 Sep 2024 17:23:22 +0000 Message-ID: <87v7zeezr1.fsf@protonmail.com> Feedback-ID: 8107604:user:proton X-Pm-Message-ID: 74f8fef67c21f962942449c2f96dc241a2292eca MIME-Version: 1.0 X-Mailman-Approved-At: Mon, 02 Sep 2024 17:55:32 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Rutherther X-ACL-Warn: , Rutherther via Guix-patches X-Patchwork-Original-From: Rutherther via Guix-patches via From: Rutherther Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Hello Carlo, thank you for finding that! That explains why this issue was caused in the first place, I was wondering how this could've been unspotted till now. It seems much better to me to not use propagated-inputs whenever possible, so I prefer your solution to this one. However, I do wonder about this: other packages that have Requires.private do provide the libraries in these as propagated-inputs. Also the cookbook shows to do this with such libraries. What is the correct approach here then? Maybe every package that has Requires.private could be patched like this, possibly somehow automatically instead of manual patches? I am quite new here, this is my first patch. So I am not really sure how to go about this. Will you open a new issue with your patch, and maintainers will decide patch from which issue to use? Or is it enough it's in this issue? I am sending an updated patch with a comment for why specifying propagates-inputs would be necessary in the meantime, as Tobias suggested me in a review in #guix IRC channel. --- gnu/packages/gd.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gnu/packages/gd.scm b/gnu/packages/gd.scm index 98d34cfa71..1380493c44 100644 --- a/gnu/packages/gd.scm +++ b/gnu/packages/gd.scm @@ -85,7 +85,8 @@ (define-public gd "\\.la$"))))))) (native-inputs (list pkg-config)) - (inputs + ;; These libraries are in 'Requires.private' in libgd.pc. + (propagated-inputs (list fontconfig freetype libjpeg-turbo