| Message ID | 87tvk08dho.fsf@gnu.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | bug#33534: [PATCH] gnu: Add arcanist. | expand |
| Context | Check | Description |
|---|---|---|
| cbaines/applying patch | fail | Apply failed |
ludo@gnu.org (Ludovic Courtès) writes: > Hello Robin, > > Robin Templeton <robin@igalia.com> skribis: > >> * gnu/packages/phabricator.scm: New file. >> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it. > > Applied with minor changes to the description (attached), mostly to give > some context to those who do not know what Phabricator is. Thanks! > BTW we traditionally write one patch for each new package, but I think > it’s okay here. > >> + (home-page "https://github.com/phacility/libphutil") >> + (synopsis "PHP utility library") >> + (description >> + "@code{libphutil} is a collection of utility classes and functions for >> +PHP.") >> + ;; Bundled libraries are expat-licensed. >> + (license (list license:asl2.0 license:expat))))) > > Do you think those libraries could be unbundled? Would it make sense? Possibly, but they seem to be maintaining their own fork of at least jsonlint, so the upstream versions may not be 100% compatible.
Hello, Robin Templeton <rtempleton@igalia.com> skribis: > ludo@gnu.org (Ludovic Courtès) writes: [...] >>> + (home-page "https://github.com/phacility/libphutil") >>> + (synopsis "PHP utility library") >>> + (description >>> + "@code{libphutil} is a collection of utility classes and functions for >>> +PHP.") >>> + ;; Bundled libraries are expat-licensed. >>> + (license (list license:asl2.0 license:expat))))) >> >> Do you think those libraries could be unbundled? Would it make sense? > > Possibly, but they seem to be maintaining their own fork of at least > jsonlint, so the upstream versions may not be 100% compatible. OK, maybe something to keep in mind when we add more PHP packages in the future. Thank you, Ludo’.
diff --git a/gnu/packages/phabricator.scm b/gnu/packages/phabricator.scm index 6834373fbc..6c94a13114 100644 --- a/gnu/packages/phabricator.scm +++ b/gnu/packages/phabricator.scm @@ -117,7 +117,8 @@ PHP.") (home-page "https://github.com/phacility/arcanist") (synopsis "Command-line interface for Phabricator") (description - "Arcanist is the command-line tool for Phabricator. It allows you to -interact with Phabricator installs to send code for review, download patches, -transfer files, view status, make API calls, and various other things.") + "Arcanist is the command-line tool for the Phabricator software +development service. It allows you to interact with Phabricator installs to +send code for review, download patches, transfer files, view status, make API +calls, and various other things.") (license license:asl2.0))))