From patchwork Tue Jun 1 09:49:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Othacehe X-Patchwork-Id: 29744 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 26F5927BC81; Tue, 1 Jun 2021 10:51:10 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id E691227BC78 for ; Tue, 1 Jun 2021 10:51:09 +0100 (BST) Received: from localhost ([::1]:60600 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lo13F-0003s0-1F for patchwork@mira.cbaines.net; Tue, 01 Jun 2021 05:51:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52908) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lo138-0003rq-Bn for guix-patches@gnu.org; Tue, 01 Jun 2021 05:51:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52469) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lo138-0007cA-4Q for guix-patches@gnu.org; Tue, 01 Jun 2021 05:51:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lo138-0006Pj-0q for guix-patches@gnu.org; Tue, 01 Jun 2021 05:51:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 01 Jun 2021 09:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.162254102024575 (code B ref 47979); Tue, 01 Jun 2021 09:51:01 +0000 Received: (at 47979) by debbugs.gnu.org; 1 Jun 2021 09:50:20 +0000 Received: from localhost ([127.0.0.1]:35782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lo12R-0006OI-Qx for submit@debbugs.gnu.org; Tue, 01 Jun 2021 05:50:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lo12O-0006Nx-E2 for 47979@debbugs.gnu.org; Tue, 01 Jun 2021 05:50:17 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51340) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lo12I-0006w2-RE; Tue, 01 Jun 2021 05:50:10 -0400 Received: from [2a01:e0a:19b:d9a0:f2f7:a404:c3d3:f8b4] (port=45336 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lo127-0006tq-LU; Tue, 01 Jun 2021 05:50:10 -0400 From: Mathieu Othacehe References: <87lf88qm47.fsf_-_@gnu.org> Date: Tue, 01 Jun 2021 11:49:55 +0200 In-Reply-To: (Leo Famulari's message of "Fri, 21 May 2021 17:01:36 -0400") Message-ID: <87tumh6hj0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hey Leo, > cannot build derivation `/gnu/store/20flyxbjjl8as5aca4gzf3b54as1gr9z-ntp-4.2.8p15.drv': 1 dependencies couldn't be built The installation tests are run in a network isolated environment. This means that we need to make sure that every single derivation that will be needed during the installation is made available. It is for sure a tricky business. If you have a look to the error line I pasted above, you will see that the installer tries to build the ntp package because the ntp-service-type is now included. The following patch fixes the "gui-installed-os" test by making sure that the ntp package is available in the installation environment. I did not check for the other installation tests. --8<---------------cut here---------------start------------->8--- --8<---------------cut here---------------end--------------->8--- Thanks, Mathieu diff --git a/gnu/tests/install.scm b/gnu/tests/install.scm index b5263f5f0d..e9ebc63b64 100644 --- a/gnu/tests/install.scm +++ b/gnu/tests/install.scm @@ -1608,8 +1608,9 @@ build (current-guix) and then store a couple of full system images.") (swap-devices (if encrypted? '() (list (uuid "11111111-2222-3333-4444-123456789abc")))) - (services (cons (service dhcp-client-service-type) - (operating-system-user-services %minimal-os-on-vda))))) + (services (cons* (service dhcp-client-service-type) + (service ntp-service-type) + (operating-system-user-services %minimal-os-on-vda))))) (define* (installation-target-desktop-os-for-gui-tests #:key (encrypted? #f))