From patchwork Sat Nov 20 05:21:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Vagrant Cascadian X-Patchwork-Id: 34699 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id F07CA27BBE3; Sat, 20 Nov 2021 05:24:44 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id ABA6927BBE1 for ; Sat, 20 Nov 2021 05:24:44 +0000 (GMT) Received: from localhost ([::1]:58778 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1moIrj-0003ME-KH for patchwork@mira.cbaines.net; Sat, 20 Nov 2021 00:24:43 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38868) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moIp8-0002U6-CQ for guix-patches@gnu.org; Sat, 20 Nov 2021 00:22:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:58015) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1moIp8-0000of-2P for guix-patches@gnu.org; Sat, 20 Nov 2021 00:22:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1moIp7-0000wJ-SQ for guix-patches@gnu.org; Sat, 20 Nov 2021 00:22:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51775] default tar format for "make dist" and patch file length Resent-From: Vagrant Cascadian Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 20 Nov 2021 05:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51775 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Philip McGrath , Ludovic =?utf-8?q?Court=C3=A8?= =?utf-8?q?s?= Cc: guix-devel@gnu.org, 51775@debbugs.gnu.org Received: via spool by 51775-submit@debbugs.gnu.org id=B51775.16373857123592 (code B ref 51775); Sat, 20 Nov 2021 05:22:01 +0000 Received: (at 51775) by debbugs.gnu.org; 20 Nov 2021 05:21:52 +0000 Received: from localhost ([127.0.0.1]:41328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moIoy-0000vs-6C for submit@debbugs.gnu.org; Sat, 20 Nov 2021 00:21:52 -0500 Received: from cascadia.aikidev.net ([173.255.214.101]:48810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moIow-0000ve-87 for 51775@debbugs.gnu.org; Sat, 20 Nov 2021 00:21:50 -0500 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:21:21:0:100e]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 06C051AA41; Fri, 19 Nov 2021 21:21:43 -0800 (PST) From: Vagrant Cascadian In-Reply-To: <071f69a4-4e8a-3337-6a84-6ceca5119e6f@philipmcgrath.com> References: <87sfvxhrav.fsf@ponder> <874k8bxbit.fsf@gnu.org> <87fsru8l05.fsf@ponder> <87czmy8hr6.fsf@ponder> <87y25kjiwa.fsf@gnu.org> <071f69a4-4e8a-3337-6a84-6ceca5119e6f@philipmcgrath.com> Date: Fri, 19 Nov 2021 21:21:29 -0800 Message-ID: <87tug7jtba.fsf@ponder> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches On 2021-11-19, Philip McGrath wrote: > On 11/19/21 09:54, Ludovic Courtès wrote: >> Vagrant Cascadian skribis: >>> So, I guess I'm leaning towards making the guix lint check a little more >>> lenient. >>> >>> Thoughts? >> >> That sounds even better, I’m all for it (changing (guix lint) + fixing >> the two remaining issues)! Submitted the guix lint change as https://issues.guix.gnu.org/51775 > It might also help to change the warning given by the check. > > When a program called "lint" tells me that something is too long, I > understand that to mean that what I've done is generally considered bad > style, but there might be a very good reason to do it in some specific > case. For example, I might exceed a line length guideline to avoid > inserting linebreaks into a URL. That's a good point! > If instead `guix lint` is telling us about a hard limit that will break > things, I think it should say so clearly. Not sure how to convey succinctly, but here's an attempt at a patch (which ironically also probably makes the line a bit too long in the code): "x" live well, vagrant diff --git a/guix/lint.scm b/guix/lint.scm index ac2e7b3841..6464fb751a 100644 --- a/guix/lint.scm +++ b/guix/lint.scm @@ -968,7 +968,7 @@ (define (starts-with-package-name? file-name) max) (make-warning package - (G_ "~a: file name is too long") + (G_ "~a: file name is too long and may break release tarball generation") (list (basename patch)) #:field 'patch-file-names) #f)) diff --git a/tests/lint.scm b/tests/lint.scm index 9a91dd5426..d4c3d62aaf 100644 --- a/tests/lint.scm +++ b/tests/lint.scm @@ -509,7 +509,7 @@ (define hsab (string-append (assoc-ref inputs "hsab") (test-equal "patches: file name too long" (string-append "x-" (make-string 100 #\a) - ".patch: file name is too long") + ".patch: file name is too long and may break release tarball generation") (single-lint-warning-message (let ((pkg (dummy-package