Message ID | 87ttmf9tj0.fsf@troyfigiel.com |
---|---|
State | New |
Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 5D24227BBEA; Sun, 11 Feb 2024 10:38:30 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id CF88C27BBE2 for <patchwork@mira.cbaines.net>; Sun, 11 Feb 2024 10:38:29 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1rZ7Dc-000154-E3; Sun, 11 Feb 2024 05:37:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1rZ7DX-00014G-9u for guix-patches@gnu.org; Sun, 11 Feb 2024 05:37:47 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1rZ7DX-00035a-1w for guix-patches@gnu.org; Sun, 11 Feb 2024 05:37:47 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1rZ7Dn-0004aw-4a for guix-patches@gnu.org; Sun, 11 Feb 2024 05:38:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69043] [PATCH] gnu: go-github-com-charmbracelet-bubbletea: Delete examples. Resent-From: Troy Figiel <troy@troyfigiel.com> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 11 Feb 2024 10:38:02 +0000 Resent-Message-ID: <handler.69043.B.170764784517543@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 69043 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 69043@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.170764784517543 (code B ref -1); Sun, 11 Feb 2024 10:38:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Feb 2024 10:37:25 +0000 Received: from localhost ([127.0.0.1]:37411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1rZ7DB-0004Yt-DL for submit@debbugs.gnu.org; Sun, 11 Feb 2024 05:37:25 -0500 Received: from lists.gnu.org ([2001:470:142::17]:43160) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <troy@troyfigiel.com>) id 1rZ7DA-0004YZ-11 for submit@debbugs.gnu.org; Sun, 11 Feb 2024 05:37:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <troy@troyfigiel.com>) id 1rZ7Co-00012M-IV for guix-patches@gnu.org; Sun, 11 Feb 2024 05:37:02 -0500 Received: from mout-p-103.mailbox.org ([80.241.56.161]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from <troy@troyfigiel.com>) id 1rZ7Cm-0002zq-6M for guix-patches@gnu.org; Sun, 11 Feb 2024 05:37:02 -0500 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4TXkY40KrBz9sbL for <guix-patches@gnu.org>; Sun, 11 Feb 2024 11:36:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=troyfigiel.com; s=MBO0001; t=1707647816; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=mAtm/tm+aA9e5i1L2INt5LG04hu/HkLjmIzjqUlfSrE=; b=IlPg2ODIbcKYsPvebLJzWcYZNlNKC+6wHiRtDhYerXlXqS1YmujnVgz9VD1gGWpfAxrjuC XoTpdBllZs2w4180GnnkPss/t1tV2d1yuJ+X+aa/A4XoANG9gkutD1yHyr6ceCRy9in0IG 540xKsGWIIae56heB7THWynFqry1sseMtEdErBtvE3wzIDHUAjMOAIgTv4x2JfpaeENbaU ntQv972b6AT/Kiu03xvdZk9F5X7QUdhEy1YzGCBGrLcY0LHhKfNIfTMt3dF+6kMgczleMc +JKm6GvdtvOa1aw9HAQpsCz1tx2FVpj6i7LjJQddCE7910VchQKSUiJTqe1uJA== From: Troy Figiel <troy@troyfigiel.com> Date: Sun, 11 Feb 2024 01:24:12 +0100 Message-ID: <87ttmf9tj0.fsf@troyfigiel.com> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 4TXkY40KrBz9sbL Received-SPF: pass client-ip=80.241.56.161; envelope-from=troy@troyfigiel.com; helo=mout-p-103.mailbox.org X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_06_12=1.543, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
Series |
[bug#69043] gnu: go-github-com-charmbracelet-bubbletea: Delete examples.
|
|
Commit Message
Troy Figiel
Feb. 11, 2024, 12:24 a.m. UTC
* gnu/packages/golang.scm (go-github-com-charmbracelet-bubbletea)[source]: Delete examples and tutorials. --- gnu/packages/golang.scm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) base-commit: 9edbb2d7a40c9da7583a1046e39b87633459f656
Comments
As a note, quite a few Go packages come with "examples", "tutorials" or "benchmarks". These prevent us from recursively building or testing all packages, as they often come with their own go.mod file or require Go libraries that create cyclical dependencies. These directories are not needed for the package to work though. On 2024-02-11 01:24, Troy Figiel wrote: > * gnu/packages/golang.scm (go-github-com-charmbracelet-bubbletea)[source]: Delete examples and tutorials. > --- > gnu/packages/golang.scm | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm > index 163691a1e6..d917f02a25 100644 > --- a/gnu/packages/golang.scm > +++ b/gnu/packages/golang.scm > @@ -10443,7 +10443,10 @@ (define-public go-github-com-charmbracelet-bubbletea > (file-name (git-file-name name version)) > (sha256 > (base32 > - "1105cggi5fwqx69m0vrhgwx6kaw82w4ahn58sj0a81603c4yvrk0")))) > + "1105cggi5fwqx69m0vrhgwx6kaw82w4ahn58sj0a81603c4yvrk0")) > + (modules '((guix build utils))) > + (snippet '(for-each delete-file-recursively > + '("examples" "tutorials"))))) > (build-system go-build-system) > (arguments > `(#:import-path "github.com/charmbracelet/bubbletea")) > > base-commit: 9edbb2d7a40c9da7583a1046e39b87633459f656
I used the word "delete" here, whereas other patches use "remove". I wasn't sure which word would be better, but uniformizing would be best anyway.
Hi Troy, On Sun, 11 Feb 2024 18:50:18 +0800, Troy Figiel wrote: > > As a note, quite a few Go packages come with "examples", "tutorials" or > "benchmarks". These prevent us from recursively building or testing all > packages, as they often come with their own go.mod file or require Go > libraries that create cyclical dependencies. These directories are not > needed for the package to work though. > > On 2024-02-11 01:24, Troy Figiel wrote: > > * gnu/packages/golang.scm (go-github-com-charmbracelet-bubbletea)[source]: Delete examples and tutorials. > > --- > > gnu/packages/golang.scm | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm > > index 163691a1e6..d917f02a25 100644 > > --- a/gnu/packages/golang.scm > > +++ b/gnu/packages/golang.scm > > @@ -10443,7 +10443,10 @@ (define-public go-github-com-charmbracelet-bubbletea > > (file-name (git-file-name name version)) > > (sha256 > > (base32 > > - "1105cggi5fwqx69m0vrhgwx6kaw82w4ahn58sj0a81603c4yvrk0")))) > > + "1105cggi5fwqx69m0vrhgwx6kaw82w4ahn58sj0a81603c4yvrk0")) > > + (modules '((guix build utils))) > > + (snippet '(for-each delete-file-recursively > > + '("examples" "tutorials"))))) > > (build-system go-build-system) > > (arguments > > `(#:import-path "github.com/charmbracelet/bubbletea")) > > > > base-commit: 9edbb2d7a40c9da7583a1046e39b87633459f656 Since examples and tutorials are still useful for context like getting source code with ‘guix build --source go-github-com-charmbracelet-bubbletea’, and when distributing source code, it makes more sense to have them as well, I'd suggest deleting them in a separate build phase. Thanks
Hi, On 2024-02-11 15:24, Hilton Chain wrote: > Since examples and tutorials are still useful for context like getting source > code with ‘guix build --source go-github-com-charmbracelet-bubbletea’, and when > distributing source code, it makes more sense to have them as well, I'd suggest > deleting them in a separate build phase. Good point, I will add a phase after the unpack phase. Best wishes, Troy
Hi, Pushed as 14ea50518d26060b12149078371b4a50e0dee938 to master. -- Oleg
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index 163691a1e6..d917f02a25 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -10443,7 +10443,10 @@ (define-public go-github-com-charmbracelet-bubbletea (file-name (git-file-name name version)) (sha256 (base32 - "1105cggi5fwqx69m0vrhgwx6kaw82w4ahn58sj0a81603c4yvrk0")))) + "1105cggi5fwqx69m0vrhgwx6kaw82w4ahn58sj0a81603c4yvrk0")) + (modules '((guix build utils))) + (snippet '(for-each delete-file-recursively + '("examples" "tutorials"))))) (build-system go-build-system) (arguments `(#:import-path "github.com/charmbracelet/bubbletea"))