From patchwork Fri May 24 16:05:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Patchwork-Id: 14066 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 277D817016; Fri, 24 May 2019 17:19:07 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id D4CC116FFA for ; Fri, 24 May 2019 17:19:06 +0100 (BST) Received: from localhost ([127.0.0.1]:57128 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUCuQ-0002GU-A9 for patchwork@mira.cbaines.net; Fri, 24 May 2019 12:19:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38216) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUChq-0007WT-8N for guix-patches@gnu.org; Fri, 24 May 2019 12:06:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hUCho-0005al-Cf for guix-patches@gnu.org; Fri, 24 May 2019 12:06:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33589) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hUChm-0005Zx-PJ for guix-patches@gnu.org; Fri, 24 May 2019 12:06:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hUChm-0000bj-J2 for guix-patches@gnu.org; Fri, 24 May 2019 12:06:02 -0400 Subject: bug#35854: [PATCH] lxqt: lxqt-panel: fix taskbar plugin's application list issue. Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Fri, 24 May 2019 16:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 35854 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Reza Alizadeh Majd Mail-Followup-To: 35854@debbugs.gnu.org, ludo@gnu.org, r.majd@pantherx.org Received: via spool by 35854-done@debbugs.gnu.org id=D35854.15587139422291 (code D ref 35854); Fri, 24 May 2019 16:06:02 +0000 Received: (at 35854-done) by debbugs.gnu.org; 24 May 2019 16:05:42 +0000 Received: from localhost ([127.0.0.1]:47132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUChR-0000at-VC for submit@debbugs.gnu.org; Fri, 24 May 2019 12:05:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUChQ-0000ad-Tv for 35854-done@debbugs.gnu.org; Fri, 24 May 2019 12:05:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41562) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUChI-0005Bo-9F; Fri, 24 May 2019 12:05:32 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=36854 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hUCgs-0002ee-DM; Fri, 24 May 2019 12:05:25 -0400 From: Ludovic =?utf-8?q?Court=C3=A8s?= References: <20190522072716.11256-1-r.majd@pantherx.org> Date: Fri, 24 May 2019 18:05:03 +0200 In-Reply-To: <20190522072716.11256-1-r.majd@pantherx.org> (Reza Alizadeh Majd's message of "Wed, 22 May 2019 11:57:16 +0430") Message-ID: <87sgt3sus0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 35854-done@debbugs.gnu.org Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Reza Alizadeh Majd skribis: > * gnu/packages/lxqt.scm (lxqt-panel): move `kwindowsystem` from `inputs` > to `propagated-inputs` Applied, but I added a comment based on your message (see below). In general, ‘propagated-inputs’ should be used only when strictly necessary, so when we use them, it’s important to add comments explaining why we do so. Thanks for the patch! Ludo’. diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm index c3b25e5417..a8699b3d09 100644 --- a/gnu/packages/lxqt.scm +++ b/gnu/packages/lxqt.scm @@ -583,7 +583,9 @@ of other programs.") ("lxqt-build-tools" ,lxqt-build-tools) ("qttools" ,qttools))) (propagated-inputs - `(("kwindowsystem" ,kwindowsystem))) + ;; Propagating KWINDOWSYSTEM so that the list of opened applications + ;; shows up in lxqt-panel's taskbar plugin. + `(("kwindowsystem" ,kwindowsystem))) (arguments '(#:tests? #f ; no tests #:phases