From patchwork Sat Jul 25 15:02:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "LaFreniere, Joseph" X-Patchwork-Id: 23373 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 42D6B27BBE1; Sat, 25 Jul 2020 16:03:08 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 28C0027BBE3 for ; Sat, 25 Jul 2020 16:03:07 +0100 (BST) Received: from localhost ([::1]:34254 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jzLha-0002Vc-OP for patchwork@mira.cbaines.net; Sat, 25 Jul 2020 11:03:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jzLhW-0002VI-Gm for guix-patches@gnu.org; Sat, 25 Jul 2020 11:03:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39247) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jzLhW-0007zk-7z for guix-patches@gnu.org; Sat, 25 Jul 2020 11:03:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jzLhW-0003Be-3C for guix-patches@gnu.org; Sat, 25 Jul 2020 11:03:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42525] [PATCH 2/2] gnu: Add emacs-major-mode-hydra. Resent-From: "LaFreniere, Joseph" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 25 Jul 2020 15:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42525 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Oleg Pykhalov Cc: 42525@debbugs.gnu.org Received: via spool by 42525-submit@debbugs.gnu.org id=B42525.159568933512192 (code B ref 42525); Sat, 25 Jul 2020 15:03:02 +0000 Received: (at 42525) by debbugs.gnu.org; 25 Jul 2020 15:02:15 +0000 Received: from localhost ([127.0.0.1]:50793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jzLgl-0003AZ-4x for submit@debbugs.gnu.org; Sat, 25 Jul 2020 11:02:15 -0400 Received: from mx.kolabnow.com ([95.128.36.42]:42982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jzLgj-0003AM-5y for 42525@debbugs.gnu.org; Sat, 25 Jul 2020 11:02:14 -0400 Received: from localhost (unknown [127.0.0.1]) by ext-mx-out002.mykolab.com (Postfix) with ESMTP id 8BF185CB; Sat, 25 Jul 2020 17:02:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-type:content-type:mime-version:message-id:date:date :in-reply-to:subject:subject:from:from:references:received :received:received; s=dkim20160331; t=1595689327; x=1597503728; bh=Nw58tuMBt10IhkPYMjb53JtMeO6CtdFjIMoUHXTbIDc=; b=ZdTySZboPeHs j0TDfO+VAoGlKqA7DI7JzcNzW9wPNMLu/BaDMZ4JzcyiM+nV9ZauXBHgRmADoC1m 1kEl+yPIWH4SbCCv9dtRMyA53aVWnZWlitaZLZEYZMXrVJzc8RDGJzVXOmzyb1+B vYeRVD0cFW0Vd0qRlscnR4wM2Kt9XDwHyq3mp+5WBn0tmHTcYU9etzsUoEAoh10W Fgh9KyRJxJaRLG4JbRjkR1Ns65eS2MUnVBXSIkaaCOYrjrapT4oo/+6VYYtjvZjn u4gDgXdFHDWPDNKVXHZY3i2ztIbiriHW/2pLkVl12y3wnuZheZctRuOrP9bZJj3H LqT3QlilPY2UcTFaeooAv2ioWDNMjJAxDAL7odFPnuNgyEjzxiTi8ELlDYs7omBi My64gsLdq9kWBdjcP3z30JwBT80vbIRk/tqbvXCTlDMVhNkYfqnWRWwqlkvs4VAF 2d45LewQy3Bk/73NGpKfoQ7MORbFvAAtJVsBdL/x7WCcisYlMr+MPOxEmj9G2OpJ wp4OMW8SMxXVyOkoPjTAQa+x7omdU/i8LoWpJ14Ok+Wmn/SmGBKspUBN5qYLVppX ytHBBTdOct69mXdWcOt6Ys+08Z4+X0CbUSfpSx8bxZafF53D64k/jug/nkM+xjUQ +9qOwm03BSsTpqSSUkMf9kD6PBAlrOg= X-Virus-Scanned: amavisd-new at mykolab.com Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out002.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bdxcNlMCWqpA; Sat, 25 Jul 2020 17:02:07 +0200 (CEST) Received: from int-mx001.mykolab.com (unknown [10.9.13.1]) by ext-mx-out002.mykolab.com (Postfix) with ESMTPS id E4B7C22E; Sat, 25 Jul 2020 17:02:06 +0200 (CEST) Received: from ext-subm001.mykolab.com (unknown [10.9.6.1]) by int-mx001.mykolab.com (Postfix) with ESMTPS id 8C27D2C7; Sat, 25 Jul 2020 17:02:06 +0200 (CEST) References: <87o8o4gxk9.fsf@odyssey.lafreniere.xyz> <87lfj8gx9q.fsf@odyssey.lafreniere.xyz> <87wo2rlo5z.fsf@gmail.com> From: "LaFreniere, Joseph" In-reply-to: <87wo2rlo5z.fsf@gmail.com> Date: Sat, 25 Jul 2020 10:02:00 -0500 Message-ID: <87r1szsknr.fsf@odyssey.lafreniere.xyz> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Thank you for the reviews, Oleg. :) Oleg Pykhalov writes: > Joseph LaFreniere writes: > >> Patch file is attached. Similar to the first patch in this >> series, `guix >> lint` reports "the source file name should contain the package >> name". > > Yes, because emacs-major-mode-hydra inherits emacs-pretty-hydra. Fixed in the updated patch for emacs-pretty-hydra. > Does emacs-major-mode-hydra is useful without emacs-pretty-hydra > and > vice versa? > > I guess not, in that case we could just have emacs-pretty-hydra > containing '*.el' for both. Yes, emacs-pretty-hydra is useful independently of emacs-major-mode-hydra. The descriptions in the initial patches were written a long time ago and were misleading. I apologize for the confusion. > Could you extend the synopsis little bit? ;-) Missed this comment in the updated patch for emacs-pretty-hydra that I just sent. I will revisit it following this mail. Is the synopsis for this recipe (emacs-major-mode-hyra) suitable? --- Joseph LaFreniere From 01cec639c237f582a9e4ecbfec1f483009bbba36 Mon Sep 17 00:00:00 2001 From: Joseph LaFreniere Date: Sat, 18 Jul 2020 12:50:22 -0500 Subject: [PATCH 2/2] gnu: Add emacs-major-mode-hydra. * gnu/packages/emacs-xyz.scm (emacs-major-mode-hydra): New variable. --- gnu/packages/emacs-xyz.scm | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index c11959dbe2..195586ca71 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -676,6 +676,25 @@ process, passing on the arguments as command line arguments.") hydras with one column per group of heads.") (license license:gpl3+))) +(define-public emacs-major-mode-hydra + (package + (inherit emacs-pretty-hydra) + (name "emacs-major-mode-hydra") + (propagated-inputs + `(("emacs-dash" ,emacs-dash) + ("emacs-pretty-hydra" ,emacs-pretty-hydra))) + (native-inputs + `(("emacs-ert-runner" ,emacs-ert-runner) + ("emacs-use-package" ,emacs-use-package) )) + (arguments + `(#:exclude (cons "^pretty-hydra\\.el$" %default-exclude) + #:tests? #t + #:test-command '("ert-runner"))) + (synopsis "Major mode keybindings managed by Hydra") + (description + "This package offers a hydra-based method of managing major mode-specific +key bindings."))) + (define-public emacs-minions (package (name "emacs-minions") -- 2.27.0