From patchwork Mon Oct 19 17:44:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Soo X-Patchwork-Id: 24693 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 65D0927BBF0; Mon, 19 Oct 2020 18:45:11 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id CBEB827BBED for ; Mon, 19 Oct 2020 18:45:10 +0100 (BST) Received: from localhost ([::1]:60196 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUZDZ-0005SF-U7 for patchwork@mira.cbaines.net; Mon, 19 Oct 2020 13:45:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUZDS-0005S1-EO for guix-patches@gnu.org; Mon, 19 Oct 2020 13:45:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58982) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kUZDS-000794-54 for guix-patches@gnu.org; Mon, 19 Oct 2020 13:45:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kUZDS-00021G-2F for guix-patches@gnu.org; Mon, 19 Oct 2020 13:45:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43930] gnu: Add emacs-graphql-mode. Resent-From: John Soo Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 19 Oct 2020 17:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43930 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Nicolas Goaziou Cc: 43930@debbugs.gnu.org Received: via spool by 43930-submit@debbugs.gnu.org id=B43930.16031294817722 (code B ref 43930); Mon, 19 Oct 2020 17:45:02 +0000 Received: (at 43930) by debbugs.gnu.org; 19 Oct 2020 17:44:41 +0000 Received: from localhost ([127.0.0.1]:42295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUZD6-00020U-KA for submit@debbugs.gnu.org; Mon, 19 Oct 2020 13:44:40 -0400 Received: from mail-pj1-f67.google.com ([209.85.216.67]:39486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUZD5-00020B-2b for 43930@debbugs.gnu.org; Mon, 19 Oct 2020 13:44:39 -0400 Received: by mail-pj1-f67.google.com with SMTP id gv6so171163pjb.4 for <43930@debbugs.gnu.org>; Mon, 19 Oct 2020 10:44:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=asu-edu.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=csawVj/HVzUcDOCjwjU1duB4ov0UQKEaJx6nqs5E6a4=; b=oan+ySffpx3falagyvqzsOEFrlhGVETwYZ3sT8ripxobIC0+3TjDSLshpciEesijAb S/oRYriddtF/Bi291i5mBO+r/QOEy65WY+KEMtCGofTpHRIp3nlrOs4eDLqDjWaCBr/I zu7kF7w16oOxY8o6uq0BFOyRKUTU4X+UyJSaZlfkjEoWam6x9ihyhDzTYqF6xwBpKGop 1HY1p9BadT2Z7qbVGLk50bIr+nuWUY+G4dahpi1qbFI0K6tgptMGBeXX7g1zNJER37KT ZDKFTe/l56+M3YBZGYkynTwva4F74wAdvRk5r98BKI5cqh9h5d8CWSZaqE3I/El493v+ aFxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=csawVj/HVzUcDOCjwjU1duB4ov0UQKEaJx6nqs5E6a4=; b=kio7VkKacM4VK2Q+Bh/42NWZpBLi/TR253zfaouFAWbR2MU7XXJi0JB2X8RlkTejrd amXADfNRRKNhEpYsClGZud3TYW93yPZU9QnatTx3dZJ8KGoNUje7HdSrUUvoF61WEM+I 4uvymYQeYGaX2gzhm2IubS+OK1ZJM9oBsxU6EaOEAz5zUT3RcHn8YKZapFEAItQkYejj GsSPhap/YzeQXQQ6rNkd/07BWpadBCETMfK38DtBJ4ricOi4MlhZCFex6W0rzAYD2n83 bgD4M6liH15jHwG2+AaR/lVX6sLNMYplPZla//t5qfWkRfayFk3cHChvYXE6Rm6aenxQ /4WQ== X-Gm-Message-State: AOAM530N8zGumIMG2DjvcvQcBwY8aNfpxTDvOuz9rpqT2X+nPzJVQO8q yBSC9rD/a6t2njZuDW7nHy7kQCBXgH16r3Hc X-Google-Smtp-Source: ABdhPJxJOkJpLTWZudvHQ+0dfkW9Sc6MDgVuXxIWsE4OOg8YxEo92NU/D5el66K4k+8sB+IKp6jzlw== X-Received: by 2002:a17:90a:8c87:: with SMTP id b7mr542998pjo.66.1603129472908; Mon, 19 Oct 2020 10:44:32 -0700 (PDT) Received: from ecenter ([2600:1700:83b0:8bd0::7a8]) by smtp.gmail.com with ESMTPSA id x18sm250644pga.49.2020.10.19.10.44.30 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 19 Oct 2020 10:44:31 -0700 (PDT) From: John Soo References: <87imbgofzz.fsf@asu.edu> <87imbe61gn.fsf@nicolasgoaziou.fr> Date: Mon, 19 Oct 2020 10:44:30 -0700 In-Reply-To: <87imbe61gn.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Tue, 13 Oct 2020 09:15:36 +0200") Message-ID: <87r1pu2jr5.fsf@asu.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi Nicolas, Thanks for the review. Nicolas Goaziou writes: > Could you add a comment explaining why you don't use a tagged commit > (in this case, there is none)? Done. >> + (revision "1")) >> + (package >> + (name "emacs-graphql-mode") >> + (version commit) >> + (source >> + (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url "https://github.com/davazp/graphql-mode") >> + (commit commit))) >> + (file-name (git-file-name name version)) >> + (sha256 >> + (base32 >> + "0x9y7qq6y0zg8ncamzvk68ccmdyzh7xsj0xs0ykyl20d5wdpplj4")))) > > Nitpick: please move the string on the same line as `base32'. Done. >> + (build-system emacs-build-system) >> + (home-page >> + "https://github.com/davazp/graphql-mode") > > Nitpick: please move the string on the same line as `home-page'. Done. >> + (synopsis "Emacs mode to edit GraphQL schema and queries") >> + (description >> + "This package provides an Emacs mode for editing graphql queries and >> +schemas.") > > I suggest to expound the description a bit. For example, using > commentary section of the library, it could be something along the lines > of: > > This package implements a major mode to edit GraphQL schemas and > query. The basic functionality includes syntax highlight and > indentation. Additionally, it is able to send GraphQL queries to an > end-point URL. > > Files with the @file{.graphql} and @file{.gql} extensions are > automatically opened with this mode. Done. I missed the description in graphql-mode.el. Thanks again, John From 5dcdcad8869f5c63ed6f86499aaa9e162196d076 Mon Sep 17 00:00:00 2001 From: John Soo Date: Tue, 29 Sep 2020 09:58:05 -0700 Subject: [PATCH] gnu: Add emacs-graphql-mode. * gnu/packages/emacs-xyz.scm (emacs-graphql-mode): New variable. --- gnu/packages/emacs-xyz.scm | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index fca4c22569..2859028809 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -765,6 +765,40 @@ GraphQL is a data query language and runtime designed and used to request and deliver data to mobile and web apps.") (license license:gpl3+))) +(define-public emacs-graphql-mode + ;; No tagged commit + (let ((commit "9bed568ec86242dbe30bdbab324aa0eb2cd9bf08") + (revision "1")) + (package + (name "emacs-graphql-mode") + (version commit) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/davazp/graphql-mode") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0x9y7qq6y0zg8ncamzvk68ccmdyzh7xsj0xs0ykyl20d5wdpplj4")))) + (build-system emacs-build-system) + (home-page "https://github.com/davazp/graphql-mode") + (synopsis "Emacs mode to edit GraphQL schema and queries") + (description + "This package implements a major mode to edit GraphQL schemas and +query. The basic functionality includes: +@itemize +@item Syntax highlight +@item Automatic indentation +Additionally, it is able to +@end itemize +@itemize +@item Sending GraphQL queries to an end-point URL +@end itemize +Files with the @file{.graphql} and @file{.gql} extensions are automatically +opened with this mode.") + (license license:gpl3+)))) + (define-public emacs-ghub (package (name "emacs-ghub") -- 2.28.0