From patchwork Thu Jan 28 13:22:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Patchwork-Id: 26699 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id A29AD27BC1D; Thu, 28 Jan 2021 13:24:27 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id AF0C427BC1C for ; Thu, 28 Jan 2021 13:24:26 +0000 (GMT) Received: from localhost ([::1]:40540 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l57Hd-00076d-Uo for patchwork@mira.cbaines.net; Thu, 28 Jan 2021 08:24:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52754) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l57GI-0006Fu-G5 for guix-patches@gnu.org; Thu, 28 Jan 2021 08:23:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:36028) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l57GI-0006P4-7m for guix-patches@gnu.org; Thu, 28 Jan 2021 08:23:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l57GI-0006jM-20 for guix-patches@gnu.org; Thu, 28 Jan 2021 08:23:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45984] [PATCH 0/5] Fix recursive importers Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 28 Jan 2021 13:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45984 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Received: via spool by 45984-submit@debbugs.gnu.org id=B45984.161184014925811 (code B ref 45984); Thu, 28 Jan 2021 13:23:02 +0000 Received: (at 45984) by debbugs.gnu.org; 28 Jan 2021 13:22:29 +0000 Received: from localhost ([127.0.0.1]:47572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l57Fk-0006iE-V8 for submit@debbugs.gnu.org; Thu, 28 Jan 2021 08:22:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l57Fi-0006hu-Rj for 45984@debbugs.gnu.org; Thu, 28 Jan 2021 08:22:27 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41838) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l57Fc-0006CY-Ve; Thu, 28 Jan 2021 08:22:21 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=58084 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l57FV-0005Fq-Nn; Thu, 28 Jan 2021 08:22:18 -0500 From: Ludovic =?utf-8?q?Court=C3=A8s?= References: <20210119154525.11230-1-zimon.toutoune@gmail.com> <87ft2nwd3b.fsf@gnu.org> <86im7ji90s.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 9 =?utf-8?b?UGx1dmnDtHNl?= an 229 de la =?utf-8?q?R?= =?utf-8?q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 28 Jan 2021 14:22:12 +0100 In-Reply-To: <86im7ji90s.fsf@gmail.com> (zimoun's message of "Wed, 27 Jan 2021 00:16:35 +0100") Message-ID: <87r1m5p56j.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45984@debbugs.gnu.org Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi! zimoun skribis: > On Tue, 26 Jan 2021 at 23:24, Ludovic Courtès wrote: > >>> $ guix import gem do-not-exist -r >>> #f >>> >>> $ ./pre-inst-env guix import gem do-not-exist -r >>> guix import: error: failed to download meta-data for package 'do-not-exist' >> >> I think we do want this error message. Why should we ignore >> non-existent packages when doing ‘-r’? It would think they’re still a >> problem, no? > > Do you mean instead of displaying an error about the query (what the > patch does), displaying which dependent package has failed? Something > along these lines: > > $ ./pre-inst-env guix import gem foo -r > guix import: error: failed to download meta-data for package 'bar' > > > If it is what you have in mind, it needs to really re-think how > ’recursive-import’ works. Not only fixing the corner case. :-) I was looking at hunks like this one: … and I interpreted it as meaning failures would now be silently ignored. But I guess what happens is that #f is interpreted by the caller as a failure, and that’s how we get the “failed to download meta-data” message, right? If so, forget my comment. Sorry for the confusion! Ludo’. (match (fetch-elpa-package name repo) (#false - (raise (condition - (&message - (message (format #false - "couldn't find meta-data for ELPA package `~a'." - name)))))) + (values #f '()))