diff mbox

[bug#50563,[0/2] gnu: GDM: Add Wayland support

Message ID 87r1d71t0t.fsf_-_@gnu.org
State Accepted
Headers show

Commit Message

Mathieu Othacehe Sept. 29, 2021, 12:10 p.m. UTC
> Anything wrong with my integration?

I notied that mutter was complaining that the /tmp/.X11-unix file was
missing the sticky bit when launching the xorg-xwayland binary.

The following patch fixes it for me:

Thanks,

Mathieu

Comments

Josselin Poiret Sept. 29, 2021, 10:10 p.m. UTC | #1
On Wednesday, September 29th, 2021 at 12:10 PM, Mathieu Othacehe <othacehe@gnu.org> wrote:

> > Anything wrong with my integration?
> I notied that mutter was complaining that the /tmp/.X11-unix file was
> missing the sticky bit when launching the xorg-xwayland binary.
> The following patch fixes it for me:
> [snip]
> What do you think about it?
Nice find, looks like this is the perfect fix (maybe this check was introduced in a new `gnome-shell` version).
Thanks for your review and testing!
I tried messing around and everything looked like it was working as it should, with GNOME Settings reporting it was running under Wayland.

As for the ChangeLog style, I'm sorry about it. If I'm reading correctly, I missed adding which files and symbols were changed, am I right?
Mathieu Othacehe Sept. 30, 2021, 9:41 a.m. UTC | #2
Hello,

> Nice find, looks like this is the perfect fix (maybe this check was
> introduced in a new `gnome-shell` version).

Thanks I'll probably write a proper patch then.

> As for the ChangeLog style, I'm sorry about it. If I'm reading
> correctly, I missed adding which files and symbols were changed, am I
> right?

Yeah, that was more for future contributions, I'll get this one fixed
when applying.

Now, I also tried to run Sway (by adding it to the operating-system
packages list). It is proposed in the GDM selection box at login which
is nice, however all I get is a black screen with a frozen mouse
pointer after that.

There's a bunch of errors in /var/log/messages and
/var/log/gdm/greeter.log but I'm not sure if some are relevant here.

Mathieu
Josselin Poiret Sept. 30, 2021, 2:27 p.m. UTC | #3
On Thursday, September 30th, 2021 at 9:41 AM, Mathieu Othacehe <othacehe@gnu.org> wrote:

> Now, I also tried to run Sway (by adding it to the operating-system
> packages list). It is proposed in the GDM selection box at login which
> is nice, however all I get is a black screen with a frozen mouse
> pointer after that.
> There's a bunch of errors in /var/log/messages and
> /var/log/gdm/greeter.log but I'm not sure if some are relevant here.

After looking around, this is because in the `wip-gnome40-wayland` branch the `sway` package has been upgraded to 1.6, introducing a regression with the bochs-drm driver that is used in qemu by default.
If you start qemu with `-vga virtio`, sway starts as usual.
This was reported upstream at https://github.com/swaywm/sway/issues/6244
Mathieu Othacehe Oct. 1, 2021, 7:33 a.m. UTC | #4
Hey,

> After looking around, this is because in the `wip-gnome40-wayland` branch the
> `sway` package has been upgraded to 1.6, introducing a regression with the
> bochs-drm driver that is used in qemu by default.
> If you start qemu with `-vga virtio`, sway starts as usual.
> This was reported upstream at https://github.com/swaywm/sway/issues/6244

Oh, good catch! Running the following command works flawlessly indeed:

--8<---------------cut here---------------start------------->8---
$(./pre-inst-env guix system vm gnu/system/examples/desktop.tmpl --no-grafts --no-offload -v3 -K) -m 4096 -vga virtio
--8<---------------cut here---------------end--------------->8---

Thanks,

Mathieu
diff mbox

Patch

diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
index 64d0e85301..612d548eea 100644
--- a/gnu/services/desktop.scm
+++ b/gnu/services/desktop.scm
@@ -1021,7 +1021,7 @@  rules."
                         (use-modules (guix build utils))
                         (let ((directory "/tmp/.X11-unix"))
                           (mkdir-p directory)
-                          (chmod directory #o777))))))
+                          (chmod directory #o1777))))))

What do you think about it?