From patchwork Tue Jan 31 17:53:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Marshall X-Patchwork-Id: 46549 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id A605427BBE9; Tue, 31 Jan 2023 17:55:21 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 60B8227BBEB for ; Tue, 31 Jan 2023 17:55:20 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMuqc-00065h-He; Tue, 31 Jan 2023 12:55:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMuqW-00065D-Mv for guix-patches@gnu.org; Tue, 31 Jan 2023 12:55:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMuqU-0007af-QQ for guix-patches@gnu.org; Tue, 31 Jan 2023 12:55:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pMuqT-0006lI-QX for guix-patches@gnu.org; Tue, 31 Jan 2023 12:55:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61163] [PATCH] gnu: emacs-pretty-speedbar: New package. Resent-From: Martin Marshall Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 31 Jan 2023 17:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61163 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 61163@debbugs.gnu.org Received: via spool by 61163-submit@debbugs.gnu.org id=B61163.167518765025925 (code B ref 61163); Tue, 31 Jan 2023 17:55:01 +0000 Received: (at 61163) by debbugs.gnu.org; 31 Jan 2023 17:54:10 +0000 Received: from localhost ([127.0.0.1]:54913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMupe-0006k4-F1 for submit@debbugs.gnu.org; Tue, 31 Jan 2023 12:54:10 -0500 Received: from mail-qt1-f179.google.com ([209.85.160.179]:35525) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMupb-0006jq-Hw for 61163@debbugs.gnu.org; Tue, 31 Jan 2023 12:54:08 -0500 Received: by mail-qt1-f179.google.com with SMTP id bb40so6679334qtb.2 for <61163@debbugs.gnu.org>; Tue, 31 Jan 2023 09:54:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martinmarshall-com.20210112.gappssmtp.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=4DaPHM3fVNBLmCYU5fIXhTN2fSbsRrDIiQN6IWt+H6U=; b=MdSW8u/tofjRn1KlWphROC6XYVlXmYhbw/lCCqUUnY/UY8ZZ0NRu3FRMo97EgfwGo6 Tik4aRkOCU8MHbL8omlWZi95TFPdePxzllxnDV6FjQbnvpnub4haDtSdAxcEUBF3LV7g Qm+NqDmpUkptAQHGeppbbn2Zo2srytuxkeCVa8D1cnLR5XUbgo0RG2QY/KW9Wfpev76O lZuHeAWT2Rn59k/1gIGFRT/kBiWjLIBgDkkh6IlptCSmwfmR85bLI7laCqmc4TuNEKfv BmWVzO9NJlw2SvA5w5jzsRYEqYiBos+tZQ0n87zF0Fe6L/orbWTYUB8JLM0eJV2RDC/r n/IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4DaPHM3fVNBLmCYU5fIXhTN2fSbsRrDIiQN6IWt+H6U=; b=FlKFQBd6AuoQXK8tGIPbZdtqmy6aA5H1nBUwVSIszTE6OL7WFK7ovxRg9oFvCGmHgm Vnsxd0BaZwdB+wpAqbm9RgW0Hg781eE0DJHsEMDnWaYhp5m4iGv3gkT4jdDAgLbvxaqM OuLyeFYZy0YfxQGmefAKzTDu/xDaBDZS8BXblVoXdPE5xB321I9UYiI9tOIitmnyJmtT egMi8Ye+vChjqAr5IXfChebT63+B5K41SGW/a38EB5vqy5xbVt66McHUWqMSSqpuf/jx xApOJqTzLWeSYPXDbJB23W8veWs1yUutqkGHBIcWyQLWdBNSrJxItzZeTf/fut2VVytv UUug== X-Gm-Message-State: AFqh2kqpyZ8O8UIhijxXBWqlyuEulSiGzD5uvcl90cWn/+xImgvvY4cl 4YbApimvOYbWVEAEq2Hp+15WJGj+rw5Dj7AK X-Google-Smtp-Source: AMrXdXuW5ekRNISrAGFq/2dHS7+1bOmGoUtcKv8pyp9u26fBY3R6GeZQoriS87H/G6TmfXtBred+cg== X-Received: by 2002:ac8:7cb2:0:b0:3a8:1ba:b8ab with SMTP id z18-20020ac87cb2000000b003a801bab8abmr67991820qtv.6.1675187641315; Tue, 31 Jan 2023 09:54:01 -0800 (PST) Received: from vader (68-252-220-225.lightspeed.tukrga.sbcglobal.net. [68.252.220.225]) by smtp.gmail.com with ESMTPSA id s39-20020a05622a1aa700b003a7e38055c9sm10268798qtc.63.2023.01.31.09.54.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Jan 2023 09:54:00 -0800 (PST) From: Martin Marshall In-Reply-To: <87fsbq2411.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Tue, 31 Jan 2023 15:05:14 +0100") References: <03b4f86e0640db7f8befc96e37a4793267886b85.1675060565.git.law@martinmarshall.com> <87fsbq2411.fsf@nicolasgoaziou.fr> Date: Tue, 31 Jan 2023 12:53:59 -0500 Message-ID: <87r0vak2tk.fsf@martinmarshall.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Nicolas Goaziou writes: >> + (propagated-inputs (list font-awesome)) > > It seems the project requires Font Awesome 6, but Guix only provides > version 4. Is it an issue? I don't think so. While the default value of the `pretty-speedbar-font' user-setting is "Font Awesome 6 Free Solid", the setting is customizable, and any icon font may be used with the package. Even with the default value of `pretty-speedbar-font' unchanged, my system automatically uses the Font Awesome 4 fonts provided by Guix's font-awesome package. > It may be worth considering updating font-awesome in Guix first, but > I don't know what its freedom status is nowadays (as a data point, > Parabola provides it, tho). There is a comment to its package definition stating this: ;; XXX The build scripts of version 5 are not freely licensed and ;; so we have to stick with version 4 for now: ;; The linked discussion from 2018 concluded with all participants agreeing that distribution of version 5 or higher would violate the Gnu FSDG. I reviewed the Font Awesome GitHub Issues, and it seems they remain unwilling to change the licensing terms for the build scripts, the matter having been raised as late as March 2022. There is a fork of Font Awesome whose stated goals are "to continue building the amazing resource in a fully free, libre and open-source fashion" (https://github.com/ForkAwesome/Fork-Awesome). I haven't used it though. >> + (description >> + "Generate and implement appealing SVG icons for the Emacs >> Speedbar. > > This is not a complete sentence. > > Could you send an updated patch? Thank you for this and the other feedback provided. I've rewritten the description along with the other suggested changes. An updated patch is attached. Warm regards,