From patchwork Thu Apr 11 19:50:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vagrant Cascadian X-Patchwork-Id: 62933 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 4946127BBE9; Thu, 11 Apr 2024 20:52:10 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 9458027BBE2 for ; Thu, 11 Apr 2024 20:52:09 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rv0Sg-0000kt-CY; Thu, 11 Apr 2024 15:51:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rv0Sf-0000ka-HS for guix-patches@gnu.org; Thu, 11 Apr 2024 15:51:53 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rv0Sf-0004IQ-8T for guix-patches@gnu.org; Thu, 11 Apr 2024 15:51:53 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rv0So-0007dv-Jk for guix-patches@gnu.org; Thu, 11 Apr 2024 15:52:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70344] Increase verbosity of diffoscope test suite Resent-From: Vagrant Cascadian Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 11 Apr 2024 19:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 70344 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 70344@debbugs.gnu.org Cc: Wilko Meyer , Christopher Baines X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.171286509129106 (code B ref -1); Thu, 11 Apr 2024 19:52:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Apr 2024 19:51:31 +0000 Received: from localhost ([127.0.0.1]:57375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rv0SI-0007ZD-52 for submit@debbugs.gnu.org; Thu, 11 Apr 2024 15:51:31 -0400 Received: from lists.gnu.org ([2001:470:142::17]:59366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rv0SF-0007XY-37 for submit@debbugs.gnu.org; Thu, 11 Apr 2024 15:51:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rv0Rx-0000Tb-0j for guix-patches@gnu.org; Thu, 11 Apr 2024 15:51:09 -0400 Received: from cascadia.aikidev.net ([173.255.214.101]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rv0Ru-00045x-BD for guix-patches@gnu.org; Thu, 11 Apr 2024 15:51:08 -0400 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50]) (Authenticated sender: vagrant@aikidev.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 2790E1AE55; Thu, 11 Apr 2024 12:50:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=reproducible-builds.org; s=1.vagrant; t=1712865058; bh=DaKKNeoHrtzVj9MeXdeiHI7x+iiUvsPIHf4ozf/+v+M=; h=From:To:Cc:Subject:Date:From; b=renv0u89cnOvSZHvkDFXdHuonR/b3YOrs8PTBrO4mfTcDJH/iyRo++z/8/SyYK44S 7JZQkxkxw96nk+Pn+dDy+drB4qlIJ63XwOUJ18rshAAympMNApDRkpnqyXTHMQ77UL BMMFRSVVKFQUY8UK+4Wz0OsEsIx84d5PYWSl2mTRaMNAvO8j6DR8BLKBSQ4xwzav+q ZYn4E3/IT6dIcIB8O2BTrjJEGz0pZrWUoLf7WUxVvzP/AROqXr4PKM32Wq3YHnN//5 mPh3THBqjSv77EqNPZnOhFrLlf2mUwQskxyL2Y0G1Z7ieRqouBNJeuFGBEd/qc04pb cB1RYQc7KLbgA== From: Vagrant Cascadian Date: Thu, 11 Apr 2024 12:50:54 -0700 Message-ID: <87r0fb3cgx.fsf@wireframe> MIME-Version: 1.0 Received-SPF: pass client-ip=173.255.214.101; envelope-from=vagrant@reproducible-builds.org; helo=cascadia.aikidev.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches The attached patch increases the verbosity of the test suite, showing each test on it's own line and provides a useful summary, often including a reason why skipped tests were skipped. This can be useful to help find additional packages to add for broader test coverage, inspired by discussion in https://issues.guix.gnu.org/70293 This also reveals that the conditional to add "enjarify" to native-inputs on x86_64 is not working correctly... and plausibly could reveal other similar issues with other missing native-inputs. live well, vagrant From b1475226dc655986e97445dca889d4b0c362215c Mon Sep 17 00:00:00 2001 From: Vagrant Cascadian Date: Thu, 11 Apr 2024 12:40:19 -0700 Subject: [PATCH] gnu: diffoscope: Increase test verbosity. * gnu/packages/diffoscope.scm (diffoscope)[phases]: Replace 'check. --- gnu/packages/diffoscope.scm | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/gnu/packages/diffoscope.scm b/gnu/packages/diffoscope.scm index 3db52e5008..8106a6d258 100644 --- a/gnu/packages/diffoscope.scm +++ b/gnu/packages/diffoscope.scm @@ -139,6 +139,11 @@ (define (bin command) (lambda _ ;; This requires /sbin to be in $PATH. (delete-file "tests/test_tools.py"))) + (replace 'check + (lambda* (#:key tests? #:allow-other-keys) + (when tests? + ;; Increase verbosity of tests and provide a summary + (invoke "pytest" "-vv" "-r" "sxX")))) (add-after 'install 'install-man-page (lambda* (#:key outputs #:allow-other-keys) (let* ((out (assoc-ref outputs "out")) -- 2.39.2