diff mbox series

[bug#78199] Update lcrq to 0.2.4

Message ID 87r018rp0w.fsf@wireframe
State New
Headers
Series [bug#78199] Update lcrq to 0.2.4 |

Commit Message

Vagrant Cascadian May 1, 2025, 9:37 p.m. UTC 
The attached patch updates lcrq to 0.2.4.

It fixes an issue where packets are sent with zero data, as confusing as
that may be, it is enjoyably explained by upstream:

  https://chaos.social/@dentangle/114397068112541120

The dependents lcsync and librecast all build nicely.

  ./pre-inst-env guix build --no-grafts --dependents lcrq
  guix build: computing dependents of package lcrq@0.2.4...
  /gnu/store/bg0acil25iqipmznll1795k4hqxg25bm-lcrq-0.2.4
  /gnu/store/fqa2524s8yh7wn46sasb7gx0v9w690di-librecast-0.10.0
  /gnu/store/6s5fjiwh733297m42xv0sqqrrl84dwwj-lcsync-0.3.2

live well,
  vagrant

Comments

Nicolas Graves May 5, 2025, 12:19 p.m. UTC | #1 
user guix
usertag 78199 + reviewed-looks-good
thanks

Guix QA review form submission:
LGTM. There's this lint: 
../gnu/packages/networking.scm:313:15: lcrq@0.2.4: permanent redirect from https://librecast.net/lcrq.html to https://www.librecast.net/lcrq.html
But IMHO, it shouldn't block this commit.

Items marked as checked: Lint warnings, Package builds, Commit messages
Andreas Enge May 5, 2025, 1:25 p.m. UTC | #2 
Hello,

thanks for the patch and the review. I have pushed on Vagrant's behalf
with an updated homepage and corrected commit message. Something is off
with your use of "git send-email": Did you write your explanatory
message above instead of below the three dashes?

Andreas
Vagrant Cascadian May 5, 2025, 4:24 p.m. UTC | #3 
On 2025-05-05, Andreas Enge wrote:
> thanks for the patch and the review. I have pushed on Vagrant's behalf
> with an updated homepage and corrected commit message.

Thanks! (although I did not recieve the review email, though I've looked
it up now)

I had brought the URL issue up with upstream a while back, and they did
intend to fix the URLs to not redirect, so we may have to revert that
again someday... but no big deal either way. :)


> Something is off with your use of "git send-email": Did you write your
> explanatory message above instead of below the three dashes?

I just used "git format-patch" and attached the resulting patch. This is
slightly outside the recommended flow, but allows me to sign my patch
submissions with openpgp...

live well,
  vagrant
Vagrant Cascadian May 6, 2025, 8:21 a.m. UTC | #4 
On 2025-05-05, Vagrant Cascadian wrote:
> On 2025-05-05, Andreas Enge wrote:
>> thanks for the patch and the review. I have pushed on Vagrant's behalf
>> with an updated homepage and corrected commit message.
>
> Thanks! (although I did not recieve the review email, though I've looked
> it up now)
>
> I had brought the URL issue up with upstream a while back, and they did
> intend to fix the URLs to not redirect, so we may have to revert that
> again someday... but no big deal either way. :)

AAAAAAnd... upstream went and fixed it today, so now:

  $ guix lint --checkers=home-page lcrq librecast lcsync
  gnu/packages/networking.scm:313:15: lcrq@0.2.4: permanent redirect from https://www.librecast.net/lcrq.html to https://librecast.net/lcrq.html

:)

live well,
  vagrant
Andreas Enge May 6, 2025, 8:33 a.m. UTC | #5 
Am Tue, May 06, 2025 at 01:21:05AM -0700 schrieb Vagrant Cascadian:
> AAAAAAnd... upstream went and fixed it today, so now:
>   $ guix lint --checkers=home-page lcrq librecast lcsync
>   gnu/packages/networking.scm:313:15: lcrq@0.2.4: permanent redirect from https://www.librecast.net/lcrq.html to https://librecast.net/lcrq.html
> :)

Ah, we are going in circles - or spirals? ;-)

Andreas
Vagrant Cascadian May 8, 2025, 5:59 a.m. UTC | #6 
On 2025-05-06, Andreas Enge wrote:
> Am Tue, May 06, 2025 at 01:21:05AM -0700 schrieb Vagrant Cascadian:
>> AAAAAAnd... upstream went and fixed it today, so now:
>>   $ guix lint --checkers=home-page lcrq librecast lcsync
>>   gnu/packages/networking.scm:313:15: lcrq@0.2.4: permanent redirect from https://www.librecast.net/lcrq.html to https://librecast.net/lcrq.html
>> :)
>
> Ah, we are going in circles - or spirals? ;-)

When I brought it to upstream's attention, they intended to fix it, so I
ignored the guix lint home-page issue on previous version, figuring
upstream would fix it, and this bug report triggered the impetus to
actually fix it upstream... reintroducing this guix lint issue for lcrq
(but notably fixing it for the other librecast project packages,
librecast and lcsync!).

This is where guix's weak maintainership model sometimes goes slightly
and mildly amiss, as I have a working relationship with upstream so knew
to put off "fixing" the guix lint issue. :)

I have pushed the fix to the fix as
01ca654387c64265b310f2887d884cd7ec7c4f0a.

No serious harm done, just a bit of minor comedy. :)

live well,
  vagrant
diff mbox series

Patch

From 50e51c4a743e548535c04b1abe3e283dfab8b7b8 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@debian.org>
Date: Thu, 1 May 2025 14:18:23 -0700
Subject: [PATCH] gnu: lcrq: Update to 0.2.4.

* gnu/packages/networking.scm (lcrq): Update to 0.2.4.
---
 gnu/packages/networking.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 2a27474826..0d811f1c78 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -281,7 +281,7 @@  (define-public axel
 (define-public lcrq
   (package
     (name "lcrq")
-    (version "0.2.3")
+    (version "0.2.4")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -290,7 +290,7 @@  (define-public lcrq
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "13nnx8izfzcy2k6y5njc8p9b196hpn2v90pmiysbiwp8qwnzczih"))))
+                "1d2mk3ii189462dmkksjsaqybj7cizn9vm9c8plml881brlz8a2n"))))
     (build-system gnu-build-system)
     (arguments
      (list

base-commit: 43410355473ef38733f5ea869aa8f11a09db1b06
-- 
2.39.5