Message ID | 87r018rp0w.fsf@wireframe |
---|---|
State | New |
Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 6EAFD27BC4B; Thu, 1 May 2025 22:38:22 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=unavailable version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 6534527BC49 for <patchwork@mira.cbaines.net>; Thu, 1 May 2025 22:38:22 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1uAbbZ-0005Mp-Oe; Thu, 01 May 2025 17:38:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1uAbbX-0005MD-T2 for guix-patches@gnu.org; Thu, 01 May 2025 17:38:04 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1uAbbX-0005JF-HX for guix-patches@gnu.org; Thu, 01 May 2025 17:38:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=iWEQKv0/UnNM6FkTm4FGwi3bF1hHnGZcgwOLOoChefU=; b=hZ2bSegESC3MlUW0pT7PxdPsMg5GLfvkNgs8t0x0jK78Uu1f9tOYKV5fZ3ibiPZD6J/21RRNVOP11d2ntD8zATDvhkOrLSkPF7eV/e8SwV5/ZJEPnneP+ybQLwbr7RbSGFD+kitZffGqGsHX3a/9SM4g4m9ZxIsMK1ElFKkWGEfDY+987SFMIQiumCTk8NHoR7PgIc0iob1AbUbJhoZ3Dl8iX4TEza97ZA6s2kmqOQ6aMXbGcn/q3gtpyg8MuwUtvRLuLTxLl5b4GVQZfjJHjE/GCg8kvMrJ3+uuuHpk1STnyA7eTM1u4cxIGZyJXSmMx2u7x1c4duaHQWuW+xV5gg==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1uAbbW-0004hA-FK for guix-patches@gnu.org; Thu, 01 May 2025 17:38:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#78199] Update lcrq to 0.2.4 Resent-From: Vagrant Cascadian <vagrant@debian.org> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 01 May 2025 21:38:02 +0000 Resent-Message-ID: <handler.78199.B.174613546017997@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 78199 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 78199@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.174613546017997 (code B ref -1); Thu, 01 May 2025 21:38:02 +0000 Received: (at submit) by debbugs.gnu.org; 1 May 2025 21:37:40 +0000 Received: from localhost ([127.0.0.1]:53828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1uAbbA-0004gC-3s for submit@debbugs.gnu.org; Thu, 01 May 2025 17:37:40 -0400 Received: from lists.gnu.org ([2001:470:142::17]:38430) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <vagrant@debian.org>) id 1uAbb8-0004fv-7w for submit@debbugs.gnu.org; Thu, 01 May 2025 17:37:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <vagrant@debian.org>) id 1uAbb0-0005FW-6c for guix-patches@gnu.org; Thu, 01 May 2025 17:37:30 -0400 Received: from cascadia.aikidev.net ([173.255.214.101]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <vagrant@debian.org>) id 1uAbax-0005C1-D2 for guix-patches@gnu.org; Thu, 01 May 2025 17:37:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1746135444; bh=sm5ai3vAKp6Xdwq721YUKY4nnE/Kleq1s24C8JoAWQA=; h=From:To:Subject:Date:From; b=lM+SqG7P5HcFXxCoUbnIUTyXEvy94spxv9hDSJK6f9hMrdMlNPgXEWlgjuklOylqN /UNdZnM6nlWRaBIEF5REN39zu9RV6/gTajjJdmLHPjvePo0vGUOq41AGVEHDPYquyK Zt2k5sBGecg5XETtZx1rO0ppzXUYFR4kqNMc8dL1EuR28afPOboIyDWmQtjjIkuj/4 6Fj3ynWVvcyK2wim7I1bhPSPRDMxvIZCZ+SQhfnpQPYRGQe/R1q13XN+Bm0wB/ll9h r7JOwqDjrd9yxTuKa5lzclZkb4TzYXjVVkqIuSbsRj9ztWX61OtwxVEaLVrIkc9iUx PQDuj7bzsJe0A== Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50]) by cascadia.aikidev.net (Postfix) with ESMTPSA id 81E5E55E; Thu, 1 May 2025 14:37:24 -0700 (PDT) From: Vagrant Cascadian <vagrant@debian.org> Date: Thu, 01 May 2025 14:37:19 -0700 Message-ID: <87r018rp0w.fsf@wireframe> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: none client-ip=173.255.214.101; envelope-from=vagrant@debian.org; helo=cascadia.aikidev.net X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.644, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
Series |
[bug#78199] Update lcrq to 0.2.4
|
|
Commit Message
Vagrant Cascadian
May 1, 2025, 9:37 p.m. UTC
The attached patch updates lcrq to 0.2.4. It fixes an issue where packets are sent with zero data, as confusing as that may be, it is enjoyably explained by upstream: https://chaos.social/@dentangle/114397068112541120 The dependents lcsync and librecast all build nicely. ./pre-inst-env guix build --no-grafts --dependents lcrq guix build: computing dependents of package lcrq@0.2.4... /gnu/store/bg0acil25iqipmznll1795k4hqxg25bm-lcrq-0.2.4 /gnu/store/fqa2524s8yh7wn46sasb7gx0v9w690di-librecast-0.10.0 /gnu/store/6s5fjiwh733297m42xv0sqqrrl84dwwj-lcsync-0.3.2 live well, vagrant
Comments
user guix usertag 78199 + reviewed-looks-good thanks Guix QA review form submission: LGTM. There's this lint: ../gnu/packages/networking.scm:313:15: lcrq@0.2.4: permanent redirect from https://librecast.net/lcrq.html to https://www.librecast.net/lcrq.html But IMHO, it shouldn't block this commit. Items marked as checked: Lint warnings, Package builds, Commit messages
Hello, thanks for the patch and the review. I have pushed on Vagrant's behalf with an updated homepage and corrected commit message. Something is off with your use of "git send-email": Did you write your explanatory message above instead of below the three dashes? Andreas
On 2025-05-05, Andreas Enge wrote: > thanks for the patch and the review. I have pushed on Vagrant's behalf > with an updated homepage and corrected commit message. Thanks! (although I did not recieve the review email, though I've looked it up now) I had brought the URL issue up with upstream a while back, and they did intend to fix the URLs to not redirect, so we may have to revert that again someday... but no big deal either way. :) > Something is off with your use of "git send-email": Did you write your > explanatory message above instead of below the three dashes? I just used "git format-patch" and attached the resulting patch. This is slightly outside the recommended flow, but allows me to sign my patch submissions with openpgp... live well, vagrant
On 2025-05-05, Vagrant Cascadian wrote: > On 2025-05-05, Andreas Enge wrote: >> thanks for the patch and the review. I have pushed on Vagrant's behalf >> with an updated homepage and corrected commit message. > > Thanks! (although I did not recieve the review email, though I've looked > it up now) > > I had brought the URL issue up with upstream a while back, and they did > intend to fix the URLs to not redirect, so we may have to revert that > again someday... but no big deal either way. :) AAAAAAnd... upstream went and fixed it today, so now: $ guix lint --checkers=home-page lcrq librecast lcsync gnu/packages/networking.scm:313:15: lcrq@0.2.4: permanent redirect from https://www.librecast.net/lcrq.html to https://librecast.net/lcrq.html :) live well, vagrant
Am Tue, May 06, 2025 at 01:21:05AM -0700 schrieb Vagrant Cascadian: > AAAAAAnd... upstream went and fixed it today, so now: > $ guix lint --checkers=home-page lcrq librecast lcsync > gnu/packages/networking.scm:313:15: lcrq@0.2.4: permanent redirect from https://www.librecast.net/lcrq.html to https://librecast.net/lcrq.html > :) Ah, we are going in circles - or spirals? ;-) Andreas
On 2025-05-06, Andreas Enge wrote: > Am Tue, May 06, 2025 at 01:21:05AM -0700 schrieb Vagrant Cascadian: >> AAAAAAnd... upstream went and fixed it today, so now: >> $ guix lint --checkers=home-page lcrq librecast lcsync >> gnu/packages/networking.scm:313:15: lcrq@0.2.4: permanent redirect from https://www.librecast.net/lcrq.html to https://librecast.net/lcrq.html >> :) > > Ah, we are going in circles - or spirals? ;-) When I brought it to upstream's attention, they intended to fix it, so I ignored the guix lint home-page issue on previous version, figuring upstream would fix it, and this bug report triggered the impetus to actually fix it upstream... reintroducing this guix lint issue for lcrq (but notably fixing it for the other librecast project packages, librecast and lcsync!). This is where guix's weak maintainership model sometimes goes slightly and mildly amiss, as I have a working relationship with upstream so knew to put off "fixing" the guix lint issue. :) I have pushed the fix to the fix as 01ca654387c64265b310f2887d884cd7ec7c4f0a. No serious harm done, just a bit of minor comedy. :) live well, vagrant
From 50e51c4a743e548535c04b1abe3e283dfab8b7b8 Mon Sep 17 00:00:00 2001 From: Vagrant Cascadian <vagrant@debian.org> Date: Thu, 1 May 2025 14:18:23 -0700 Subject: [PATCH] gnu: lcrq: Update to 0.2.4. * gnu/packages/networking.scm (lcrq): Update to 0.2.4. --- gnu/packages/networking.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm index 2a27474826..0d811f1c78 100644 --- a/gnu/packages/networking.scm +++ b/gnu/packages/networking.scm @@ -281,7 +281,7 @@ (define-public axel (define-public lcrq (package (name "lcrq") - (version "0.2.3") + (version "0.2.4") (source (origin (method git-fetch) (uri (git-reference @@ -290,7 +290,7 @@ (define-public lcrq (file-name (git-file-name name version)) (sha256 (base32 - "13nnx8izfzcy2k6y5njc8p9b196hpn2v90pmiysbiwp8qwnzczih")))) + "1d2mk3ii189462dmkksjsaqybj7cizn9vm9c8plml881brlz8a2n")))) (build-system gnu-build-system) (arguments (list base-commit: 43410355473ef38733f5ea869aa8f11a09db1b06 -- 2.39.5