Message ID | 87pm90bzva.fsf_-_@gnu.org |
---|---|
State | New |
Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id D875116FA7; Wed, 22 Mar 2023 14:55:28 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 1D59816F83 for <patchwork@mira.cbaines.net>; Wed, 22 Mar 2023 14:55:25 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1pezrn-0004zn-IO; Wed, 22 Mar 2023 10:55:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1pezri-0004zV-Pg for guix-patches@gnu.org; Wed, 22 Mar 2023 10:55:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1pezri-0000yQ-Fv for guix-patches@gnu.org; Wed, 22 Mar 2023 10:55:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1pezri-0005j1-9W for guix-patches@gnu.org; Wed, 22 Mar 2023 10:55:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62307] [PATCH core-updates 00/15] Update Hurd and fix build failures Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= <ludo@gnu.org> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 22 Mar 2023 14:55:02 +0000 Resent-Message-ID: <handler.62307.B62307.167949688321973@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62307 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Josselin Poiret <dev@jpoiret.xyz> Cc: 62307@debbugs.gnu.org Received: via spool by 62307-submit@debbugs.gnu.org id=B62307.167949688321973 (code B ref 62307); Wed, 22 Mar 2023 14:55:02 +0000 Received: (at 62307) by debbugs.gnu.org; 22 Mar 2023 14:54:43 +0000 Received: from localhost ([127.0.0.1]:36344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1pezrP-0005iK-Bn for submit@debbugs.gnu.org; Wed, 22 Mar 2023 10:54:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@gnu.org>) id 1pezrN-0005i5-CS for 62307@debbugs.gnu.org; Wed, 22 Mar 2023 10:54:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@gnu.org>) id 1pezrI-0000rI-1Z; Wed, 22 Mar 2023 10:54:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=aZZVpY01MbSkygzJWARd0gZfs3VCP/6S/KDQYwxLUc0=; b=YoFW/4ySNlmTk/2XGb4d I+DF9DhjrojxArnbu/GqxfluIlRS9EDb56OOWI985ehfAgPHJnqDAzq7P/2/co/wfAkCaDAHMwGzn SMpnet6XRsUzDnnHWgfKTLswvdNhG/FdjB7wCZcZNx+NkN7e+mMHBujLQibbGiC5WJDMBo5o9N41x dOi2S98PE+eVJBlvXkfmH0z1p1oao61tmHXD4rjEvqqz5qlshIHFQOMWGWw2i/OLGzP7V8OP8PPXd 7aVoq1JFUVJUiZTPrFhhuzyBvdZGgHQIKlgVsFtnDNQFKlHtwWYgHvRk29rhhAGIt2QyFrIZWAL12 FGFOXKayGYoucg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@gnu.org>) id 1pezrH-0000pP-Gh; Wed, 22 Mar 2023 10:54:35 -0400 From: Ludovic =?utf-8?q?Court=C3=A8s?= <ludo@gnu.org> References: <cover.1679349992.git.dev@jpoiret.xyz> <6a027350c8639d0c52cdda781abb9f7d304f64ed.1679349992.git.dev@jpoiret.xyz> Date: Wed, 22 Mar 2023 15:54:33 +0100 In-Reply-To: <6a027350c8639d0c52cdda781abb9f7d304f64ed.1679349992.git.dev@jpoiret.xyz> (Josselin Poiret's message of "Mon, 20 Mar 2023 23:10:36 +0100") Message-ID: <87pm90bzva.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
Commit Message
Ludovic Courtès
March 22, 2023, 2:54 p.m. UTC
Hi, Josselin Poiret <dev@jpoiret.xyz> skribis: > * gnu/packages/base.scm (glibc/fix-for-hurd-cross): New variable. > (glibc/hurd-headers): Inherit it. > * gnu/packages/patches/glibc-hurd-add-freestanding-for-configure.patch: > * gnu/packages/patches/glibc-hurd-add-freestanding-to-cppflags.patch: New files > * gnu/local.mk (dist_patch_DATA): Register patches. I’d like to keep this approach (defining a package variant and carrying Hurd-specific patches) as a last resort. If I’m not mistaken, we should be able to achieve the same result with a patch like this one (untested): How does that sound? Thanks, Ludo’.
Comments
Hello Guix! I have good news and bad news. The bad news is that an image built with: ./pre-inst-env guix system image -t hurd-qcow2 \ gnu/system/examples/bare-hurd.tmpl fails to boot: it hangs right at: (system* "/hurd/mach-defpager") Basically, ‘system*’ doesn’t work at the early-boot REPL. This was not surprising given <https://issues.guix.gnu.org/61095>, but it is now that I’ve fixed it. I’ve also confirmed that the same binary works on a “current” (master) childhurd, which means it could be something with the new ‘exec’ server or anything in between. I think we can keep investigating that separately. The good news is that ‘--target=i586-pc-gnu’ is back to life. :-) Compared to Josselin’s initial patch set, I made the following changes: • MiG is built from a tarball (which I’ll upload to ftp.gnu.org/gnu/guix/mirror after review); building from Git introduces a circular dependency in native i586-gnu builds, hence the tarball. • The glibc ‘configure’ issue is worked around in a less invasive way as I proposed earlier. • The GCC/libstdc++ patch application is likewise simplified, without introducing a world rebuild. • ‘system*’ in Guile is fixed. • ‘linux-pam’ builds again on GNU/Hurd. If there are no objections I’d like to push that soonish so we can move on with the branch. Thoughts? Ludo’. Josselin Poiret (12): gnu: gcc@11: Patch libpthread on GNU/Hurd. gnu: cross-base: Factor out cross-mig. gnu: cross-base: Add cross arguments to hurd derivatives. gnu: cross-base: Removed useless inputs to xhurd-core-headers. gnu: mig: Update to 1.8+git20220827. gnu: gnumach: Update to 1.8+git20220827. gnu: hurd: Update to 3ff7053. gnu: hurd: Remove useless glibc/hurd-headers input. gnu: gnumach, hurd-headers, hurd: Switch to using cross-mig. gnu: hurd: Update DDE and use libdde_linux26. gnu: mig/32-bit: Remove. system: hurd: Use shepherd-0.8 in the package list. Ludovic Courtès (8): gnu: glibc: Work around broken GNU Mach header detection. gnu: cross-base: Use gexps for 'cross-gcc-arguments'. gnu: linux-pam: Switch to gexps. gnu: linux-pam: Allow compilation on GNU/Hurd. gnu: guile-static: Switch to gexps. gnu: guile: Switch to gexps. gnu: guile-readline: Switch to gexps. gnu: guile: Fix 'posix_spawn' usage for GNU/Hurd. gnu/local.mk | 9 +- gnu/packages/base.scm | 19 +- gnu/packages/cross-base.scm | 217 +++-- gnu/packages/gcc.scm | 13 +- gnu/packages/guile.scm | 190 ++-- gnu/packages/hurd.scm | 307 +++--- gnu/packages/linux.scm | 51 +- gnu/packages/make-bootstrap.scm | 58 +- .../gcc-11-libstdc++-hurd-libpthread.patch | 62 ++ ...ng-const_mach_port_name_array_t-type.patch | 32 + .../patches/guile-hurd-posix-spawn.patch | 44 + ...rd-add-without-rump-configure-option.patch | 82 ++ gnu/packages/patches/hurd-cross.patch | 33 - ...f-read-write-and-readables-methods-2.patch | 155 +++ ...-of-read-write-and-readables-methods.patch | 891 ++++++++++++++++++ gnu/packages/patches/hurd-xattr.patch | 53 -- .../patches/mig-cpu.h-generation.patch | 16 + gnu/system/hurd.scm | 2 +- 18 files changed, 1773 insertions(+), 461 deletions(-) create mode 100644 gnu/packages/patches/gcc-11-libstdc++-hurd-libpthread.patch create mode 100644 gnu/packages/patches/gnumach-add-missing-const_mach_port_name_array_t-type.patch create mode 100644 gnu/packages/patches/guile-hurd-posix-spawn.patch create mode 100644 gnu/packages/patches/hurd-add-without-rump-configure-option.patch delete mode 100644 gnu/packages/patches/hurd-cross.patch create mode 100644 gnu/packages/patches/hurd-fix-types-of-read-write-and-readables-methods-2.patch create mode 100644 gnu/packages/patches/hurd-fix-types-of-read-write-and-readables-methods.patch delete mode 100644 gnu/packages/patches/hurd-xattr.patch create mode 100644 gnu/packages/patches/mig-cpu.h-generation.patch base-commit: 68793b702e4295d011c89e72826fd15ce18e0b95
Hi Ludo, Ludovic Courtès <ludo@gnu.org> writes: > Hello Guix! > > I have good news and bad news. > > The bad news is that an image built with: > > ./pre-inst-env guix system image -t hurd-qcow2 \ > gnu/system/examples/bare-hurd.tmpl > > fails to boot: it hangs right at: > > (system* "/hurd/mach-defpager") > > Basically, ‘system*’ doesn’t work at the early-boot REPL. This > was not surprising given <https://issues.guix.gnu.org/61095>, but > it is now that I’ve fixed it. I’ve also confirmed that the same > binary works on a “current” (master) childhurd, which means it > could be something with the new ‘exec’ server or anything in between. > I think we can keep investigating that separately. > > The good news is that ‘--target=i586-pc-gnu’ is back to life. :-) > Compared to Josselin’s initial patch set, I made the following changes: > > • MiG is built from a tarball (which I’ll upload to > ftp.gnu.org/gnu/guix/mirror after review); building from > Git introduces a circular dependency in native i586-gnu builds, > hence the tarball. > > • The glibc ‘configure’ issue is worked around in a less invasive > way as I proposed earlier. > > • The GCC/libstdc++ patch application is likewise simplified, > without introducing a world rebuild. > > • ‘system*’ in Guile is fixed. > > • ‘linux-pam’ builds again on GNU/Hurd. > > If there are no objections I’d like to push that soonish so we can > move on with the branch. > > Thoughts? Just had a look and built locally. LGTM! Great work (even though it's still unfinished, but that's for another day). Best,
Hi Josselin, Josselin Poiret <dev@jpoiret.xyz> skribis: > Just had a look and built locally. LGTM! Great work (even though it's > still unfinished, but that's for another day). Thanks for testing! Pushed as 14cd517e0cb8829b06b5a49f91c762c4a0e52eb5. I uploaded the MiG tarball to ftp.gnu.org/gnu/guix and adjusted the URL accordingly. Ludo’.
diff --git a/gnu/packages/cross-base.scm b/gnu/packages/cross-base.scm index 2959616af6..9db12bcf9f 100644 --- a/gnu/packages/cross-base.scm +++ b/gnu/packages/cross-base.scm @@ -577,7 +577,20 @@ (define* (cross-libc* target ((#:configure-flags flags) `(cons ,(string-append "--host=" target) ,(if (target-hurd? target) - `(cons "--disable-werror" ,flags) + `(cons* "--disable-werror" + + ;; 'configure' in glibc 2.35 omits to pass + ;; '-ffreestanding' when detecting Mach + ;; headers. This is fixed in glibc commits + ;; 8b8c768e3c701ed1993789bb46acb8a12c7a93df + ;; and + ;; 7685630b98ca2a3f5de86eadf130993e6cf998a0; + ;; as a workaround, bypass those tests. + "ac_cv_header_mach_mach_types_defs=yes" + "ac_cv_header_mach_mach_types_h=yes" + "ac_cv_header_mach_machine_ndr_def_h=yes" + "libc_cv_mach_task_creation_time=yes" + ,flags) flags))) ((#:phases phases) `(modify-phases ,phases