Message ID | 87plfmnneq.fsf@gnu.org |
---|---|
State | New |
Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 985F027BC4A; Mon, 2 Jun 2025 17:11:35 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=unavailable version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 61A2F27BC49 for <patchwork@mira.cbaines.net>; Mon, 2 Jun 2025 17:11:35 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1uM7kq-00036E-Id; Mon, 02 Jun 2025 12:11:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1uM7kf-00034z-Ss for guix-patches@gnu.org; Mon, 02 Jun 2025 12:11:06 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1uM7kc-0007A1-TK for guix-patches@gnu.org; Mon, 02 Jun 2025 12:11:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=hy/kTwfkSwjQDYDthedqGD3lib9VUiGkLfU7mz503B8=; b=uGPsB8Jke1wlH+EwZY4kaNCeEaqnYRsu2R4Fy2zpdwSKpGMhToCgnSq4RbK4xzCPi9BOZR1bfypqWGxVyFRmz3EuFdcCkDAFs8qPV9X9VUPFA3Oszo82GKSbGzn7QbMKBnL9iULsqoMK9hzh7HvsJ9+PS+LvdYkcNfnuECG5vzin5yr50HRdQE8dWMOCUiEM3hnMdoIrGw+jueMwH0TNxs8MlMnx0UORdiDt7g3Bp8DUZfE5i3/6iSoB+d/2lycmPCAT63zNBGTFfPMapVdJ/IDTX6FWf4poBhKI4iXp7gGgLw/mEAORlUuGuelGLvmRyD5xwEwds4qcYy24f6euZw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1uM7kc-0006gW-PC for guix-patches@gnu.org; Mon, 02 Jun 2025 12:11:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#75518] Motif build failure Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= <ludo@gnu.org> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 02 Jun 2025 16:11:02 +0000 Resent-Message-ID: <handler.75518.B75518.174888061625202@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75518 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Rutherther <rutherther@ditigal.xyz> Cc: Greg Hogan <code@greghogan.com>, Christopher Baines <mail@cbaines.net>, Z572 <zhengjunjie@iscas.ac.cn>, Liliana Marie Prikler <liliana.prikler@gmail.com>, iyzsong@envs.net, Andreas Enge <andreas@enge.fr>, Z572 <z572@z572.online>, 75518@debbugs.gnu.org, yelninei@tutamail.com, Janneke Nieuwenhuizen <janneke@gnu.org> Received: via spool by 75518-submit@debbugs.gnu.org id=B75518.174888061625202 (code B ref 75518); Mon, 02 Jun 2025 16:11:02 +0000 Received: (at 75518) by debbugs.gnu.org; 2 Jun 2025 16:10:16 +0000 Received: from localhost ([127.0.0.1]:53355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1uM7jq-0006YK-Pf for submit@debbugs.gnu.org; Mon, 02 Jun 2025 12:10:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37230) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <ludo@gnu.org>) id 1uM7ji-0006Vl-15 for 75518@debbugs.gnu.org; Mon, 02 Jun 2025 12:10:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@gnu.org>) id 1uM7ja-0006qw-SF; Mon, 02 Jun 2025 12:09:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=hy/kTwfkSwjQDYDthedqGD3lib9VUiGkLfU7mz503B8=; b=ZjPxe8Bu/PoIMsbbsg5B MPKwdqVmwwvCOErK5WpKP6igFYYMZASKmV7mSgajSVXOMFAwkVrm9fa5tYZVwbGRONix7A9UOgetB WmxV5iUrLL0FRS7GnCn2mcAC/7G7IpHgQndYaWI5C5UJA1CFZWCIV/UTsmqgHsoNGvZKd3eWPpbKS E/Heg8It5HScA69dM6FCmRj+6SkoiegS3qeec3GcbNW728q/2PChjCXniRwWkkmiuNlESKDQDC8Ui 8sz5EN7b5xAKZFdIEY4o4IKzfWffdlmnJZqhKqmMwq5R9gDzpB31uzaOu3hrpR55t8y9g/CwU9+dy oxGtkKoH4uenzQ==; From: Ludovic =?utf-8?q?Court=C3=A8s?= <ludo@gnu.org> In-Reply-To: <87tt4ye05x.fsf@ditigal.xyz> (rutherther@ditigal.xyz's message of "Mon, 02 Jun 2025 15:35:38 +0200") References: <87plfvn6zk.fsf@cbaines.net> <87cybor0ik.fsf@ditigal.xyz> <aDwoPzJXovr3ZU1h@jurong> <878qmbrb1c.fsf@ditigal.xyz> <87a56r40f0.fsf@gnu.org> <875xhefhyq.fsf@ditigal.xyz> <87tt4ye05x.fsf@ditigal.xyz> User-Agent: mu4e 1.12.11; emacs 29.4 X-URL: https://people.bordeaux.inria.fr/lcourtes/ X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu X-Revolutionary-Date: Quartidi 14 Prairial an 233 de la =?utf-8?q?R=C3=A9vol?= =?utf-8?q?ution=2C_?= jour de l'Acacia Date: Mon, 02 Jun 2025 18:01:01 +0200 Message-ID: <87plfmnneq.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
Series |
[bug#75518] Motif build failure
|
|
Commit Message
Ludovic Courtès
June 2, 2025, 4:01 p.m. UTC
Hi,
Rutherther <rutherther@ditigal.xyz> writes:
> Hi, I've tried looking at one of the failing packages - motif.
The error looks like this:
--8<---------------cut here---------------start------------->8---
libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../../include -I.. -I./.. -DXMBINDDIR_FALLBACK=\"/gnu/store/lm1p1w0x29w2ypvc8g8nj6k7vharz927-motif-2.3.8-0.59858b0/lib/X11/bindings\" -DINCDIR=\"/gnu/store/lm1p1w0x29w2ypvc8g8nj6k7vharz927-motif-2.3.8-0.59858b0/include/X11\" -DLIBDIR=\"/gnu/store/lm1p1w0x29w2ypvc8g8nj6k7vharz927-motif-2.3.8-0.59858b0/lib/X11\" -I/gnu/store/cm3gmdiv2dmwnld2v5zngc5amsaxnf2b-freetype-2.13.0/include/freetype2 -I/gnu/store/1dlwzyjk51xbn1k7v7b010gidrxxvida-libpng-1.6.39/include/libpng16 -I/gnu/store/cm3gmdiv2dmwnld2v5zngc5amsaxnf2b-freetype-2.13.0/include/freetype2 -I/gnu/store/1dlwzyjk51xbn1k7v7b010gidrxxvida-libpng-1.6.39/include/libpng16 -g -O2 -Wall -g -fno-strict-aliasing -Wno-unused -Wno-comment -I/gnu/store/cm3gmdiv2dmwnld2v5zngc5amsaxnf2b-freetype-2.13.0/include/freetype2 -I/gnu/store/1dlwzyjk51xbn1k7v7b010gidrxxvida-libpng-1.6.39/include/libpng16 -MT XpmWrFFrDat.lo -MD -MP -MF .deps/XpmWrFFrDat.Tpo -c XpmWrFFrDat.c -fPIC -DPIC -o .libs/XpmWrFFrDat.o
XpmCrBufFrI.c: In function ‘XmeXpmCreateBufferFromXpmImage’:
XpmCrBufFrI.c:155:5: error: implicit declaration of function ‘strcpy’ [-Wimplicit-function-declaration]
155 | strcpy(ptr, buf);
| ^~~~~~
XpmCrBufFrI.c:47:1: note: include ‘<string.h>’ or provide a declaration of ‘strcpy’
46 | #include "XpmI.h"
+++ |+#include <string.h>
47 |
XpmCrBufFrI.c:155:5: warning: incompatible implicit declaration of built-in function ‘strcpy’ [-Wbuiltin-declaration-mismatch]
155 | strcpy(ptr, buf);
| ^~~~~~
XpmCrBufFrI.c:155:5: note: include ‘<string.h>’ or provide a declaration of ‘strcpy’
XpmCrBufFrI.c: In function ‘WriteColors’:
XpmCrBufFrI.c:292:9: error: implicit declaration of function ‘strncpy’ [-Wimplicit-function-declaration]
292 | strncpy(s, *defaults++, cpp);
| ^~~~~~~
XpmCrBufFrI.c:292:9: note: include ‘<string.h>’ or provide a declaration of ‘strncpy’
XpmCrBufFrI.c:292:9: warning: incompatible implicit declaration of built-in function ‘strncpy’ [-Wbuiltin-declaration-mismatch]
XpmCrBufFrI.c:292:9: note: include ‘<string.h>’ or provide a declaration of ‘strncpy’
XpmCrBufFrI.c:312:9: warning: incompatible implicit declaration of built-in function ‘strcpy’ [-Wbuiltin-declaration-mismatch]
312 | strcpy(s, "\",\n");
| ^~~~~~
XpmCrBufFrI.c:312:9: note: include ‘<string.h>’ or provide a declaration of ‘strcpy’
XpmCrBufFrI.c:316:45: error: implicit declaration of function ‘strlen’ [-Wimplicit-function-declaration]
316 | (*data_size + l - *used_size) <= strlen(buf))
| ^~~~~~
XpmCrBufFrI.c:316:45: note: include ‘<string.h>’ or provide a declaration of ‘strlen’
--8<---------------cut here---------------end--------------->8---
This is easily addressed with the attached patch.
Unfortunately there are additional failures afterwards:
--8<---------------cut here---------------start------------->8---
libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../../include -I.. -I./.. -DXMBINDDIR_FALLBACK=\"/gnu/store/jww518240g0h9ffmbn1c3069ly829mhw-motif-2.3.8-0.59858b0/lib/X11/bindings\" -DINCDIR=\"/gnu/store/jww518240g0h9ffmbn1c3069ly829mhw-motif-2.3.8-0.59858b0/include/X11\" -DLIBDIR=\"/gnu/store/jww518240g0h9ffmbn1c3069ly829mhw-motif-2.3.8-0.59858b0/lib/X11\" -I/gnu/store/cm3gmdiv2dmwnld2v5zngc5amsaxnf2b-freetype-2.13.0/include/freetype2 -I/gnu/store/1dlwzyjk51xbn1k7v7b010gidrxxvida-libpng-1.6.39/include/libpng16 -I/gnu/store/cm3gmdiv2dmwnld2v5zngc5amsaxnf2b-freetype-2.13.0/include/freetype2 -I/gnu/store/1dlwzyjk51xbn1k7v7b010gidrxxvida-libpng-1.6.39/include/libpng16 -g -O2 -Wall -g -fno-strict-aliasing -Wno-unused -Wno-comment -I/gnu/store/cm3gmdiv2dmwnld2v5zngc5amsaxnf2b-freetype-2.13.0/include/freetype2 -I/gnu/store/1dlwzyjk51xbn1k7v7b010gidrxxvida-libpng-1.6.39/include/libpng16 -MT DrawUtils.lo -MD -MP -MF .deps/DrawUtils.Tpo -c DrawUtils.c -fPIC -DPIC -o .libs/DrawUtils.o
In file included from TabStack.c:43:
TabStack.c: In function ‘QueryGeometry’:
../Xm/TabStackP.h:140:66: error: passing argument 1 of ‘_XmTabBoxStackedGeometry’ from incompatible pointer type [-Wincompatible-pointer-types]
140 | #define XmTabStack_tab_box(w) (((XmTabStackWidget)(w))->tab_stack.tab_box)
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
| |
| Widget {aka struct _WidgetRec *}
TabStack.c:1641:42: note: in expansion of macro ‘XmTabStack_tab_box’
1641 | _XmTabBoxStackedGeometry(XmTabStack_tab_box(tab), width,
| ^~~~~~~~~~~~~~~~~~
TabStack.c:74:45: note: expected ‘XmTabBoxWidget’ {aka ‘struct _XmTabBoxRec *’} but argument is of type ‘Widget’ {aka ‘struct _WidgetRec *’}
74 | extern void _XmTabBoxStackedGeometry _ARGS((XmTabBoxWidget, int, XRectangle *));
| ^~~~~~~~~~~~~~
TabStack.c:60:18: note: in definition of macro ‘_ARGS’
60 | #define _ARGS(a) a
| ^
--8<---------------cut here---------------end--------------->8---
I tried to build with ‘-std=c99’ (which is supposedly lower than the
default for GCC 14) but that didn’t help.
We could also check what other distros are doing.
Ludo’.
Add missing includes. diff --git a/lib/Xm/XpmI.h b/lib/Xm/XpmI.h index 5d690fa1..61767865 100644 --- a/lib/Xm/XpmI.h +++ b/lib/Xm/XpmI.h @@ -401,6 +401,7 @@ FUNC(xpmstrdup, char *, (char *s1)); #else #undef xpmstrdup #define xpmstrdup strdup +#include <string.h> #endif #ifdef NEED_STRCASECMP @@ -408,6 +409,7 @@ FUNC(xpmstrcasecmp, int, (char *s1, char *s2)); #else #undef xpmstrcasecmp #define xpmstrcasecmp strcasecmp +#include <strings.h> #endif FUNC(xpmatoui, unsigned int,