From patchwork Mon Nov 27 22:59:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mehmet Tekman X-Patchwork-Id: 56879 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id B241027BBEA; Mon, 27 Nov 2023 23:01:11 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id BED7327BBE2 for ; Mon, 27 Nov 2023 23:01:09 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r7kb3-0007hU-4J; Mon, 27 Nov 2023 18:00:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r7kb2-0007h8-5b for guix-patches@gnu.org; Mon, 27 Nov 2023 18:00:56 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r7kb1-0005j1-U2 for guix-patches@gnu.org; Mon, 27 Nov 2023 18:00:55 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r7kb8-00036M-3f for guix-patches@gnu.org; Mon, 27 Nov 2023 18:01:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67343] [PATCH] Add fftw-cmake References: <87o7fmu8or.fsf@gmail.com> In-Reply-To: <87o7fmu8or.fsf@gmail.com> Resent-From: Mehmet Tekman Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 27 Nov 2023 23:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67343 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 67343@debbugs.gnu.org Received: via spool by 67343-submit@debbugs.gnu.org id=B67343.17011260124101 (code B ref 67343); Mon, 27 Nov 2023 23:01:02 +0000 Received: (at 67343) by debbugs.gnu.org; 27 Nov 2023 23:00:12 +0000 Received: from localhost ([127.0.0.1]:45051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7kaJ-00012T-M5 for submit@debbugs.gnu.org; Mon, 27 Nov 2023 18:00:12 -0500 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:43377) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7kaG-0000W2-RA for 67343@debbugs.gnu.org; Mon, 27 Nov 2023 18:00:10 -0500 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-332ff20ec45so995022f8f.1 for <67343@debbugs.gnu.org>; Mon, 27 Nov 2023 15:00:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701125996; x=1701730796; darn=debbugs.gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=26qjYeSem/0dRkybd4sYaEkRPiFXK7xoiLn4qowKNM4=; b=QmsBBzyH/NIY9h6JnvJtQkIvxpg1j2aVDI76P0bNQ3AyogDSbOhtL4PAlanDL12u+m /UZfcqO01mRZP91jZY+WLknby0fZ72usupISSnrFgv7UAjWz4uSJIrA40XrAy6oi8L+s qX8oOYGQv/QUrg3oU7Y1Kz3g1cTUICxeGYNx1zQ+4PbAd0N4MoixUmD2FOdLJAQmd50i LZ0OjXMbQE4JPYCoMhospLlUQHWvqmD6VM3MDAVHDYcu6GAml0aWFSsHu6/hj+rs7LZQ YNVSGlD/WCIq7Zd43hCAreHmkwRnNcicxjefDO1L2hGLdZ4fIJyMFAap+DmOkAWV13pm iKgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701125996; x=1701730796; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=26qjYeSem/0dRkybd4sYaEkRPiFXK7xoiLn4qowKNM4=; b=DzLpgLBLzo8IH5bn8n2M0k5dLKgQDBsNGfO5TIZnd2Ll7uDlNVvbUReEy+PsUC2WYp tddKQtZLVCTAGSdxjCj4ANzAddwpPoeUezaDbmgZhPp5LYL0Z7niigX9vCeNh++pIfRB zvRpJ4IsAwptz2WkdSoeDD8w8MkNEI6vy7JMmFSsGYJ35VLP9QwU8i42VVbo/eClokME hzqu0wG4JK2ds0SVaqVLS1wQ8t8CDAUGE9G4RmYCZH4UH+Uo1d2/m3d+x9QG6QhmreI/ pYKCSgU++yml97RNMPIfTA2JZbSla8Y6AzWH9wt10e7yQG4UWYmun3Ac+ENGg4hmyJHW JoLw== X-Gm-Message-State: AOJu0Yz0xJwK2U4B5+BdKrYUjzcy2MrIKFmtqSIPidyzJelR8f2zp9aI FnNQP2okfLJovtrOvb6sK8hZGS7vXbU= X-Google-Smtp-Source: AGHT+IFgt13X+41tQDEtTjjwgnsdyEuvOptq4C0mJISgFlokOqmWMhKhTaBd7fXgUauLrd/Hvwcq/w== X-Received: by 2002:a05:6000:b48:b0:332:fe87:fe80 with SMTP id dk8-20020a0560000b4800b00332fe87fe80mr4258971wrb.35.1701125995752; Mon, 27 Nov 2023 14:59:55 -0800 (PST) Received: from hayvan (pharma2-70.w2k.pharmakol.uni-freiburg.de. [132.230.165.170]) by smtp.gmail.com with ESMTPSA id a9-20020adffb89000000b0033309206032sm973662wrr.72.2023.11.27.14.59.54 for <67343@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 14:59:54 -0800 (PST) From: Mehmet Tekman Date: Mon, 27 Nov 2023 23:59:53 +0100 Message-ID: <87o7feyf86.fsf@gmail.com> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches After talking with via irc[0], it was explained to me that I can inherit an existing package decleration instead of cloning it. 0: https://logs.guix.gnu.org/guix/2023-11-27.log#151712 This is an update of the previous patch. Please use this patch instead and ignore the previous one. From b4a6539391ae1a5e241d6398f8f33a5e63e890e1 Mon Sep 17 00:00:00 2001 From: Mehmet Tekman Date: Mon, 27 Nov 2023 23:38:32 +0100 Subject: [PATCH] * gnu/packages/algebra.scm (fftw-cmake): New variable This is a clone of the fftw function, but uses cmake to build in order for the FFTW3LibraryDepends.cmake file to be built, neccesary for packages with cmake builds that depend on fftw3. See: https://bugzilla.redhat.com/show_bug.cgi?id=1729652#c5 This variable is cloned from the existing fftw3 in order to not break any downstream packages that make use of the target optimizations given by the gnu build. Change-Id: I620d00d980421bc063c325718e0cafc4ae23e57e --- gnu/packages/algebra.scm | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/gnu/packages/algebra.scm b/gnu/packages/algebra.scm index c0fe75ddfd..ecad6b2b21 100644 --- a/gnu/packages/algebra.scm +++ b/gnu/packages/algebra.scm @@ -15,6 +15,7 @@ ;;; Copyright © 2020, 2021, 2023 Vinicius Monego ;;; Copyright © 2021 Lars-Dominik Braun ;;; Copyright © 2022 Maxim Cournoyer +;;; Copyright © 2023 Mehmet Tekman ;;; ;;; This file is part of GNU Guix. ;;; @@ -733,6 +734,20 @@ (define-public kiss-fft-for-extempore a C program.") (license license:bsd-3))) +(define-public fftw-cmake + (package/inherit fftw + ;; Cmake compiling is experimental since 2017, and it is not clear if this + ;; build has the same target-specific optimizations as the fftw gnu build. + ;; See: https://fftw.org/release-notes.html + (name "fftw-cmake") + (build-system cmake-build-system) + (arguments (default-keyword-arguments '() + '())) + (description (string-append (package-description fftw) + " This CMake build offers the file +FFTW3LibraryDepends.cmake required by some dependent packages, absent in the +gnu build version.")))) + (define-public fftw (package (name "fftw") -- 2.41.0