From patchwork Mon May 27 14:52:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Patchwork-Id: 14088 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 1053017051; Mon, 27 May 2019 15:53:07 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 994EE1704F for ; Mon, 27 May 2019 15:53:06 +0100 (BST) Received: from localhost ([127.0.0.1]:46884 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVGzq-0001eE-8l for patchwork@mira.cbaines.net; Mon, 27 May 2019 10:53:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50136) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVGzn-0001dy-Bz for guix-patches@gnu.org; Mon, 27 May 2019 10:53:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVGzm-0007Ny-90 for guix-patches@gnu.org; Mon, 27 May 2019 10:53:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40226) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hVGzm-0007Nu-6q for guix-patches@gnu.org; Mon, 27 May 2019 10:53:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hVGzm-00089r-3w for guix-patches@gnu.org; Mon, 27 May 2019 10:53:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#35878] [PATCH] gnu: Add chafa. Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 27 May 2019 14:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35878 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: guy fleury iteriteka Received: via spool by 35878-submit@debbugs.gnu.org id=B35878.155896876231322 (code B ref 35878); Mon, 27 May 2019 14:53:02 +0000 Received: (at 35878) by debbugs.gnu.org; 27 May 2019 14:52:42 +0000 Received: from localhost ([127.0.0.1]:53770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVGzS-000898-Am for submit@debbugs.gnu.org; Mon, 27 May 2019 10:52:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVGzR-00088t-Ey for 35878@debbugs.gnu.org; Mon, 27 May 2019 10:52:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38187) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVGzM-0007Ck-96; Mon, 27 May 2019 10:52:36 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=59920 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hVGzL-0003kf-KG; Mon, 27 May 2019 10:52:35 -0400 From: Ludovic =?utf-8?q?Court=C3=A8s?= References: <20190524093307.4345-1-hoonandon@gmail.com> Date: Mon, 27 May 2019 16:52:33 +0200 In-Reply-To: <20190524093307.4345-1-hoonandon@gmail.com> (guy fleury iteriteka's message of "Fri, 24 May 2019 11:33:07 +0200") Message-ID: <87muj8t0em.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 35878@debbugs.gnu.org Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi, guy fleury iteriteka skribis: > * gnu/packages/image-viewers.scm(chaffa): New variable. I’d suggest the changes below. Additionally, this code detects SSE4.1 and related instruction set extensions at configuration time. As a result, I think the resulting code may not run on all x86_64 machines. Could you investigate this and see how we can get a generic binary? Thanks, Ludo’. diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm index fc94242ac6..d947f2d7eb 100644 --- a/gnu/packages/image-viewers.scm +++ b/gnu/packages/image-viewers.scm @@ -446,12 +446,12 @@ including CBZ, CB7, CBT, LHA.") (native-inputs `(("pkg-config" ,pkg-config))) (inputs - `(("glib" ,glib) + `(("glib" ,glib) ("imagemagick" ,imagemagick))) - (synopsis "Terminal Graphics for the 21st Century") + (synopsis "Convert images to ANSI/Unicode characters") (description - "Chafa is a command-line utility that converts all kinds of images, -including animated GIFs, into ANSI/Unicode character output that can be + "Chafa is a command-line utility that converts all kinds of images, +including animated GIFs, into ANSI/Unicode character output that can be displayed in a terminal.") (home-page "https://hpjansson.org/chafa/") (license license:lgpl3+)))