From patchwork Tue Dec 8 05:13:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleg Pykhalov X-Patchwork-Id: 25651 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 3F82627BC02; Tue, 8 Dec 2020 05:17:05 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id C367127BC01 for ; Tue, 8 Dec 2020 05:17:04 +0000 (GMT) Received: from localhost ([::1]:46102 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmVN2-0005Xp-0r for patchwork@mira.cbaines.net; Tue, 08 Dec 2020 00:17:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56546) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmVL4-0004lu-Px for guix-patches@gnu.org; Tue, 08 Dec 2020 00:15:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:44730) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kmVL4-0002oP-I2 for guix-patches@gnu.org; Tue, 08 Dec 2020 00:15:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kmVL4-0007gq-Cc for guix-patches@gnu.org; Tue, 08 Dec 2020 00:15:02 -0500 Subject: bug#45110: [PATCH] gnu: gita: Install shell completions. Resent-From: Oleg Pykhalov Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Tue, 08 Dec 2020 05:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 45110 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Michael Rohleder Cc: 45110-done@debbugs.gnu.org Mail-Followup-To: 45110@debbugs.gnu.org, go.wigust@gmail.com, mike@rohleder.de Received: via spool by 45110-done@debbugs.gnu.org id=D45110.160740444429470 (code D ref 45110); Tue, 08 Dec 2020 05:15:02 +0000 Received: (at 45110-done) by debbugs.gnu.org; 8 Dec 2020 05:14:04 +0000 Received: from localhost ([127.0.0.1]:56274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmVK8-0007fG-EZ for submit@debbugs.gnu.org; Tue, 08 Dec 2020 00:14:04 -0500 Received: from mail-lj1-f169.google.com ([209.85.208.169]:38648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmVK5-0007ea-Jd for 45110-done@debbugs.gnu.org; Tue, 08 Dec 2020 00:14:03 -0500 Received: by mail-lj1-f169.google.com with SMTP id j10so17637091lja.5 for <45110-done@debbugs.gnu.org>; Mon, 07 Dec 2020 21:14:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=nZQVjdQ5rax2VodtVtpz9yrIlIyA9yynQ3+cbDtm/Dg=; b=BDt0bgFvAy8Qm/dAG5s1SGHZvsg6Le5YvO1pfmWzFfYMCO8Dw0B8r/QztNycG4Uk57 vXi/ArnO/Rf5ecbD8xbf5bVyf83ojEIoOPYWrsOy6a+g63UMyDMhxkOV9OddQKzBUzuj WtPyi/MavIENy5YfO6qRSjigFVQ3x5uS5cPcYk5YLQkR8fyoE/kA3Ko2H5nig/0APhJC 8c+4EZdmd9rH6g24EuNwdCJfoPwTDkCsCr8bFR10NZ9yCjxH4ncKZebBJKv27/66ZvW3 nJORlaSXOpsNWhLCgkzcXklvHapvNqefmyu+o4/ITddo9GnFaItOAOJDUvTBBIuPCpC6 kq1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=nZQVjdQ5rax2VodtVtpz9yrIlIyA9yynQ3+cbDtm/Dg=; b=OEWb1Zptz8VKflRPpf1yfAlm8wAoXHsp5f8CL5xfojYdMdGJY7AnyChrUzZy/TlKRb 4bUYfSUP4thInrXDy89FEFxDveZT8syE/InEE3H7cRB960sDcv6n2mvOn/QmYFK/MCl4 u/FQFSqk9F964raoLfHCQ1kOBE31JsbT4+QwSmVMYpTPk7RuQkejIRRp0NVJnN9G3d5w DHAE8sYLFgroPdAQebhCIhdtWp9YTuoY9802A7KsF0jRJMIsaRm04E4JJzl8Df1QQI0L U1kI5QzB5ijexToxCxXiHVvhGfZYfXlw9RfzKPdwMxeWNAIoaknLFnAPniN72GNKwW2j ozTw== X-Gm-Message-State: AOAM530tx9Yrih6z+Q+89txV4gVsmy+uTwS0FVCDjgYzs19MsFdx1Sg6 N5gygYWKXJ39qIBKKkDlfsdONN9p9to= X-Google-Smtp-Source: ABdhPJyWyFs2WGnwuYbDP2ifp80vPjkKvrPshOt0H0IVomxXJ2WjmDCYkbN2nHRNSQocpA+hJuCH2w== X-Received: by 2002:a2e:a364:: with SMTP id i4mr4058169ljn.426.1607404435333; Mon, 07 Dec 2020 21:13:55 -0800 (PST) Received: from guixsd ([178.71.226.25]) by smtp.gmail.com with ESMTPSA id f10sm294664lfa.139.2020.12.07.21.13.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Dec 2020 21:13:54 -0800 (PST) From: Oleg Pykhalov References: <20201208012203.31133-1-mike@rohleder.de> Date: Tue, 08 Dec 2020 08:13:51 +0300 In-Reply-To: <20201208012203.31133-1-mike@rohleder.de> (Michael Rohleder's message of "Tue, 8 Dec 2020 02:22:03 +0100") Message-ID: <87lfe898xc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hello. Awesome, thank you! Small addition. As described in discussion [1] we don't need to return a boolean in phases. [1] https://lists.gnu.org/archive/html/guix-devel/2020-11/msg00585.html Pushed to master. Oleg. diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm index 95d6c220c0..8504c8b006 100644 --- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -2959,8 +2959,7 @@ defects faster.") (string-append bash-completion "/gita")) (mkdir-p zsh-completion) (copy-file ".gita-completion.zsh" - (string-append zsh-completion "/_gita")) - #t)))))) + (string-append zsh-completion "/_gita")))))))) (home-page "https://github.com/nosarthur/gita") (synopsis "Command-line tool to manage multiple Git repos") (description "This package provides a command-line tool to manage