From patchwork Wed Feb 5 01:36:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amin Bandali X-Patchwork-Id: 20132 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 31BFB166C9; Wed, 5 Feb 2020 01:37:11 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 814C216361 for ; Wed, 5 Feb 2020 01:37:10 +0000 (GMT) Received: from localhost ([::1]:40346 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iz9cr-0004Wp-SH for patchwork@mira.cbaines.net; Tue, 04 Feb 2020 20:37:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34987) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iz9cl-0004Wc-3e for guix-patches@gnu.org; Tue, 04 Feb 2020 20:37:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iz9cj-0001ey-Ow for guix-patches@gnu.org; Tue, 04 Feb 2020 20:37:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39032) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iz9cj-0001eo-M2 for guix-patches@gnu.org; Tue, 04 Feb 2020 20:37:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iz9cj-00023Y-JA for guix-patches@gnu.org; Tue, 04 Feb 2020 20:37:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#39422] [PATCH] gnu: Add pasystray. Resent-From: Amin Bandali Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 05 Feb 2020 01:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39422 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 39422@debbugs.gnu.org Received: via spool by 39422-submit@debbugs.gnu.org id=B39422.15808665857857 (code B ref 39422); Wed, 05 Feb 2020 01:37:01 +0000 Received: (at 39422) by debbugs.gnu.org; 5 Feb 2020 01:36:25 +0000 Received: from localhost ([127.0.0.1]:45005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iz9c4-00022b-Ub for submit@debbugs.gnu.org; Tue, 04 Feb 2020 20:36:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47773) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iz9c2-00022O-QM for 39422@debbugs.gnu.org; Tue, 04 Feb 2020 20:36:19 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45713) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iz9bx-0000A1-GD; Tue, 04 Feb 2020 20:36:13 -0500 Received: from cpe00fc8d518353-cm00fc8d518350.cpe.net.cable.rogers.com ([99.228.8.225]:46100 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iz9bv-0008MP-CB; Tue, 04 Feb 2020 20:36:12 -0500 From: Amin Bandali Organization: GNU References: <20200204153123.17099-1-mab@gnu.org> <20200205003140.GB30681@jasmine.lan> Date: Tue, 04 Feb 2020 20:36:05 -0500 In-Reply-To: <20200205003140.GB30681@jasmine.lan> Message-ID: <87imklvmre.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Leo Famulari writes: > On Tue, Feb 04, 2020 at 10:31:23AM -0500, Amin Bandali wrote: >> * gnu/packages/gtk.scm (pasystray): New variable. > > Thanks! Can we put it in the pulseaudio module? > Sure! Noting that now there's a circular import between the pulseaudio module and the gnome module because of dependency of pasystray on libnotify, defined in the gnome module. > >> + (add-before 'bootstrap 'remove-bootstrap.sh >> + (lambda _ >> + (delete-file "bootstrap.sh") ; not useful in the context of Guix >> + #t))))) > > Also, can you clarify this comment? Like, does it interfere with > building? > Yeah, exactly: --8<---------------cut here---------------start------------->8--- ... starting phase `bootstrap' running './bootstrap.sh' patch-shebang: ./bootstrap.sh: changing `/usr/bin/env bash' to `/gnu/store/29jhbbg1hf557x8j53f9sxd9imlmf02a-bash-minimal-5.0.7/bin/bash' configure.ac:27: installing './compile' configure.ac:26: installing './install-sh' configure.ac:26: installing './missing' src/Makefile.am: installing './depcomp' ./bootstrap.sh: ./configure: /bin/sh: bad interpreter: No such file or directory command "./bootstrap.sh" failed with status 126 --8<---------------cut here---------------end--------------->8--- PATCH v2 below mentions that bootstrap.sh interferes with build. Is that better? Or were you thinking of a longer explanation? * * * From 025f5eea0fb0508d0306d3c476b3c47c4fc9273c Mon Sep 17 00:00:00 2001 From: Amin Bandali Date: Tue, 4 Feb 2020 20:31:49 -0500 Subject: [PATCH v2] gnu: Add pasystray. * gnu/packages/pulseaudio.scm (pasystray): New variable. --- gnu/packages/pulseaudio.scm | 40 +++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/gnu/packages/pulseaudio.scm b/gnu/packages/pulseaudio.scm index 2bbe6c5bdd..0e37fe4f48 100644 --- a/gnu/packages/pulseaudio.scm +++ b/gnu/packages/pulseaudio.scm @@ -42,6 +42,7 @@ #:use-module (gnu packages check) #:use-module (gnu packages dbm) #:use-module (gnu packages glib) + #:use-module (gnu packages gnome) ; for libnotify #:use-module (gnu packages gtk) #:use-module (gnu packages libcanberra) #:use-module (gnu packages web) @@ -402,3 +403,42 @@ install one or more of the following packages alongside pulseaudio-dlna: "pamixer is like amixer but for PulseAudio, allowing easy control of the volume levels of the sinks (get, set, decrease, increase, toggle mute, etc).") (license l:gpl3+))) + +(define-public pasystray + (package + (name "pasystray") + (version "0.7.1") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/christophgysin/pasystray.git") + (commit (string-append name "-" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0xx1bm9kimgq11a359ikabdndqg5q54pn1d1dyyjnrj0s41168fk")))) + (build-system gnu-build-system) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-before 'bootstrap 'remove-bootstrap.sh + (lambda _ + (delete-file "bootstrap.sh") ; not useful in the context of Guix, + ; and interferes with build + #t))))) + (native-inputs + `(("autoconf" ,autoconf) + ("automake" ,automake) ; for aclocal + ("pkg-config" ,pkg-config))) + (inputs + `(("avahi" ,avahi) + ("gtk+" ,gtk+) + ("libnotify" ,libnotify) + ("libx11" ,libx11) + ("pulseaudio" ,pulseaudio))) + (home-page "https://github.com/christophgysin/pasystray") + (synopsis "PulseAudio controller for the system tray") + (description "@command{pasystray} enables control of various +PulseAudio server settings from the X11 system tray. See the project +README.md for a detailed list of features.") + (license l:lgpl2.1+))) -- 2.25.0