| Message ID | 87imiua42o.fsf@rohleder.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [bug#40204] gnu: xkbcomp: update to 1.4.3 | expand |
| Context | Check | Description |
|---|---|---|
| cbaines/comparison | success | View comparision |
| cbaines/git branch | success | View Git branch |
| cbaines/applying patch | fail | View Laminar job |
Hello Michael, While your patch LGTM, running: --8<---------------cut here---------------start------------->8--- guix refresh -l xkbcomp --8<---------------cut here---------------end--------------->8--- you'll see that it triggers too much rebuilds to be pushed on master. Could you rebase it on core-updates and see if it works? Thanks, Mathieu
On Tue, Mar 24, 2020 at 11:47:34AM +0100, Mathieu Othacehe wrote: > you'll see that it triggers too much rebuilds to be pushed on > master. Could you rebase it on core-updates and see if it works? To clarify, the guidelines about how many rebuilds are okay for which branch are in item 8 of the manual section Submitting Patches [0]: ------ 300 dependent packages or less master branch (non-disruptive changes). between 300 and 1,200 dependent packages staging branch (non-disruptive changes). This branch is intended to be merged in master every 3 weeks or so. Topical changes (e.g., an update of the GNOME stack) can instead go to a specific branch (say, gnome-updates). more than 1,200 dependent packages core-updates branch (may include major and potentially disruptive changes). This branch is intended to be merged in master every 2.5 months or so. ------ These are rough heuristics that help us manage big changes effectively. [0] https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html
Michael Rohleder <mike@rohleder.de> writes:
> * gnu/packages/xorg.scm (xkbcomp): update to 1.4.3
Thanks! Pushed to the 'core-updates' branch as
b12acffbd03c025b1e849f7a93d5edd47682a8ce.
From 2976e6de897232296d1e16a3a799cd3ab20ea1db Mon Sep 17 00:00:00 2001 From: Michael Rohleder <mike@rohleder.de> Date: Tue, 24 Mar 2020 03:13:33 +0100 Subject: [PATCH] * gnu/packages/xorg.scm (xkbcomp): update to 1.4.3 --- gnu/packages/xorg.scm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm index f4c7329e06..cde699bb51 100644 --- a/gnu/packages/xorg.scm +++ b/gnu/packages/xorg.scm @@ -22,6 +22,7 @@ ;;; Copyright © 2019 Yoshinori Arai <kumagusu08@gmail.com> ;;; Copyright © 2020 Leo Prikler <leo.prikler@student.tugraz.at> ;;; Copyright © 2020 Florian Pelz <pelzflorian@pelzflorian.de> +;;; Copyright © 2020 Michael Rohleder <mike@rohleder.de> ;;; ;;; This file is part of GNU Guix. ;;; @@ -3825,7 +3826,7 @@ alternative implementations like XRandR or TwinView.") (define xkbcomp-intermediate ; used as input for xkeyboard-config (package (name "xkbcomp-intermediate") - (version "1.4.2") + (version "1.4.3") (source (origin (method url-fetch) @@ -3835,7 +3836,7 @@ alternative implementations like XRandR or TwinView.") ".tar.bz2")) (sha256 (base32 - "0944rrkkf0dxp07vhh9yr4prslxhqyw63qmbjirbv1bypswvrn3d")))) + "0dflr250nlj6rrnv658f6dm8qx37sj0xfimc3ihay761kwb2q906")))) (build-system gnu-build-system) (inputs `(("xorgproto" ,xorgproto) -- 2.26.0