From patchwork Fri Apr 30 23:20:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tobias Geerinckx-Rice X-Patchwork-Id: 29045 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id D3BE127BC7E; Sat, 1 May 2021 00:21:11 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS, T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id E213627BC7C for ; Sat, 1 May 2021 00:21:10 +0100 (BST) Received: from localhost ([::1]:39660 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lccRZ-0004wN-UB for patchwork@mira.cbaines.net; Fri, 30 Apr 2021 19:21:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59792) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lccRS-0004w8-Lx for guix-patches@gnu.org; Fri, 30 Apr 2021 19:21:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48461) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lccRS-00050g-DU for guix-patches@gnu.org; Fri, 30 Apr 2021 19:21:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lccRS-0005Wh-89 for guix-patches@gnu.org; Fri, 30 Apr 2021 19:21:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48126] [PATCH] Add package for vim-solarized Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 30 Apr 2021 23:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48126 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tissevert Cc: 48126@debbugs.gnu.org X-Debbugs-Original-Cc: guix-patches@gnu.org, 48126@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.161982483921188 (code B ref -1); Fri, 30 Apr 2021 23:21:02 +0000 Received: (at submit) by debbugs.gnu.org; 30 Apr 2021 23:20:39 +0000 Received: from localhost ([127.0.0.1]:60007 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lccR4-0005Vg-VT for submit@debbugs.gnu.org; Fri, 30 Apr 2021 19:20:39 -0400 Received: from lists.gnu.org ([209.51.188.17]:41252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lccR4-0005VZ-0W for submit@debbugs.gnu.org; Fri, 30 Apr 2021 19:20:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59688) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lccR3-0004qW-RA for guix-patches@gnu.org; Fri, 30 Apr 2021 19:20:37 -0400 Received: from tobias.gr ([2a02:c205:2020:6054::1]:47958) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lccR0-0004iG-Pd for guix-patches@gnu.org; Fri, 30 Apr 2021 19:20:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobias.gr; s=2018; bh=5Zg5IXRNIsZai6QAxKKBJfVPi5hEwreqNef825xvyB0=; h=date:in-reply-to: subject:cc:to:from:references; b=ISanTZEcEP9K2B/i/TE2LIrs2LQhDuBT/uc5Y la0jhIJTQTQnKgAGlwGmcNf3y4bCWqUAsZCzMJ4Ht6MQ1tcrS303MR96R9/XY1tIuJKCB4 QmCtIR7wuxrpArgYAhgNCKMFkhB6XHpAPHoHjxOXmfeLzeiAG4p7UeeAPhTtDDesndIW/G c0MluqMqdCpDDCZ80EpooNYQFWMMk2qbXoDICcBRaujvRtheEV4uEqYRPz3Bv7eHSQs0tc 12qMmtOsJfbF7phVLfD6mib/raGY/NRM7AbCme31pcRzspNmSdUspruYdWms6grMu1SzbO Uvk9lX9NauLAMpBcSTYicTjog== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 47cf0869 (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO); Fri, 30 Apr 2021 23:20:40 +0000 (UTC) References: <20210430194235.1461cada@pine.local> In-reply-to: <20210430194235.1461cada@pine.local> BIMI-Selector: v=BIMI1; s=default; Date: Sat, 01 May 2021 01:20:30 +0200 Message-ID: <87im43qs01.fsf@nckx> MIME-Version: 1.0 Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice X-ACL-Warn: , Tobias Geerinckx-Rice via Guix-patches X-Patchwork-Original-From: Tobias Geerinckx-Rice via Guix-patches via From: Tobias Geerinckx-Rice X-getmail-retrieved-from-mailbox: Patches Tissevert 写道： > I here's my first attempt at packaging something, I noticed that > vim-solarized > was missing so I tried to write a package for it. Thank you! > > The only warning I got was from the guix lint which told me it > couldn't find > upstream releases. I believe this is due to vim-solarized > particular structure: > it's a light «clone» of the main repository > https://github.com/altercation/solarized containing only the > vim-files. Hmm. Could we install from this authoritative(?) source instead, even if the download's bigger? > (https://github.com/vim-scripts/Solarized) which has made a tag > (the same > version name that I chose) so we could be using either the full > repository > (more unneeded data retrieved during the build) or this second > copy (they do > provide a tag but isn't it better to remain as close as possible > to the > original source ?). Oh, I think we agree. :-) /tmp λ git clone --depth=1 https://github.com/vim-scripts/Solarized Cloning into 'Solarized' [...] /tmp λ git clone --depth=1 https://github.com/altercation/solarized Cloning into 'solarized' [...] /tmp λ du -hs [Ss]olarized 196K Solarized 30M solarized The relative difference is huge but I think 30M is worth it. Could you make this change, test, and send a V2? I'm no adherent of the Vim. > I hope my patch is correct and thank you everyone for being such > a welcoming > community and having made my experience with Guix so far > absolutely great ! Thank you! We try to do our best... Your patch is great. I'd make the following tweaks before committing. You can incorporate them into your V2 if you want. The description should explain what the package is to someone who's never heard of it. We actually recommend ~10 lines (more is fine), although many existing packages don't meet that bar. The synopsis should do the same in one line. Don't be afraid to temper fawning upstream marketing-speak and empty taglines like this one. That doesn't mean it can't be positive (like mine -- I hate Solarized). C-M-q reindented the source field according to the same rules as etc/indent-code.el. Better to do so before committing it, so future committers can just run C-M-q on the entire expression without creating unrelated whitespace noise. +sunlight and can tire the eye. Solarized reduces brightness contrast but, +unlike many low-contrast color schemes, retains contrasting hues based on +color wheel relations for syntax highlighting readability. + +Solarized retains the same selective contrast relationships and overall feel +when switching between the light and dark background modes.") + (license license:expat))) Kind regards, T G-R diff --git a/gnu/packages/vim.scm b/gnu/packages/vim.scm index 477c15b9aa..ad95724c41 100644 --- a/gnu/packages/vim.scm +++ b/gnu/packages/vim.scm @@ -585,24 +585,33 @@ are detected, the user is notified.") (name "vim-solarized") (version "v1.0.0beta1") (source - (origin - (method git-fetch) - (uri (git-reference - (url "https://github.com/altercation/vim-colors-solarized") - (commit "528a59f26d12278698bb946f8fb82a63711eec21"))) - (file-name (git-file-name name version)) - (sha256 - (base32 - "05d3lmd1shyagvr3jygqghxd3k8a4vp32723fvxdm57fdrlyzcm1")))) + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/altercation/vim-colors-solarized") + (commit "528a59f26d12278698bb946f8fb82a63711eec21"))) + (file-name (git-file-name name version)) + (sha256 + (base32 "05d3lmd1shyagvr3jygqghxd3k8a4vp32723fvxdm57fdrlyzcm1")))) (build-system copy-build-system) (arguments '(#:install-plan '(("colors" "share/vim/vimfiles/") ("doc" "share/vim/vimfiles/")))) (home-page "https://github.com/altercation/vim-colors-solarized") - (synopsis "Solarized Colorscheme for Vim") - (description "Precision colors for machines and people") - (license license:bsd-3))) + (synopsis "Solarized color scheme for Vim") + (description + "Solarized is a sixteen-color palette of eight monotones and eight accent +colors. It was designed for use with both terminal and GUI applications. + +Black text on white from a computer display is akin to reading a book in direct