diff mbox

[bug#49169,00/11] Removing input labels from package definitions

Message ID 87im26465i.fsf@gnu.org
State Accepted
Headers show

Commit Message

Ludovic Courtès June 22, 2021, 9:09 a.m. UTC 
Ludovic Courtès <ludo@gnu.org> skribis:

> The main change is the addition of ‘guix style’, based on the script
> I posted earlier.  ‘guix style’ is able to systematically preserve
> comments (margin comments and line comments).  It recognizes and
> “translates” several common idioms.

Here’s a couple of diffs generated by ‘guix style’:
Comments:
Pretty cool, no?  :-)

Ludo’.

Comments

Christopher Baines June 27, 2021, 6:37 p.m. UTC | #1 
Ludovic Courtès <ludo@gnu.org> writes:

> Ludovic Courtès <ludo@gnu.org> skribis:
>
>> The main change is the addition of ‘guix style’, based on the script
>> I posted earlier.  ‘guix style’ is able to systematically preserve
>> comments (margin comments and line comments).  It recognizes and
>> “translates” several common idioms.
>
> Here’s a couple of diffs generated by ‘guix style’:
>
> @@ -171,9 +170,9 @@ engine programmable using Lua.")
>      (inherit arcan)
>      (name "arcan-sdl")
>      (inputs
> -     `(("sdl" ,sdl)
> -       ,@(fold alist-delete (package-inputs arcan)
> -               '("libdrm"))))
> +     (modify-inputs (package-inputs arcan)
> +       (delete "libdrm")
> +       (prepend sdl)))
>      (arguments
>       `(,@(ensure-keyword-arguments
>            (package-arguments arcan)
> @@ -218,11 +217,7 @@ engine programmable using Lua.")
>             ,(string-append "--with-xkb-output="
>                             "/tmp"))))   ; FIXME: Copied from xorg
>        (native-inputs
> -       `(("pkg-config" ,pkg-config)
> -         ("autoconf" ,autoconf)
> -         ("automake" ,automake)
> -         ("libtool" ,libtool)
> -         ("util-macros" ,util-macros)))
> +       (list pkg-config autoconf automake libtool util-macros))
>        (inputs
>         `(("arcan" ,arcan)
>           ("font-util" ,font-util)
>
> Comments:
>
> @@ -3797,11 +3713,11 @@ important tasks for becoming a daemon process:
>                  "1aycpc387wqz7h9w2p53qxn43qsh3m6by6ak4kkc66x9aprr63rz"))))
>      (build-system python-build-system)
>      (propagated-inputs
> -     `(("python-six" ,python-six)))
> +     (list python-six))
>      (native-inputs
> -     `(;; For tests.
> -       ("graphviz" ,graphviz)           ;for 'dot'
> -       ("python-nose" ,python-nose)))
> +     (list ;; For tests.
> +           graphviz ;for 'dot'
> +           python-nose))
>      (home-page "https://github.com/c0fec0de/anytree")
>      (synopsis "Lightweight tree data library")
>
> Pretty cool, no?  :-)

The automated translation is pretty impressive! I've had a quick look
through the patches and they look good to me.
Ludovic Courtès June 28, 2021, 9:54 a.m. UTC | #2 
Hi,

Christopher Baines <mail@cbaines.net> skribis:

> The automated translation is pretty impressive! I've had a quick look
> through the patches and they look good to me.

Awesome, thanks for taking the time!

Ludo’.
diff mbox

Patch

@@ -3797,11 +3713,11 @@  important tasks for becoming a daemon process:
                 "1aycpc387wqz7h9w2p53qxn43qsh3m6by6ak4kkc66x9aprr63rz"))))
     (build-system python-build-system)
     (propagated-inputs
-     `(("python-six" ,python-six)))
+     (list python-six))
     (native-inputs
-     `(;; For tests.
-       ("graphviz" ,graphviz)           ;for 'dot'
-       ("python-nose" ,python-nose)))
+     (list ;; For tests.
+           graphviz ;for 'dot'
+           python-nose))
     (home-page "https://github.com/c0fec0de/anytree")
     (synopsis "Lightweight tree data library")