diff mbox series

[bug#60271] gnu: Update xfce to 4.18.

Message ID 87ilhr19oc.fsf@163.com
State New
Headers show
Series [bug#60271] gnu: Update xfce to 4.18. | expand

Commit Message

Feng Shu Dec. 31, 2022, 10:37 p.m. UTC 
Michael Rohleder <mike@rohleder.de> writes:

I think we should conside update panel plugin when update to xfce 4.18.
for many panel plugins will build fail when we update xfce 4.18.

for example:
1. xfce4-cpufreq-plugin
2. xfce4-cpugraph-plugin

the below are patches, maybe we should create a wip-xfce branch, to see
which xfce apps or plugins wil build fail.
--

Comments

宋文武 Jan. 28, 2023, 9:04 a.m. UTC | #1 
Feng Shu <tumashu@163.com> writes:

> Michael Rohleder <mike@rohleder.de> writes:
>
> I think we should conside update panel plugin when update to xfce 4.18.
> for many panel plugins will build fail when we update xfce 4.18.
>
> for example:
> 1. xfce4-cpufreq-plugin
> 2. xfce4-cpugraph-plugin
>
> the below are patches, maybe we should create a wip-xfce branch, to see
> which xfce apps or plugins wil build fail. 

Hello Feng Shu and Michael Rohleder, I have create a wip-xfce branch and
applied all patches: They're all LGTM, and I will merge it after some
tests later.  Thank you!


e0869fe3c1b43d41e5ce418f277b6887b9e4a3e6 gnu: xfce4-settings: Enable UPower support.
5ce696fcf52df79b2aa22d72e317403e04f198af gnu: xfce4-settings: Enable colord support.
27a60b677fb7eb5a6bc4dd268164845ed59642f7 gnu: xfwm4: Enable Xpreset support.
03f8b39297d1b75a376164df08cdbca05dc60a82 gnu: xfce4-datetime-plugin: Update to 0.8.3.
95a1892b857d9c20274bc61775e33ebacac04d95 gnu: xfce4-notifyd: Update to 0.7.2.
ae63395a56ed334ee5ebc1273d6fbe2efa034674 gnu: xfdashboard: Update to 1.0.0.
3de3d3f61a0c084c3502a8fc55ca97ba2b5f8eca gnu: Add thunar-vcs-plugin.
6342a9bf674573439d2f5302bf9c0b823df4f2e0 gnu: Add thunar-media-tags-plugin.
54f9abf680d0ee84d6c267197f419cfc4b2d26b1 gnu: Add thunar-shares-plugin.
a32931f8a700e64a34b50d3ab39f8c07b45946f6 gnu: Add thunar-archive-plugin.
8bdc72f7b97b457ca1d25ee4845b8b3ba33cc96a gnu: xfce: Propagate search paths of 'thunar'.
33e8131ac9ca22214adf592c279812042efb5d49 gnu: thunar: Add a search path for THUNARX_DIRS.
ef73e3643da20c2d1538dde8123f149304b326f3 gnu: xfce4-systemload-plugin: Update to 1.3.2.
df00882f88af6fba14adfc3204668ae5a8aff3d6 gnu: xfce4-places-plugin: Update to 1.8.3.
5460486c2c9aeb3cef68076cf20c5262a0f284b7 gnu: xfce4-whiskermenu-plugin: Update to 2.7.2.
c30c8bb5a0774b3d2b7e7ec43b89763503071eca gnu: xfce4-eyes-plugin: Update to 4.6.0.
828a8fb76f65a902e7a0899d59f7de43c3881403 gnu: xfce4-cpugraph-plugin: Update to 1.2.7.
434e93ea7d569c32486f6208e95141aec7866a5f gnu: xfce4-cpufreq-plugin: Update to 1.2.8.
7e02db6c21372a76d636f7c2f1445bc30d8bd8f3 gnu: xfce4-terminal: Fix build.
32951096069f7cd8ee65de3fd48edd168994db33 gnu: xfce4-dev-tools: Update to 4.18.0.
6bcee7130273dabe8a17accecca2408de4f197b6 gnu: thunar-volman: Update to 4.18.0.
1b4d0957771bb424861a58392e6c6eedc0c0f76e gnu: xfce4-power-manager: Update to 4.18.0.
934468f9e51aee0b347cc8ce293c34ba690bc26c gnu: thunar: Update to 4.18.3.
1e12f2e1062f9454d6a9f1999a1e9a9abd46e6ab gnu: xfwm4: Update to 4.18.0.
4c8bc48c86242c0225b1c61ee3f634aa5f9169e4 gnu: xfdesktop: Update to 4.18.1.
e081d1d0fd9a9f17ff77de9dd797e8ab88316cf8 gnu: xfce4-settings: Update to 4.18.1.
611070e82427598b80b3c75e135d691ba68f6263 gnu: xfce4-session: Update to 4.18.0.
f92c454e2848d2b834859b8b577ef1038e95e824 gnu: xfce4-appfinder: Update to 4.18.0.
ec5893cf7eafc10dee5af8d4c1aef8c3f23bc9f4 gnu: xfce4-panel: Update to 4.18.1.
5f870b759cdcfbb696f53647e9656b6d2cf72820 gnu: garcon: Update to 4.18.0.
1899bd27b1e2d21a8beb54ec362f73c8869b9261 gnu: tumbler: Update to 4.18.0.
8646d8cf8278415c2798318029e917ab208e3e93 gnu: exo: Update to 4.18.0.
257213f6409bf78480d8da09dce0b17842825b87 gnu: libxfce4ui: Update to 4.18.1.
2bf770f8c191328a33a19c19455b080f8edc3d20 gnu: xfconf: Update to 4.18.0.
c14bbd574973870919b14b1f7f12a7207a8f9bc2 gnu: libxfce4util: Update to 4.18.1.
Feng Shu Jan. 28, 2023, 9:50 a.m. UTC | #2 
宋文武 <iyzsong@envs.net> writes:

> Feng Shu <tumashu@163.com> writes:
>
>> Michael Rohleder <mike@rohleder.de> writes:
>>
>> I think we should conside update panel plugin when update to xfce 4.18.
>> for many panel plugins will build fail when we update xfce 4.18.
>>
>> for example:
>> 1. xfce4-cpufreq-plugin
>> 2. xfce4-cpugraph-plugin
>>
>> the below are patches, maybe we should create a wip-xfce branch, to see
>> which xfce apps or plugins wil build fail. 
>
> Hello Feng Shu and Michael Rohleder, I have create a wip-xfce branch and
> applied all patches: They're all LGTM, and I will merge it after some
> tests later.  Thank you!
>
>

> 54f9abf680d0ee84d6c267197f419cfc4b2d26b1 gnu: Add thunar-shares-plugin.

thunar-shares-plugin 0.3.2 has been released (2023/01/03), suggest
update, for it fix an important bug.


--
Michael Rohleder Jan. 28, 2023, 10:09 a.m. UTC | #3 
宋文武 <iyzsong@envs.net> writes:
> Hello Feng Shu and Michael Rohleder, I have create a wip-xfce branch and
> applied all patches: They're all LGTM, and I will merge it after some
> tests later.  Thank you!

yay!  Thank you very much!
宋文武 Jan. 29, 2023, 3:08 a.m. UTC | #4 
> [...]
>
> Hello Feng Shu and Michael Rohleder, I have create a wip-xfce branch and
> applied all patches: They're all LGTM, and I will merge it after some
> tests later.  Thank you!
>

Pushed!

During my tests, I find some issues though:

1. in xfce4-appearance-settings, switch the theme to greybird-dark will
kill it, with output:
```
(xfce4-appearance-settings:13788): Gtk-WARNING **: 10:53:21.078: Could not load a pixbuf from /org/gtk/libgtk/theme/Adwaita/assets/check-symbolic.svg.
This may indicate that pixbuf loaders or the mime database could not be found.

(xfce4-appearance-settings:13788): GLib-GIO-ERROR **: 10:53:23.264: Settings schema 'org.gnome.desktop.interface' does not contain a key named 'color-scheme'
```
I think this is due to our gsettings-desktop-schemas is old.

2. some icons are missing, and by default there is no pixbuf loader for
svg.  With a manually set GDK_PIXBUF_MODULE_FILE, I get better result
with elementary-xfce-icon-theme (the adwaita icon themes still missing
some icons).

3. logout via xfce4-session-logout will wait more about 30s for me,
sometimes it does logout immediately, no idea...

4. mousepad output:
Mousepad-Message: 11:00:34.614: Plugin directory '/gnu/store/0m4rqqn3gxwg6mafhccqjwwvqdz1a5sr-mousepad-0.5.10/lib/mousepad/plugins' not found
GLib-GIO-Message: 11:00:34.614: Using the 'memory' GSettings backend.  Your settings will not be saved or shared with other applications.

The default gsettings backend is dconf, I guess some applications like
mousepad need fix to enable dconf or use the keyfile backend for
gsettings...

I now open a bug for thoes issues.
Feng Shu Jan. 30, 2023, 1:19 p.m. UTC | #5 
宋文武 <iyzsong@envs.net> writes:

>> [...]
>>
>> Hello Feng Shu and Michael Rohleder, I have create a wip-xfce branch and
>> applied all patches: They're all LGTM, and I will merge it after some
>> tests later.  Thank you!
>>
>
> Pushed!
>
> During my tests, I find some issues though:
>
> 1. in xfce4-appearance-settings, switch the theme to greybird-dark will
> kill it, with output:
>
> ```
> (xfce4-appearance-settings:13788): Gtk-WARNING **: 10:53:21.078: Could not load a pixbuf from /org/gtk/libgtk/theme/Adwaita/assets/check-symbolic.svg.
> This may indicate that pixbuf loaders or the mime database could not be found.
>
> (xfce4-appearance-settings:13788): GLib-GIO-ERROR **: 10:53:23.264: Settings schema 'org.gnome.desktop.interface' does not contain a key named 'color-scheme'
> ```
>
> I think this is due to our gsettings-desktop-schemas is old.
>
> 2. some icons are missing, and by default there is no pixbuf loader for
> svg.  With a manually set GDK_PIXBUF_MODULE_FILE, I get better result
> with elementary-xfce-icon-theme (the adwaita icon themes still missing
> some icons).
>
> 3. logout via xfce4-session-logout will wait more about 30s for me,
> sometimes it does logout immediately, no idea...
>
> 4. mousepad output:
> Mousepad-Message: 11:00:34.614: Plugin directory '/gnu/store/0m4rqqn3gxwg6mafhccqjwwvqdz1a5sr-mousepad-0.5.10/lib/mousepad/plugins' not found
> GLib-GIO-Message: 11:00:34.614: Using the 'memory' GSettings backend.  Your settings will not be saved or shared with other applications.
>
> The default gsettings backend is dconf, I guess some applications like
> mousepad need fix to enable dconf or use the keyfile backend for
> gsettings...
>
> I now open a bug for thoes issues.
>

5. Thunar start slowly

When I update to xfce 4.18, thunar start need 5 second, when I

1. backup my xfce4 config.
2. rm my old xfce4 config.
3. run xfce4 and quit.
4. restore old xfce4 config.
5. run xfce4 again.

The problem dispear, I do not know why.



--
diff mbox series

Patch

From f30c65f1abb7f1f375d21468ec3e1ede8ef8494f Mon Sep 17 00:00:00 2001
From: Feng Shu <tumashu@163.com>
Date: Mon, 21 Mar 2022 19:33:59 +0800
Subject: [PATCH 12/12] gnu: Add thunar-vcs-plugin.

* gnu/packages/xfce.scm (thunar-vcs-plugin): New variable.
---
 gnu/packages/xfce.scm | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 9688682672..af8f8e1060 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -35,6 +35,7 @@ 
 (define-module (gnu packages xfce)
   #:use-module (gnu artwork)
   #:use-module (gnu packages)
+  #:use-module (gnu packages apr)
   #:use-module (gnu packages base)
   #:use-module (gnu packages bash)
   #:use-module (gnu packages calendar)
@@ -65,6 +66,8 @@  (define-module (gnu packages xfce)
   #:use-module (gnu packages python-xyz)
   #:use-module (gnu packages pulseaudio)
   #:use-module (gnu packages search)
+  #:use-module (gnu packages textutils)
+  #:use-module (gnu packages version-control)
   #:use-module (gnu packages web)
   #:use-module (gnu packages wm)
   #:use-module (gnu packages xml)
@@ -847,6 +850,42 @@  (define-public thunar-media-tags-plugin
 tags-based file renaming from inside Thunar Bulk Renamer.")
     (license gpl2+)))
 
+(define-public thunar-vcs-plugin
+  (package
+    (name "thunar-vcs-plugin")
+    (version "0.2.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://archive.xfce.org/src/thunar-plugins/"
+                           name "/" (version-major+minor version)
+                           "/" name "-" version ".tar.bz2"))
+       (sha256
+        (base32 "1f2d1dwfyi6xv3qkd8l8xh0vhz8wh0601cyigjzn426lqga1d29n"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list #:configure-flags
+           #~(list (string-append "CPPFLAGS=-I"
+                                  #$(this-package-input "apr-util")
+                                  "/include/apr-1"))))
+    (native-inputs (list pkg-config intltool utf8proc))
+    (inputs
+     (list exo
+           gtk+
+           thunar
+           libxfce4util
+           apr
+           apr-util
+           subversion
+           git))
+    (home-page "https://www.xfce.org/")
+    (synopsis "VCS plugin for Thunar file manager")
+    (description
+     "Thunar VCS Plugin (formerly known as Thunar SVN Plugin) gives SVN and
+GIT integration to Thunar, it adds Subversion and GIT actions to the context
+menu.")
+    (license gpl2+)))
+
 (define-public xfwm4
   (package
     (name "xfwm4")
-- 
2.38.1