[bug#33657] website: contact: Improve language tag for traditional Chinese.

Message ID 87h8fp1z7x.fsf@gmail.com
State Accepted
Headers show
Series [bug#33657] website: contact: Improve language tag for traditional Chinese. | expand

Checks

Context Check Description
cbaines/applying patch fail Apply failed

Commit Message

Alex Vong Dec. 7, 2018, 9:08 a.m. UTC
Hmm, I find out the translation is missing a full stop. Re-sending to
fix this as well:

Comments

Ludovic Courtès Sept. 18, 2019, 1:36 p.m. UTC | #1
Hi Alex,

Alex Vong <alexvong1995@gmail.com> skribis:

> From ab77b866cff820a36a9fbd8a600facb12bd4d267 Mon Sep 17 00:00:00 2001
> From: Alex Vong <alexvong1995@gmail.com>
> Date: Fri, 7 Dec 2018 16:06:45 +0800
> Subject: [PATCH] website: contact: Improve language tag for traditional
>  Chinese.
>
> Also add the missing trailing full stop.
>
> See the discussion at:
> <https://lists.gnu.org/archive/html/guix-devel/2018-03/msg00055.html>
>
> * website/apps/base/data.scm (contact-media): Use "zh-Hant" langauge
> tag. Add trailing full stop.

This one had fallen through the cracks…  Please push!

Thanks,
Ludo’.
Ricardo Wurmus Sept. 18, 2019, 2:05 p.m. UTC | #2
Ludovic Courtès <ludo@gnu.org> writes:

> Hi Alex,
>
> Alex Vong <alexvong1995@gmail.com> skribis:
>
>> From ab77b866cff820a36a9fbd8a600facb12bd4d267 Mon Sep 17 00:00:00 2001
>> From: Alex Vong <alexvong1995@gmail.com>
>> Date: Fri, 7 Dec 2018 16:06:45 +0800
>> Subject: [PATCH] website: contact: Improve language tag for traditional
>>  Chinese.
>>
>> Also add the missing trailing full stop.
>>
>> See the discussion at:
>> <https://lists.gnu.org/archive/html/guix-devel/2018-03/msg00055.html>
>>
>> * website/apps/base/data.scm (contact-media): Use "zh-Hant" langauge
>> tag. Add trailing full stop.
>
> This one had fallen through the cracks…  Please push!

Perhaps after fixing the typo: langauge –> language.  ;)
Alex Vong Sept. 18, 2019, 7:33 p.m. UTC | #3
Ricardo Wurmus writes:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Hi Alex,
>>
>> Alex Vong <alexvong1995@gmail.com> skribis:
>>
>>> From ab77b866cff820a36a9fbd8a600facb12bd4d267 Mon Sep 17 00:00:00 2001
>>> From: Alex Vong <alexvong1995@gmail.com>
>>> Date: Fri, 7 Dec 2018 16:06:45 +0800
>>> Subject: [PATCH] website: contact: Improve language tag for traditional
>>>  Chinese.
>>>
>>> Also add the missing trailing full stop.
>>>
>>> See the discussion at:
>>> <https://lists.gnu.org/archive/html/guix-devel/2018-03/msg00055.html>
>>>
>>> * website/apps/base/data.scm (contact-media): Use "zh-Hant" langauge
>>> tag. Add trailing full stop.
>>
>> This one had fallen through the cracks…  Please push!
>

> Perhaps after fixing the typo: langauge –> language.  ;)

Pushed as 3517bad38c1f56bec525489ddb69a52aa3b51280 -
134460d7fdb5372198941407ca15ba72651fdece.

I accidentally pushed an old version of the patch, so I have to fix it
w/ another commit...
Ludovic Courtès Sept. 18, 2019, 8:44 p.m. UTC | #4
Alex Vong <alexvong1995@gmail.com> skribis:

> Pushed as 3517bad38c1f56bec525489ddb69a52aa3b51280 -
> 134460d7fdb5372198941407ca15ba72651fdece.
>
> I accidentally pushed an old version of the patch, so I have to fix it
> w/ another commit...

Heheh, mistakes are fine, no worries.  Thank you!

Ludo’.

Patch

From ab77b866cff820a36a9fbd8a600facb12bd4d267 Mon Sep 17 00:00:00 2001
From: Alex Vong <alexvong1995@gmail.com>
Date: Fri, 7 Dec 2018 16:06:45 +0800
Subject: [PATCH] website: contact: Improve language tag for traditional
 Chinese.

Also add the missing trailing full stop.

See the discussion at:
<https://lists.gnu.org/archive/html/guix-devel/2018-03/msg00055.html>

* website/apps/base/data.scm (contact-media): Use "zh-Hant" langauge
tag. Add trailing full stop.
---
 website/apps/base/data.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/website/apps/base/data.scm b/website/apps/base/data.scm
index b6e9361..265d894 100644
--- a/website/apps/base/data.scm
+++ b/website/apps/base/data.scm
@@ -80,9 +80,9 @@  het Nederlands.")
        "Подпишитесь на список рассылки «Help», чтобы получить помощь от
 сообщества GuixSD и GNU Guix по электронной почте.  Вы можете писать на русском
 языке.")
-      ("zh"
+      ("zh-Hant"
        "訂閱「Help」郵件群組以電郵從GuixSD及GNU Guix社群取得支援。你可以使用
-正體、繁體中文發送訊息"))
+正體、繁體中文發送訊息。"))
 
     #:url "https://lists.gnu.org/mailman/listinfo/help-guix"
     #:log "https://lists.gnu.org/archive/html/help-guix")
-- 
2.19.2