From patchwork Sat Jan 5 23:20:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Patchwork-Id: 682 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id A1DFF16A17; Sat, 5 Jan 2019 23:21:14 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.0 Received: from listsout.gnu.org (listsout.gnu.org [208.118.235.17]) by mira.cbaines.net (Postfix) with ESMTP id 086A216A0B for ; Sat, 5 Jan 2019 23:21:14 +0000 (GMT) Received: from localhost ([127.0.0.1]:45368 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gfvFh-0002iV-Ic for patchwork@mira.cbaines.net; Sat, 05 Jan 2019 18:21:13 -0500 Received: from eggsout.gnu.org ([209.51.188.92]:58696 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gfvFc-0002hA-Ob for guix-patches@gnu.org; Sat, 05 Jan 2019 18:21:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gfvFX-0005Ap-RG for guix-patches@gnu.org; Sat, 05 Jan 2019 18:21:08 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:42228) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gfvFW-00059w-9I for guix-patches@gnu.org; Sat, 05 Jan 2019 18:21:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gfvFW-0005TK-0x for guix-patches@gnu.org; Sat, 05 Jan 2019 18:21:02 -0500 Subject: bug#33770: [PATCH] gnu: Add nip2. Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sat, 05 Jan 2019 23:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 33770 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: L p R n d n Mail-Followup-To: 33770@debbugs.gnu.org, ludo@gnu.org, guix@lprndn.info Received: via spool by 33770-done@debbugs.gnu.org id=D33770.154673044120986 (code D ref 33770); Sat, 05 Jan 2019 23:21:01 +0000 Received: (at 33770-done) by debbugs.gnu.org; 5 Jan 2019 23:20:41 +0000 Received: from localhost ([127.0.0.1]:48119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfvF7-0005SN-QY for submit@debbugs.gnu.org; Sat, 05 Jan 2019 18:20:41 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:34516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfvF5-0005SE-Cl for 33770-done@debbugs.gnu.org; Sat, 05 Jan 2019 18:20:36 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id E96751174; Sun, 6 Jan 2019 00:20:34 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H2-iKjw8t5yw; Sun, 6 Jan 2019 00:20:34 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id DA4B5A81; Sun, 6 Jan 2019 00:20:33 +0100 (CET) From: Ludovic =?utf-8?q?Court=C3=A8s?= References: <87o99eolyf.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 17 =?utf-8?q?Niv=C3=B4se?= an 227 de la =?utf-8?q?R?= =?utf-8?q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 06 Jan 2019 00:20:33 +0100 In-Reply-To: (L. p. R. n. d. n.'s message of "Fri, 04 Jan 2019 20:57:40 +0100") Message-ID: <87h8emzo72.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 33770-done@debbugs.gnu.org Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi, L p R n d n skribis: > Hello, > > Thanks for the review! > > Here is a new version of the Nip2 patch. > For the source, I thought only Github "archives" urls where problematic? Oh you’re right, I was confused. > From 5c32d2e6c940e2d3aef91071417a9774ab7cfe4b Mon Sep 17 00:00:00 2001 > From: Lprndn > Date: Wed, 5 Dec 2018 19:03:13 +0100 > Subject: [PATCH] gnu: Add nip2. > > * gnu/packages/image-processing.scm (nip2): New variable. Applied with the tiny changes below (the configure phase would fail without libjpeg.) Thank you! Ludo’. diff --git a/gnu/packages/image-processing.scm b/gnu/packages/image-processing.scm index f9be2dcab8..9c2ec50bec 100644 --- a/gnu/packages/image-processing.scm +++ b/gnu/packages/image-processing.scm @@ -6,6 +6,7 @@ ;;; Copyright © 2016 Eric Bavier ;;; Copyright © 2018 Tobias Geerinckx-Rice ;;; Copyright © 2018 Björn Höfling +;;; Copyright © 2018 Lprndn ;;; ;;; This file is part of GNU Guix. ;;; @@ -460,13 +461,13 @@ vision algorithms. It can be used to do things like: (base32 "08dxfds4n1vxdilxcw01741a2r6fxyhawi656b7f0hy6znnkbsbc")))) (build-system gnu-build-system) (arguments - `(#:tests? #t - #:phases + `(#:phases (modify-phases %standard-phases ;; test_conv.ws keep failing so disabling for now (add-after 'unpack 'disable-test-conv (lambda _ - (delete-file "test/workspaces/test_conv.ws"))) + (delete-file "test/workspaces/test_conv.ws") + #t)) (add-before 'check 'set-home (lambda _ (setenv "HOME" "/tmp") #t))))) @@ -477,6 +478,7 @@ vision algorithms. It can be used to do things like: ("gtk+-2" ,gtk+-2) ("libxml2" ,libxml2) ("libexif" ,libexif) + ("libjpeg" ,libjpeg) ;required by vips.pc ("librsvg" ,librsvg) ("fftw" ,fftw) ("libgsf" ,libgsf) @@ -494,7 +496,8 @@ vision algorithms. It can be used to do things like: ("pkg-config" ,pkg-config))) (home-page "https://github.com/libvips/nip2") (synopsis "Spreadsheet-like GUI for libvips") - (description "GUI for the VIPS image processing library. -It's a little like a spreadsheet: you create a set of formula connecting your -objects together, and on a change nip2 recalculates") + (description "This package provide a graphical user interface (GUI) for +the VIPS image processing library. It's a little like a spreadsheet: you +create a set of formula connecting your objects together, and on a change nip2 +recalculates.") (license license:gpl2+)))