diff mbox series

[bug#36947] reconfigure: Fix GC root installation.

Message ID 87h86uxkir.fsf@sdf.lonestar.org
State Accepted
Headers show
Series [bug#36947] reconfigure: Fix GC root installation. | expand

Commit Message

Jakob L. Kreuze Aug. 6, 2019, 5:37 p.m. UTC 
Fixes <https://bugs.gnu.org/36942>.
Reported by ison <ison@airmail.cc>.

guix/scripts/system/reconfigure.scm (install-bootloader-program): Switch
new symlink to the canonical bootloader configuration file.
---
 guix/scripts/system/reconfigure.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Danny Milosavljevic Aug. 6, 2019, 8:27 p.m. UTC | #1 
Hi Jakob,

thanks for that patch!

Pushed to guix master with a huge comment, as commit
5f04e9f9620aeb45940855e4f655f22db55ba6eb.

Feel free to Cc me with important installation-saving patches like that one.
Jakob L. Kreuze Aug. 6, 2019, 8:47 p.m. UTC | #2 
Hi Danny,

Danny Milosavljevic <dannym@scratchpost.org> writes:

> Hi Jakob,
>
> thanks for that patch!

My pleasure :)

> Pushed to guix master with a huge comment, as commit
> 5f04e9f9620aeb45940855e4f655f22db55ba6eb.
>
> Feel free to Cc me with important installation-saving patches like that one.

Heh, I'll keep that in mind

Regards,
Jakob
diff mbox series

Patch

diff --git a/guix/scripts/system/reconfigure.scm b/guix/scripts/system/reconfigure.scm
index dee0c24bd2..72d97b6c48 100644
--- a/guix/scripts/system/reconfigure.scm
+++ b/guix/scripts/system/reconfigure.scm
@@ -196,7 +196,7 @@  BOOTLOADER-PACKAGE."
                         (srfi srfi-35))
            (let* ((gc-root (string-append #$target %gc-roots-directory "/bootcfg"))
                   (temp-gc-root (string-append gc-root ".new")))
-             (switch-symlinks temp-gc-root gc-root)
+             (switch-symlinks temp-gc-root #$bootcfg)
              (install-boot-config #$bootcfg #$bootcfg-file #$target)
              ;; Preserve the previous activation's garbage collector root
              ;; until the bootloader installer has run, so that a failure in