diff mbox series

[bug#38810] services: console-font: Update example with HDPI font suggestion.

Message ID 87h81ihxt0.fsf@gnu.org
State Accepted
Headers show
Series [bug#38810] services: console-font: Update example with HDPI font suggestion. | expand

Commit Message

Janneke Nieuwenhuizen Dec. 30, 2019, 11:12 a.m. UTC 
Hi,

Another HDPI-inspired patch; since Marrakech I finally have a readable
console font, thanks to Bernhard M. Wiedemann.

This solution enters the manual in a kind of tricksy way.  More
seriously, when updating the `guix system search console font' example
output, I found that mingetty and login and ... entries to be missing.
Is that a bug, or should the output be fixed?  We could also change
the example command to `guix search console', then those entries are
present again.

Greetings,
janneke

Comments

Ludovic Courtès Dec. 30, 2019, 9:58 p.m. UTC | #1 
Hi!

Jan Nieuwenhuizen <janneke@gnu.org> skribis:

> Another HDPI-inspired patch; since Marrakech I finally have a readable
> console font, thanks to Bernhard M. Wiedemann.

:-)

> This solution enters the manual in a kind of tricksy way.  More
> seriously, when updating the `guix system search console font' example
> output, I found that mingetty and login and ... entries to be missing.
> Is that a bug, or should the output be fixed?  We could also change
> the example command to `guix search console', then those entries are
> present again.

Yeah, we should just change the example to “guix search console”.

>>From 1b0d736405354c2c1aeb7aee00e63307d956ceae Mon Sep 17 00:00:00 2001
> From: Jan Nieuwenhuizen <janneke@gnu.org>
> Date: Mon, 30 Dec 2019 11:56:58 +0100
> Subject: [PATCH] services: console-font: Update example with HDPI font
>  suggestion.
>
> This solution was kindly provided by Bernard M. Wiedemann.
>
> * gnu/services/base.scm (console-font-service-type): Add ter132n (terminus 132
> nomal) font example, for HDPI displays.
> * doc/guix.texi (Invoking guix system): Update `guix system search console
> font' example output.

LGTM!

> +@cindex HDPI

Do people expect “HDPI” or “HiDPI”?  Wikipedia says both:
<https://en.wikipedia.org/wiki/Pixel_density#Named_pixel_densities>.
Perhaps add two cindex entries then?

Thanks!

Ludo’.
Janneke Nieuwenhuizen Dec. 30, 2019, 10:40 p.m. UTC | #2 
Ludovic Courtès writes:

>> Another HDPI-inspired patch; since Marrakech I finally have a readable
>> console font, thanks to Bernhard M. Wiedemann.
>
> :-)

Yes, that was so helpful!  I've been trying from time to time and did
not succeed until now.

> Yeah, we should just change the example to “guix search console”.

Okay, changed to "guix system search console".

> LGTM!

Thanks, pushed to master.

>> +@cindex HDPI
>
> Do people expect “HDPI” or “HiDPI”?  Wikipedia says both:
> <https://en.wikipedia.org/wiki/Pixel_density#Named_pixel_densities>.
> Perhaps add two cindex entries then?

Sure.  HDPI is more common on the interwebs, I just added HiDPI; thanks!
Always nice if you can find what you are looking fore :)

janneke
diff mbox series

Patch

From 1b0d736405354c2c1aeb7aee00e63307d956ceae Mon Sep 17 00:00:00 2001
From: Jan Nieuwenhuizen <janneke@gnu.org>
Date: Mon, 30 Dec 2019 11:56:58 +0100
Subject: [PATCH] services: console-font: Update example with HDPI font
 suggestion.

This solution was kindly provided by Bernard M. Wiedemann.

* gnu/services/base.scm (console-font-service-type): Add ter132n (terminus 132
nomal) font example, for HDPI displays.
* doc/guix.texi (Invoking guix system): Update `guix system search console
font' example output.
---
 doc/guix.texi         | 20 +++++++++++++++-----
 gnu/services/base.scm |  6 +++++-
 2 files changed, 20 insertions(+), 6 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 02cecae043..298b9a531c 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -25980,17 +25980,27 @@  supported:
 Display available service type definitions that match the given regular
 expressions, sorted by relevance:
 
+@cindex HDPI
+@cindex resolution
 @example
 $ guix system search console font
 name: console-fonts
 location: gnu/services/base.scm:729:2
 extends: shepherd-root
-description: Install the given fonts on the specified ttys (fonts are
-+ per virtual console on GNU/Linux).  The value of this service is a list
-+ of tty/font pairs like:
+description: Install the given fonts on the specified ttys
++ (fonts are per virtual console on GNU/Linux).  The value of this
++ service is a list of tty/font pairs.  The font can be the name
++ of a font provided by the `kbd' package or any valid argument to
++ `setfont', as in this example:
 + 
-+      '(("tty1" . "LatGrkCyr-8x16"))
-relevance: 20
++      '(("tty1" . "LatGrkCyr-8x16")
++        ("tty2" . (file-append
++                      font-tamzen
++                      "/share/kbd/consolefonts/TamzenForPowerline10x20.psf"))
++        ("tty3" . (file-append
++                      font-terminus
++                      "/share/consolefonts/ter-132n"))) ; for HDPI
+relevance: 32
 
 name: mingetty
 location: gnu/services/base.scm:1048:2
diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index b1eff89ecc..77215e411c 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -10,6 +10,7 @@ 
 ;;; Copyright © 2019 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2019 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2019 John Soo <jsoo1@asu.edu>
+;;; Copyright © 2019 Jan (janneke) Nieuwenhuizen <janneke@gnu.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -818,7 +819,10 @@  package or any valid argument to @command{setfont}, as in this example:
 '((\"tty1\" . \"LatGrkCyr-8x16\")
   (\"tty2\" . (file-append
                 font-tamzen
-                \"/share/kbd/consolefonts/TamzenForPowerline10x20.psf\")))
+                \"/share/kbd/consolefonts/TamzenForPowerline10x20.psf\"))
+  (\"tty3\" . (file-append
+                font-terminus
+                \"/share/consolefonts/ter-132n\"))) ; for HDPI
 @end example\n")))
 
 (define* (console-font-service tty #:optional (font "LatGrkCyr-8x16"))
-- 
2.24.0