diff mbox series

[bug#53726] gnu: Add emacs-popup-kill-ring

Message ID 87h79hdycz.fsf@gmail.com
State Accepted
Headers show
Series [bug#53726] gnu: Add emacs-popup-kill-ring | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue

Commit Message

Jai Vetrivelan Feb. 2, 2022, 4:31 p.m. UTC

Comments

Nicolas Goaziou Feb. 6, 2022, 9:54 p.m. UTC | #1 
Hello,

Jai Vetrivelan <jaivetrivelan@gmail.com> writes:

> Subject: [PATCH] gnu: Add emacs-popup-kill-ring.

Thank you.

> * gnu/packages/emacs-xyz.scm: (emacs-popup-kill-ring) new variable.

Nitpick: the colon should come after the closing bracket.

> +(define-public emacs-popup-kill-ring
> +  (let ((version "0.2.8") (revision "0")
> +        (commit "a45c9cf79c4e1207fdbdd662e161154ef224ad61"))
> +    (package
> +      (name "emacs-popup-kill-ring")
> +      (version (git-version version revision commit))

I inserted the version string above.

> +      (description "Browse your Emacs kill-ring in an autocomplete style popup
> + menu.")

I reworded the description so it would be a complete sentence.

Regards,
diff mbox series

Patch

From 3808b640f9b15d8af42e9d319312c0368b8b416c Mon Sep 17 00:00:00 2001
From: Jai Vetrivelan <jaivetrivelan@gmail.com>
Date: Wed, 2 Feb 2022 18:14:49 +0530
Subject: [PATCH] gnu: Add emacs-popup-kill-ring.

* gnu/packages/emacs-xyz.scm: (emacs-popup-kill-ring) new variable.
---
 gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 8ce245c54a..2087e27e58 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -7065,6 +7065,29 @@  (define-public emacs-popup
 and popup menus.")
     (license license:gpl3+)))
 
+(define-public emacs-popup-kill-ring
+  (let ((version "0.2.8") (revision "0")
+        (commit "a45c9cf79c4e1207fdbdd662e161154ef224ad61"))
+    (package
+      (name "emacs-popup-kill-ring")
+      (version (git-version version revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/waymondo/popup-kill-ring")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "0bpnsc4agy6mcnc79d9a6gi79jiiqrhf3a55pw0p4z16m86vwyqr"))))
+      (build-system emacs-build-system)
+      (propagated-inputs (list emacs-pos-tip emacs-popup))
+      (home-page "https://github.com/waymondo/popup-kill-ring")
+      (synopsis "Interactively insert item from kill-ring")
+      (description "Browse your Emacs kill-ring in an autocomplete style popup
+ menu.")
+      (license license:gpl3+))))
+
 (define-public emacs-python-black
   (package
     (name "emacs-python-black")

base-commit: 5783091d66ba0a0b7892f5c2554453f3c4ae4d2d
-- 
2.34.0