From patchwork Tue Jun 21 14:02:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jose G Perez Taveras X-Patchwork-Id: 40209 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 858AD27BBEA; Tue, 21 Jun 2022 15:22:16 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 73B4327BBE9 for ; Tue, 21 Jun 2022 15:22:15 +0100 (BST) Received: from localhost ([::1]:40358 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o3eli-0008Ur-49 for patchwork@mira.cbaines.net; Tue, 21 Jun 2022 10:22:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46160) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3elW-0008UC-BP for guix-patches@gnu.org; Tue, 21 Jun 2022 10:22:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39141) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o3elW-0002gt-25 for guix-patches@gnu.org; Tue, 21 Jun 2022 10:22:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o3elV-0000cN-ND for guix-patches@gnu.org; Tue, 21 Jun 2022 10:22:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56111] [PATCH] gnu: playerctl: update to 2.4.1. Resent-From: Jose G Perez Taveras Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 21 Jun 2022 14:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56111 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 56111@debbugs.gnu.org X-Debbugs-Original-Cc: 56111@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16558212842319 (code B ref -1); Tue, 21 Jun 2022 14:22:01 +0000 Received: (at submit) by debbugs.gnu.org; 21 Jun 2022 14:21:24 +0000 Received: from localhost ([127.0.0.1]:33038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3eku-0000bK-Hq for submit@debbugs.gnu.org; Tue, 21 Jun 2022 10:21:24 -0400 Received: from lists.gnu.org ([209.51.188.17]:47588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3ekp-0000av-3e for submit@debbugs.gnu.org; Tue, 21 Jun 2022 10:21:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46050) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3eko-0008Dp-8K for guix-patches@gnu.org; Tue, 21 Jun 2022 10:21:18 -0400 Received: from mail-qk1-x732.google.com ([2607:f8b0:4864:20::732]:34693) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o3ekm-0002YW-8M for guix-patches@gnu.org; Tue, 21 Jun 2022 10:21:17 -0400 Received: by mail-qk1-x732.google.com with SMTP id n197so10206345qke.1 for ; Tue, 21 Jun 2022 07:21:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=tVwrQ4ZRsRHUJdgV0vStBP1V1A6damclLMX+mxRDcsY=; b=l2IYt5MRuyV8EAPhjkt+u9j0Y3Ul2U/S9iRjCWG1KiTZkkeS/G00bPwDh+ueQN4BqY 5yDAoZ2F5B7OHJSumJAD2l5IkpW8HJKTaKSWajBD1R543bgdCOCqrar4XlNg9XXSah4n KvmUTVQhqYR75jMUnvQmV3G9BwPvJi0hORSS8qhW8crjK+JxG9x8ONevSRMErgJj+bbT zH69msM5vNu1JZ5hibCEi9wOiOzT0Bgwog4aHM7sV9vkC39ZDY6NEqTD8We0/m46ehD7 L329BzRGSj34Ja3ovDXDCanEwIn2mXewMQ6BJ+22qStv4rYbE558BCQJQgw2QITmQ2FF 8Wqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=tVwrQ4ZRsRHUJdgV0vStBP1V1A6damclLMX+mxRDcsY=; b=ITloUQtRDM232msjffKvfPVHsFVb1e3mxZRnIk2b1mDh2ltXywErGT44GCR7UGhutl xRRqzz4GWAoeV+qGfDZ4zLFwS243+WGgISR/DGI77CSOXBCv7Cjv31odH8ib82ANkB8X M7izwLJYLOAt0y5/He49JKJfWh/l6NnMlimn0rPb8ApQ22h4UGu6LE3x5FD9I18ILq0S OEj0Q5zOldHCEGiCAkgy4SKcaWrnOejEdSkH00HGnrJ/Gg/sLeuLqDrVE6ms6e+flbZR Mx2aJ4sTR5hao3Ma8xHCebHD6FZJ/p1S/tSvLs5utUnkHa14KQ/NFGGqVBz6ygQLyXNg yUig== X-Gm-Message-State: AJIora8FHo2SzsJ+EgTbMtJRo/JRAA9CwB4X28Ht65vflEBhLKRUtK/K J3l8rEhZMkZ4FDe3HpEl8NnThCd4GNTuKQ== X-Google-Smtp-Source: AGRyM1sGV21VoudGOeWcG+rn3/jWn5F0FGRmkkSqh0oirvqoeLBUYZGwy02MrAW6LBqTayQNX5uU/g== X-Received: by 2002:a37:4044:0:b0:6a7:93bd:e20e with SMTP id n65-20020a374044000000b006a793bde20emr19936689qka.654.1655821274862; Tue, 21 Jun 2022 07:21:14 -0700 (PDT) Received: from goblin-slayer (pool-72-76-213-26.nwrknj.fios.verizon.net. [72.76.213.26]) by smtp.gmail.com with ESMTPSA id r2-20020ac85c82000000b00304e688189fsm13311350qta.37.2022.06.21.07.21.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jun 2022 07:21:14 -0700 (PDT) References: <20220620170517.18322-1-josegpt27@gmail.com> <87v8su1cd4.fsf@cbaines.net> User-agent: mu4e 1.6.11; emacs 29.0.50 From: Jose G Perez Taveras Date: Tue, 21 Jun 2022 10:02:35 -0400 In-reply-to: <87v8su1cd4.fsf@cbaines.net> Message-ID: <87h74ep06p.fsf@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::732; envelope-from=josegpt27@gmail.com; helo=mail-qk1-x732.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Christopher Baines writes: > [[PGP Signed Part:Undecided]] > > Jose G Perez Taveras writes: > >> Hello, >> >> Here is an update to playerctl to 2.4.1 and fixed dependencies. >> It uses `dbus-launch' to start a new daemon. >> >> This is my first time sending a patch, I would be very happy if you >> could point me out to anything I should know. > > Hi Jose, > > Thanks for the patch. > >> + (propagated-inputs (list dbus)) > > The addition of dbus as a propagated input was the only thing that stood > out to me. > > If playerctl does call out to dbus-launch, then patching the source to > refer to the specific /gnu/store/...-dbus/.../dbus-launch binary would > be the nicest approach, since that would avoid propagating dbus. > > Is it necessary to propagate the dbus package, and if so, what doesn't > work if you don't? > > Thanks, > > Chris > > [[End of PGP Signed Part]] Hello Christopher, I kept on testing the patch. As you mentioned, propagating dbus is not necessary for the package to work correctly. Thank you for the feedback. Best, josegpt Here's an updated version of the patch. --- gnu/packages/music.scm | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) base-commit: d13ffd1580ec2253b6e05fb6300c3629aee893e3 diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index 60cb176320..2d0d582e6c 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -48,6 +48,7 @@ ;;; Copyright © 2022 Remco van 't Veer ;;; Copyright © 2022 Maxim Cournoyer ;;; Copyright © 2022 Wamm K. D. +;;; Copyright © 2022 Jose G Perez Taveras ;;; ;;; This file is part of GNU Guix. ;;; @@ -5562,7 +5563,7 @@ (define-public pragha (define-public playerctl (package (name "playerctl") - (version "2.2.1") + (version "2.4.1") (source (origin (method git-fetch) (uri (git-reference @@ -5571,14 +5572,14 @@ (define-public playerctl (file-name (git-file-name name version)) (sha256 (base32 - "17hi33sw3663qz5v54bqqil31sgkrlxkb2l5bgqk87pac6x2wnbz")))) + "0ij065blj3h5v6iivvpmgh1095vicj1nc7hp1nhlhpqagd98l89s")))) (build-system meson-build-system) (arguments - `(#:configure-flags '("-Dintrospection=false" "-Dgtk-doc=false"))) - (inputs (list python-pygobject)) + `(#:configure-flags '("-Dgtk-doc=false"))) (native-inputs `(("glib:bin" ,glib "bin") - ("pkg-config" ,pkg-config))) + ("pkg-config" ,pkg-config) + ("gobject-introspection" ,gobject-introspection))) (synopsis "Control MPRIS-supporting media player applications") (description "Playerctl is a command-line utility and library for controlling media