diff mbox

[bug#37121,00/40] Update Xfce to 4.14

Message ID 87ftlezu05.fsf@lprndn.info
State Accepted
Headers show

Commit Message

L p R n d n Sept. 2, 2019, 1:51 p.m. UTC 
Hello,

Ludovic Courtès <ludo@gnu.org> writes:

> Hello,
>
> L  p R n  d n    <guix@lprndn.info> skribis:
>
>> Ludovic Courtès <ludo@gnu.org> writes:
>>
>>> Hello,
>>>
>>> L  p R n  d n    <guix@lprndn.info> skribis:
>>>
>>>> Here is my take on updating xfce to 4.14.
>>>
>>> Woow, thanks for all the work!
>>>
>>>> The update switches Xfce to gtk-3 but gtk-2 compatibility is kept.
>>>> Also there a few changes to add or clarify some features like vala API
>>>> or gobject introspection.
>>>> Testing is welcome.
>>>
>>> So, I hope you won’t hate me for asking, but… can we separate the bits
>>> that are really part of the Xfce upgrade or required by the upgrade,
>>> from those that are not directly related?  The libxklavier, mousepad,
>>> and “fix tests” changes come to mind.  That would make the review work
>>> less intimidating.  :-)
>>>
>>> Also, I suspect all the xfce* and libxf* packages need to be upgraded in
>>> lockstep; that is, they all need to be either 4.14 or 4.12, but not a
>>> mixture thereof.  Thus, I’d actually prefer a single commit upgrading
>>> all of these.  WDYT?
>>>
>>> There are probably exceptions such as Thunar that do not strictly need
>>> to be upgraded at the same time; these can remain in a separate commit.
>>
>> No problem. It's more git training!
>
> :-)
>
>> I'll make a single commit for all xfce4-core packages and leave the rest
>> sepearate. Is it ok?
>
> Yes, all those that need to be updated together (which I think are the
> libxf* and xfce* packages, but again I’m no Xfce expert) should go in
> one patch.
>
>> Also, do you need me to send them at this bug report or a new one?
>
> Please send the Xfce upgrade here, and the patches that are not
> Xfce-specific elsewhere.
>

Here are the new patches. Hope everything it's ok.
I took the liberty to send the as attachment to avoid scambling them.
There is one main patch for base xfce components' update + patches for
other packages part of xfce. I also added two new components of xfce.
I'll send the rest in their own bug report.

Reminder, those patches should not be merged before patch #37253:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37253

Thanks,

> Thank you!
>
> Ludo’.

Have a nice day,

L  p R n  d n

Comments

Ludovic Courtès Sept. 1, 2019, 9:05 p.m. UTC | #1 
Hello,

L  p R n  d n    <guix@lprndn.info> skribis:

> Here are the new patches. Hope everything it's ok.
> I took the liberty to send the as attachment to avoid scambling them.
> There is one main patch for base xfce components' update + patches for
> other packages part of xfce. I also added two new components of xfce.
> I'll send the rest in their own bug report.

I applied all these except that last 3 patches, which you can send in a
separate issue when you’re ready.

Thanks!

Ludo’.
L p R n d n Sept. 2, 2019, 2:08 p.m. UTC | #2 
Re-hello,


Please forget the last two patches adding xfce4-screensaver and
xfce4-screenshooter as the TODO comments should have clearly given me a
hint on their state..

Have a nice day,

L  p R n  d n
diff mbox

Patch

From 3ae5ddbc88527419e3f64e42aad5e7aa351fdb24 Mon Sep 17 00:00:00 2001
From: L  p R n  d n <guix@lprndn.info>
Date: Tue, 20 Aug 2019 22:39:34 +0200
Subject: [PATCH 11/11] gnu: Add copyright header.

* gnu/packages/xfce.scm: Add copyright header.
---
 gnu/packages/xfce.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 98918883ce..752513db89 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -9,6 +9,7 @@ 
 ;;; Copyright © 2017 ng0 <ng0@n0.is>
 ;;; Copyright © 2018, 2019 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2019 Pkill -9 <pkill9@runbox.com>
+;;; Copyright © 2019 L  p R n  d n <guix@lprndn.info>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
-- 
2.22.0