diff mbox series

[bug#41048] doc: add comment about ofl for Pam mount.

Message ID 87ftch42bx.fsf@rohleder.de
State Accepted
Headers show
Series [bug#41048] doc: add comment about ofl for Pam mount. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch fail View Laminar job

Commit Message

Michael Rohleder May 3, 2020, 12:42 p.m. UTC 
Pam mount uses `ofl` from hxtools [1] to kill processes that have open
files on the filesystem mounted.
As we dont have hxtools (and I think we shouldnt), one has to configure
pam mount to use something else, eg `fuser`. This is an attempt to
document that somehow.
Footnotes: 
[1]  https://github.com/ghthor/hxtools

Comments

Ludovic Courtès Sept. 2, 2020, 2:49 p.m. UTC | #1 
Hi,

This patch fell through the cracks…

Michael Rohleder <mike@rohleder.de> skribis:

> Pam mount uses `ofl` from hxtools [1] to kill processes that have open
> files on the filesystem mounted.
> As we dont have hxtools (and I think we shouldnt), one has to configure
> pam mount to use something else, eg `fuser`. This is an attempt to
> document that somehow.
>
> From 7a3cd9cd00cbd95e599a8d79400591e2fc589f33 Mon Sep 17 00:00:00 2001
> From: Michael Rohleder <mike@rohleder.de>
> Date: Sun, 3 May 2020 14:17:37 +0200
> Subject: [PATCH] doc: add comment about ofl for Pam mount.
>
> * doc/guix.texi: (Pam Mount) add comment about ofl.
> ---
>  doc/guix.texi | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/doc/guix.texi b/doc/guix.texi
> index d5d8662937..aa182df183 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -25441,6 +25441,8 @@ the partition where he stores his data:
>                         (hup "0")
>                         (term "no")
>                         (kill "no")))
> +            ;; if anything above is "true":
> +            ;; (ofl "/run/current-system/profile/bin/fuser -km %(MNTPT)")

It’s not clear what these two lines mean.  The idea is to tell users to
configure PAM Mount to use ‘fuser’ as a replacement for ‘ofl’, right?  I
think that’d deserve one or two sentences of explanation.  WDYT?

Thanks,
Ludo’.
Michael Rohleder Sept. 2, 2020, 3:25 p.m. UTC | #2 
Hi Ludo!

Ludovic Courtès <ludo@gnu.org> writes:
>> +            ;; if anything above is "true":
>> +            ;; (ofl "/run/current-system/profile/bin/fuser -km %(MNTPT)")
>
> It’s not clear what these two lines mean.  The idea is to tell users to
> configure PAM Mount to use ‘fuser’ as a replacement for ‘ofl’, right?  I
> think that’d deserve one or two sentences of explanation.  WDYT?

Yes, that is/was the idea, because killing processes would not work
otherwise.
Now that we have autofs, I don't think it's relevant any more, so we can
close it?
Ludovic Courtès Sept. 2, 2020, 8:18 p.m. UTC | #3 
Hi Michael,

Michael Rohleder <mike@rohleder.de> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>>> +            ;; if anything above is "true":
>>> +            ;; (ofl "/run/current-system/profile/bin/fuser -km %(MNTPT)")
>>
>> It’s not clear what these two lines mean.  The idea is to tell users to
>> configure PAM Mount to use ‘fuser’ as a replacement for ‘ofl’, right?  I
>> think that’d deserve one or two sentences of explanation.  WDYT?
>
> Yes, that is/was the idea, because killing processes would not work
> otherwise.

OK.

> Now that we have autofs, I don't think it's relevant any more, so we can
> close it?

Fine with me, done!

Thanks,
Ludo’.
diff mbox series

Patch

From 7a3cd9cd00cbd95e599a8d79400591e2fc589f33 Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike@rohleder.de>
Date: Sun, 3 May 2020 14:17:37 +0200
Subject: [PATCH] doc: add comment about ofl for Pam mount.

* doc/guix.texi: (Pam Mount) add comment about ofl.
---
 doc/guix.texi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/doc/guix.texi b/doc/guix.texi
index d5d8662937..aa182df183 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -25441,6 +25441,8 @@  the partition where he stores his data:
                        (hup "0")
                        (term "no")
                        (kill "no")))
+            ;; if anything above is "true":
+            ;; (ofl "/run/current-system/profile/bin/fuser -km %(MNTPT)")
             (mkmountpoint (@@ (enable "1")
                              (remove "true")))))
 
-- 
2.26.2