From patchwork Wed Mar 24 19:48:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Oleg Pykhalov X-Patchwork-Id: 28068 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 14D3A27BC5C; Wed, 24 Mar 2021 19:49:12 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,SPF_HELO_PASS, T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 7121027BC59 for ; Wed, 24 Mar 2021 19:49:11 +0000 (GMT) Received: from localhost ([::1]:60992 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lP9V8-0000VY-EU for patchwork@mira.cbaines.net; Wed, 24 Mar 2021 15:49:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33700) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lP9V0-0000VI-Mi for guix-patches@gnu.org; Wed, 24 Mar 2021 15:49:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52824) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lP9V0-0004tl-El for guix-patches@gnu.org; Wed, 24 Mar 2021 15:49:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lP9V0-0002xr-DB for guix-patches@gnu.org; Wed, 24 Mar 2021 15:49:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47364] [PATCH 2/2] services: slim: Add pam-gnupg support. Resent-From: Oleg Pykhalov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 24 Mar 2021 19:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47364 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 47364@debbugs.gnu.org Received: via spool by 47364-submit@debbugs.gnu.org id=B47364.161661530511335 (code B ref 47364); Wed, 24 Mar 2021 19:49:02 +0000 Received: (at 47364) by debbugs.gnu.org; 24 Mar 2021 19:48:25 +0000 Received: from localhost ([127.0.0.1]:36137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lP9UP-0002wl-AS for submit@debbugs.gnu.org; Wed, 24 Mar 2021 15:48:25 -0400 Received: from mail-lj1-f179.google.com ([209.85.208.179]:46704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lP9UN-0002wT-1O for 47364@debbugs.gnu.org; Wed, 24 Mar 2021 15:48:23 -0400 Received: by mail-lj1-f179.google.com with SMTP id u20so102404lja.13 for <47364@debbugs.gnu.org>; Wed, 24 Mar 2021 12:48:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=beca2QewKkrCQkvL4D88G8qPnxyivX5Iz20YFR6yswk=; b=sMI0FN4fL8LgD+10PyuATnnuCuprCfSrkvri2ZSFuH9X1MV3IpQbJ2L+evhJCXoWTh /BrbXMzlmRXaM5L9QIA5V5BMrdRarCkqzvZl7MmlSrOI2B/r151SHde9sWRSeVHq+XkE uvc9SdnqTtucAJf++dKJm/RSyPAf5Fbhij6OH2PXXEO1+D3lCQXiFCS1G44SCggUs/Re TP0Y3bfLSMaISvDtUEcNubvYoxhpR1N6HDamgpaheM9iQlos7Y5IVtS50utE3AxVFD2/ VvvMXpuuWdvQlV/wpqo/CD19vmgxrfTTpdq1NDay/li1wUHs/JZbEf12cILbnvcYuEBi RETQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=beca2QewKkrCQkvL4D88G8qPnxyivX5Iz20YFR6yswk=; b=gLUYK7b4Kun2MW1+V9bcwp1kdDQiOKbM9bGUcQv4VF60BWXYsprvsDJ7JB+CkY8vwL 6JTi/DLS18cYPKI4NTexmGlf70g3xWt7s8Aoi3PZDocagYy3izxrJ934oWYtzM2P2fOH +QjFREDpLtLD1xMW0LkeuLiHSyywBZGMeWpgz7ntDpjfwve/POr1hyDSYas4VOTmjLEg kZHEK9fqBMCW1KHgAL5Bs8Jyy7hHWhE/YwY4sFUuzEyFU7Njk0l9yek7caWYw2oMHces Z2dRY8r2Z5PKVyRSNVdb8oPGyMfI+3LkJwalwftH+Ga2ZXLdeOfGAQUFPH5hqujkgJUA 8s1w== X-Gm-Message-State: AOAM532+mrIk/U723ihFcJII4d8EULnk9Rrp8cpONVnfDugIWFtozwnR 8p3y8WOeuhh1DCAHeHwySlvKegTsgrI= X-Google-Smtp-Source: ABdhPJxhKnxUD7B+hFTBxX4cWnxUD0N7Z2ZMzlwBir9C6W2uRbpkyOBbdIv176syVW0aOWD5JFu3bA== X-Received: by 2002:a2e:95c7:: with SMTP id y7mr3076849ljh.499.1616615296438; Wed, 24 Mar 2021 12:48:16 -0700 (PDT) Received: from guixsd ([88.201.161.72]) by smtp.gmail.com with ESMTPSA id s12sm314456lfc.207.2021.03.24.12.48.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 12:48:15 -0700 (PDT) From: Oleg Pykhalov References: <20210324165233.28428-1-go.wigust@gmail.com> <20210324165233.28428-2-go.wigust@gmail.com> <6ca83b55b46c4677a45fd0e026ac14880093ea7f.camel@telenet.be> Date: Wed, 24 Mar 2021 22:48:01 +0300 In-Reply-To: <6ca83b55b46c4677a45fd0e026ac14880093ea7f.camel@telenet.be> (Maxime Devos's message of "Wed, 24 Mar 2021 20:22:43 +0100") Message-ID: <87ft0ks58u.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi, Thank you for the review! Maxime Devos writes: > I'm not familiar with PAM, so I can't do much reviewing about that > (seems ok, though I'm no expert). I'm :-) too, but it works for me. […] I applied all your suggestions. Plus in Git commit message “Don't pass "#f" to "allow-root?" argument, because "lambda*" already does this by default.”. diff --git a/gnu/system/pam.scm b/gnu/system/pam.scm index 75edd01908..128b2bb0fe 100644 --- a/gnu/system/pam.scm +++ b/gnu/system/pam.scm @@ -208,14 +208,16 @@ dumped in /etc/pam.d/NAME, where NAME is the name of SERVICE." (env (pam-entry ; to honor /etc/environment. (control "required") (module "pam_env.so")))) - (lambda* (name #:key allow-empty-passwords? (allow-root? #f) motd - login-uid? (gnupg? #f)) + (lambda* (name #:key allow-empty-passwords? allow-root? motd + login-uid? gnupg?) "Return a standard Unix-style PAM service for NAME. When ALLOW-EMPTY-PASSWORDS? is true, allow empty passwords. When ALLOW-ROOT? is true, allow root to run the command without authentication. When MOTD is true, it should be a file-like object used as the message-of-the-day. When LOGIN-UID? is true, require the 'pam_loginuid' module; that module sets -/proc/self/loginuid, which the libc 'getlogin' function relies on." +/proc/self/loginuid, which the libc 'getlogin' function relies on. When +GNUPG? is true, require the 'pam_gnupg.so' module; that module hands over +login password to 'gpg-agent'." ;; See . (pam-service (name name)