Message ID | 87fsdjwhyd.fsf@gnu.org |
---|---|
State | New |
Headers | show |
Series | bug#58136: [PATCH] ui: Improve sort order when searching package names. | expand |
Hi Ludo, > Applied with the minor changes below, thank you! thank you! > +(test-assert "package-relevance and upstream name" > + ;; https://issues.guix.gnu.org/58136 > + (let ((ggplot2 (specification->package "r-ggplot2")) > + (ggstance (specification->package "r-ggstance")) > + (rx (make-regexp "ggplot2" regexp/icase))) > + (> (package-relevance ggplot2 (list rx)) > + (package-relevance ggstance (list rx)) > + 0))) I was hesitant to add a system test, which depends on real package descriptions (not synthetic ones), because at some point it *will* break. Cheers, Lars
Hi, Lars-Dominik Braun <lars@6xq.net> skribis: >> Applied with the minor changes below, thank you! > thank you! > >> +(test-assert "package-relevance and upstream name" >> + ;; https://issues.guix.gnu.org/58136 >> + (let ((ggplot2 (specification->package "r-ggplot2")) >> + (ggstance (specification->package "r-ggstance")) >> + (rx (make-regexp "ggplot2" regexp/icase))) >> + (> (package-relevance ggplot2 (list rx)) >> + (package-relevance ggstance (list rx)) >> + 0))) > I was hesitant to add a system test, which depends on real package > descriptions (not synthetic ones), because at some point it *will* break. Yes, that’s a tradeoff. For now, I would think the test is a plus as it will allow us to see if future tweaks break this use case but yeah, on the day it breaks, we’ll have to rewrite it or to drop it. Ludo’.
diff --git a/tests/ui.scm b/tests/ui.scm index 6a25a204ca..438acae525 100644 --- a/tests/ui.scm +++ b/tests/ui.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2013, 2014, 2015, 2016, 2017, 2019, 2020 Ludovic Courtès <ludo@gnu.org> +;;; Copyright © 2013-2017, 2019-2020, 2022 Ludovic Courtès <ludo@gnu.org> ;;; Copyright © 2022 Taiju HIGASHI <higashi@taiju.info> ;;; ;;; This file is part of GNU Guix. @@ -294,6 +294,15 @@ (define guile-2.0.9 (>0 (package-relevance libb2 (map rx '("crypto" "library"))))))) +(test-assert "package-relevance and upstream name" + ;; https://issues.guix.gnu.org/58136 + (let ((ggplot2 (specification->package "r-ggplot2")) + (ggstance (specification->package "r-ggstance")) + (rx (make-regexp "ggplot2" regexp/icase))) + (> (package-relevance ggplot2 (list rx)) + (package-relevance ggstance (list rx)) + 0))) + (define (make-empty-file directory file) ;; Create FILE in DIRECTORY. (close-port (open-output-file (in-vicinity directory file))))